[GitHub] geode pull request #732: GEODE-3276: Managing race conditions while the send...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/732


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Updating Spotless

[Kirk Lund]

I'm for making our spotless better match our style guide, and it's easy
enough to update branches with this.

On Wed, Aug 23, 2017 at 4:31 PM, Patrick Rhomberg 
wrote:

> [tl;dr:]
> - We are inconsistent with our own established style rules.
> - We should become not that.
> - How do we coordinate becoming better?
> - Do you have any other areas where we can become more spotless?
>
> --
> Hello, devs.
>
>   There are a great many instances throughout the geode codebase that are
> in direct contention with our documented style guide [1].  These strike me
> as glaring broken windows, but thankfully fixing some of these issues is a
> very low-hanging fruit (the mixing of metaphors notwithstanding).
>
>   I've explored some updates to spotlessApply can that correct some of
> these issues.  These changes can be seen on my repo, linked below ([2]).  I
> have covered the following:
> - adherence to the import ordering given in
> /etc/eclipseOrganizeImports.importorder
> - adherence to modifier ordering, as given in our adoption of the Google
> Style Guide ([3])
> - removal of dead code in the form of commented-out import statements.
>
>   If anyone has any insight on how to improve spotless beyond this, we
> should coordinate to minimize impact on the git log.  Also, I suspect we
> will want to coordinate these changes with a release cycle, for greater
> clarity in each individual file history.
>
>   What do you think?
>
> Imagination is Change.
> ~Patrick
>
> ---
> [1] https://cwiki.apache.org/confluence/display/GEODE/Code+Style+Guide
> [2] https://github.com/PurelyApplied/geode/blob/spotless/build.gradle
> [3] https://google.github.io/styleguide/javaguide.html#s4.8.7-modifiers
>
> ---
> Impact of corrections made by these changes to spotless, as rebased against
> 2017-08-23's commit 039edfc...
>
> -- 2,525 files with incorrect import ordering corrected.
> -- 115 pointless lines of commented-out import statements removed.
> -- 1,988 lines across 480 files with incorrect modifier ordering corrected
>

[DISCUSS] Updating Spotless

[Patrick Rhomberg]

[tl;dr:]
- We are inconsistent with our own established style rules.
- We should become not that.
- How do we coordinate becoming better?
- Do you have any other areas where we can become more spotless?

--
Hello, devs.

  There are a great many instances throughout the geode codebase that are
in direct contention with our documented style guide [1].  These strike me
as glaring broken windows, but thankfully fixing some of these issues is a
very low-hanging fruit (the mixing of metaphors notwithstanding).

  I've explored some updates to spotlessApply can that correct some of
these issues.  These changes can be seen on my repo, linked below ([2]).  I
have covered the following:
- adherence to the import ordering given in
/etc/eclipseOrganizeImports.importorder
- adherence to modifier ordering, as given in our adoption of the Google
Style Guide ([3])
- removal of dead code in the form of commented-out import statements.

  If anyone has any insight on how to improve spotless beyond this, we
should coordinate to minimize impact on the git log.  Also, I suspect we
will want to coordinate these changes with a release cycle, for greater
clarity in each individual file history.

  What do you think?

Imagination is Change.
~Patrick

---
[1] https://cwiki.apache.org/confluence/display/GEODE/Code+Style+Guide
[2] https://github.com/PurelyApplied/geode/blob/spotless/build.gradle
[3] https://google.github.io/styleguide/javaguide.html#s4.8.7-modifiers

---
Impact of corrections made by these changes to spotless, as rebased against
2017-08-23's commit 039edfc...

-- 2,525 files with incorrect import ordering corrected.
-- 115 pointless lines of commented-out import statements removed.
-- 1,988 lines across 480 files with incorrect modifier ordering corrected

[GitHub] geode pull request #737: GEODE-3503: Removal of Codec classes left behind.

[kohlmu-pivotal]

Github user kohlmu-pivotal commented on a diff in the pull request:

https://github.com/apache/geode/pull/737#discussion_r134895876
  
--- Diff: geode-protobuf/src/main/proto/region_API.proto ---
@@ -58,6 +58,7 @@ message GetAllRequest {
 
 message GetAllResponse {
 repeated Entry entries = 1;
+repeated KeyedErrorResponse failedKeys = 2;
--- End diff --

reverted


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #735: GEODE-3249 Document geode.allow-internal-messages-w...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/735


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #731: GEODE-2842: Removed redundant default annotation parameter...

[PurelyApplied]

Github user PurelyApplied commented on the issue:

https://github.com/apache/geode/pull/731
  
Precheckin green, with some flakiness observed in 
`org.apache.geode.internal.cache.ha.Bug48571DUnitTest`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #737: GEODE-3503: Removal of Codec classes left behind.

[galen-pivotal]

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/737
  
Looks like JSONCodecJUnitTest has multiple failures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #737: GEODE-3503: Removal of Codec classes left behind.

[WireBaron]

Github user WireBaron commented on a diff in the pull request:

https://github.com/apache/geode/pull/737#discussion_r134890133
  
--- Diff: geode-protobuf/src/main/proto/region_API.proto ---
@@ -58,6 +58,7 @@ message GetAllRequest {
 
 message GetAllResponse {
 repeated Entry entries = 1;
+repeated KeyedErrorResponse failedKeys = 2;
--- End diff --

This seems out of place in this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #649: GEODE-2997: Change new protocol GetAllResponse.

[galen-pivotal]

Github user galen-pivotal closed the pull request at:

https://github.com/apache/geode/pull/649


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #649: GEODE-2997: Change new protocol GetAllResponse.

[galen-pivotal]

Github user galen-pivotal commented on the issue:

https://github.com/apache/geode/pull/649
  
closing for #739 .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #656 was SUCCESSFUL (with 2027 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #656 was successful.
---
Scheduled
2029 tests in total.

https://build.spring.io/browse/SGF-NAG-656/





--
This message is automatically generated by Atlassian Bamboo

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

[PurelyApplied]

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/734#discussion_r134881817
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java
 ---
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
- * agreements. See the NOTICE file distributed with this work for 
additional information regarding
- * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the 
License. You may obtain a
- * copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software 
distributed under the License
- * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
- * or implied. See the License for the specific language governing 
permissions and limitations under
- * the License.
- */
-package org.apache.geode.internal.process;
-
-/**
- * Exception thrown during server startup when it requests the locators 
for shared configuration and
- * does not receive it.
- *
- * @since GemFire 8.0
- * @deprecated Please use
--- End diff --

Looks like `@deprecated` wants to be one, too.  Better use those backticks.

I definitely misread those annotations, yes.  I should get in the habit of 
checking the `git blame` to be sure about the deprecation date.

Other than the reason you mentioned -- possibly using it during a rolling 
upgrade -- is there a good reason to deprecate an internal class instead of 
simply removing it?  It was my understanding that internal packages didn't hold 
any promise of API stability.  Or could there be a backwards-compatibility 
issue that I'm not seeing?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #739: GEODE-3385: Change GetAllRequest to return list of ...

[galen-pivotal]

GitHub user galen-pivotal opened a pull request:

https://github.com/apache/geode/pull/739

GEODE-3385: Change GetAllRequest to return list of errors.

Also:
* Rename `KeyedErrorResponse` to `KeyedError`.
* move `ErrorResponse` to `clientProtocol.proto`.
* Check for null value in `ProtobufUtilities.createEntry`.
  If we find a null, we don't set the value; previously this resulted in
NPE.

Signed-off-by: Galen O'Sullivan 

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.

@WireBaron @bschuchardt @hiteshk25 @kohlmu-pivotal @pivotal-amurmann 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/galen-pivotal/geode feature/GEODE-3385

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/739.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #739


commit 78514a41718fb2682780bb949cf8ee4efb76224b
Author: Brian Rowe 
Date:   2017-08-23T21:53:06Z

GEODE-3385: Change GetAllRequest to return list of errors.

Also:
* Rename `KeyedErrorResponse` to `KeyedError`.
* move `ErrorResponse` to `clientProtocol.proto`.
* Check for null value in `ProtobufUtilities.createEntry`.
  If we find a null, we don't set the value; previously this resulted in
NPE.

Signed-off-by: Galen O'Sullivan 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #738: GEODE-3506: improve validation/error checking for p...

[kirklund]

GitHub user kirklund opened a pull request:

https://github.com/apache/geode/pull/738

GEODE-3506: improve validation/error checking for process file control

We only ever hit this failure once and I don't think it's a flaky test. 
This could actually be one more (last remaining?) root cause of "start locator" 
or "start server" hanging-while-printing-dots in GFSH. 

I've added what I consider to be excessive validation and error checking 
but it should point us at the cause if this check in FileProcessController ever 
fails again:

if (isBlank(lines)) {
  throw new IllegalStateException("Status file '" + statusFile + "' is 
blank");
}

In addition to this PR, we should consider adding more direct test coverage 
for ServiceState and its subclasses as well as more unit tests of the Launcher 
using mocks.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kirklund/geode 
GEODE-3506-FileProcessController

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/738.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #738


commit 8edd3f0e15406082bb568de975c631de2ae373d7
Author: Kirk Lund 
Date:   2017-08-23T21:20:18Z

GEODE-3506: improve validation and error handling of process file control




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

[kirklund]

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/734#discussion_r134875716
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java
 ---
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
- * agreements. See the NOTICE file distributed with this work for 
additional information regarding
- * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the 
License. You may obtain a
- * copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software 
distributed under the License
- * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
- * or implied. See the License for the specific language governing 
permissions and limitations under
- * the License.
- */
-package org.apache.geode.internal.process;
-
-/**
- * Exception thrown during server startup when it requests the locators 
for shared configuration and
- * does not receive it.
- *
- * @since GemFire 8.0
- * @deprecated Please use
--- End diff --

Oops, someone has a github name of "since" in mixed case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

[kirklund]

Github user kirklund commented on a diff in the pull request:

https://github.com/apache/geode/pull/734#discussion_r134875140
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/internal/process/ClusterConfigurationNotAvailableException.java
 ---
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
- * agreements. See the NOTICE file distributed with this work for 
additional information regarding
- * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the 
License. You may obtain a
- * copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software 
distributed under the License
- * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF 
ANY KIND, either express
- * or implied. See the License for the specific language governing 
permissions and limitations under
- * the License.
- */
-package org.apache.geode.internal.process;
-
-/**
- * Exception thrown during server startup when it requests the locators 
for shared configuration and
- * does not receive it.
- *
- * @since GemFire 8.0
- * @deprecated Please use
--- End diff --

It's probably ok to delete this, but I literally just deprecated this class 
a week or so ago. The only reason I kept it around was in case it's ever on the 
wire during a rolling upgrade -- I think it's very unlikely but I couldn't rule 
it out.

The @since is GemFire 8.0 (that's the version it was introduced in). I 
should have added @deprecated since Geode 1.3.0 which hasn't released yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134872863
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/MBeanJMXAdapter.java
 ---
@@ -72,16 +72,13 @@
   private DistributedMember distMember;
 
   /**
-   * log writer, or null if there is no distributed system available
-   */
-  // private LogWriterI18n logger = 
InternalDistributedSystem.getLoggerI18n();
-
-  /**
* public constructor
*/
 
+  public static final int VALUE_NOT_AVAILABLE = -1;
--- End diff --

Should this live in VMStatsMonitor since that's the only place it appears 
to be used?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134869226
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java
 ---
@@ -158,7 +156,7 @@
   private Thread runner;
   private boolean debugON;
   private Terminal terminal;
-  private boolean supressScriptCmdOutput;
+  private boolean suppressScriptCadOutput;
--- End diff --

This looks like a newly introduced typo :P


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134869699
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java 
---
@@ -212,8 +211,7 @@ public static void bytesToFiles(byte[][] fileData, 
String parentDirPath, boolean
   }
 
   public static boolean isValidFileName(String filePath, String extension) 
{
-boolean isValid = true;
-return isValid;
+return true;
--- End diff --

Can we just delete this method entirely?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134867453
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
 ---
@@ -415,9 +413,8 @@ public Result toCommandResult() {
   toCommandResult_isPut(section, table);
 } else if (isRemove()) {
   toCommandResult_isRemove(section, table);
-} else if (isSelect()) {
-  // its moved to its separate method
 }
+// isSelect() moved to a separate method
--- End diff --

Did you intended to leave this comment?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #737: GEODE-3503: Removal of Codec classes left behind.

[kohlmu-pivotal]

GitHub user kohlmu-pivotal opened a pull request:

https://github.com/apache/geode/pull/737

GEODE-3503: Removal of Codec classes left behind.

Added tests to test the remaining JSONCodec.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3503

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/737.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #737


commit a182a5a956d8a2e299fa3fb1307a79aa7c353e9e
Author: Udo Kohlmeyer 
Date:   2017-08-23T20:48:11Z

GEODE-3503: Removal of Codec classes left behind.
Added tests to test the remaining JSONCodec.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #736: GEODE-3503: Removal of Codec classes left behind.

[kohlmu-pivotal]

Github user kohlmu-pivotal closed the pull request at:

https://github.com/apache/geode/pull/736


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #736: GEODE-3503: Removal of Codec classes left behind.

[kohlmu-pivotal]

GitHub user kohlmu-pivotal opened a pull request:

https://github.com/apache/geode/pull/736

GEODE-3503: Removal of Codec classes left behind.

Added tests to test the remaining JSONCodec.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/geode feature/GEODE-3503

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/736.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #736


commit 6c807e8267b6ac6878e4b497d0b3d680ea496ef1
Author: Udo Kohlmeyer 
Date:   2017-08-23T20:48:11Z

GEODE-3503: Removal of Codec classes left behind.
Added tests to test the remaining JSONCodec.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61701/
---

(Updated Aug. 23, 2017, 8:43 p.m.)


Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, and 
Patrick Rhomberg.


Changes
---

Code cleanup
-remove trailing blanks
-remove unused imports


Repository: geode


Description
---

Updated tests for changes in the error constructors for ServerState and
LocatorState.

Minor spelling corrections.


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
 3a98373938e3de21da6badcf460dae3648218ac6 
  geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
83c1ab533e3dea323a8a99f7002b9464a54dfc25 
  geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
ae64691605130c9b212a3a33bb65ae37b28af02b 
  
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/GfshStatusCommandsIntegrationTest.java
 dd5841f4cffca38da07a11f381cf4174d7264349 
  
geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
 e7f17ef208a1708f385c7c4041affb70fd309a4c 


Diff: https://reviews.apache.org/r/61701/diff/4/

Changes: https://reviews.apache.org/r/61701/diff/3-4/


Testing
---

Precheckin from earlier ran green.

Re-running precheckin with this additional refactoring.


Thanks,

Ken Howe

[GitHub] geode pull request #735: GEODE-3249 Document geode.allow-internal-messages-w...

[karensmolermiller]

GitHub user karensmolermiller opened a pull request:

https://github.com/apache/geode/pull/735

GEODE-3249 Document geode.allow-internal-messages-without-credentials

@bschuchardt @metatype Please review documentation of the new property.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karensmolermiller/geode feature/GEODE-3249

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/735.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #735


commit 440dd6fbb7184acad7a4436f82e35b912155a24d
Author: Karen Miller 
Date:   2017-08-23T20:25:19Z

GEODE-3249 Document geode.allow-internal-messages-without-credentials




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 61860: GEODE-3510: GfshRule displays output from StdError

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61860/
---

Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and 
Patrick Rhomberg.


Repository: geode


Description
---

GEODE-3510: GfshRule displays output from StdError


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/test/dunit/rules/gfsh/ProcessLogger.java
 47f030471a988055400a71e5b564f3b24397c2e8 


Diff: https://reviews.apache.org/r/61860/diff/1/


Testing
---

Precheckin running


Thanks,

Jared Stewart

Re: Nightly build failures caused by attempted use of default ports

[Jared Stewart]

I think we just need to have AcceptanceTest (and possibly IntegrationTest) run 
inside Docker like DistributedTest already does.

- Jared.

> On Aug 23, 2017, at 11:32 AM, Anilkumar Gingade  wrote:
> 
>>> 1) use Docker for AcceptanceTest and IntegrationTest targets?
> To be clear, the failing tests are only in Acceptance Test and Integration
> Tests? And distributed tests are not seeing this issue as they are running
> in docker nowIf moving docker address this issue, my vote is for moving
> docker; this makes all the tests to be run in similar environment.
> 
>>> 2) not test default ports?
> If the product supports default port; we need to have test for that...Most
> of the early product evaluation is done with default port...
> 
> -Anil.
> 
> 
> On Wed, Aug 23, 2017 at 11:15 AM, Kirk Lund  wrote:
> 
>> The following nightly build failures are tests that are testing default
>> ports which are failing because the port is not available.
>> 
>> Should we:
>> 
>> 1) use Docker for AcceptanceTest and IntegrationTest targets?
>> 
>> 2) not test default ports?
>> 
>> 3) use a hacky System property to force Geode to think that some other port
>> is the default port?
>> 
>> 4) some other solution?
>> 
>> testGet – org.apache.geode.rest.internal.web.RestServersJUnitTest
>> a few seconds
>> testServerStartedOnDefaultPort –
>> org.apache.geode.rest.internal.web.RestServersJUnitTest
>> a few seconds
>> offlineStatusCommandShouldSucceedWhenConnected_server_dir –
>> org.apache.geode.management.internal.cli.shell.
>> GfshExitCodeStatusCommandsTest
>> a few seconds
>> offlineStatusCommandShouldSucceedWhenConnected_server_pid –
>> org.apache.geode.management.internal.cli.shell.
>> GfshExitCodeStatusCommandsTest
>> a few seconds
>> onlineStatusCommandShouldSucceedWhenConnected_locator_host_and_port –
>> org.apache.geode.management.internal.cli.shell.
>> GfshExitCodeStatusCommandsTest
>> a few seconds
>> offlineStatusCommandShouldSucceedEvenWhenNotConnected_server_dir –
>> org.apache.geode.management.internal.cli.shell.
>> GfshExitCodeStatusCommandsTest
>> a few seconds
>> offlineStatusCommandShouldSucceedEvenWhenNotConnected_server_pid –
>> org.apache.geode.management.internal.cli.shell.
>> GfshExitCodeStatusCommandsTest
>> a few seconds
>> onlineStatusCommandShouldSucceedWhenConnected_server_name –
>> org.apache.geode.management.internal.cli.shell.
>> GfshExitCodeStatusCommandsTest
>> a few seconds
>> offlineStatusCommandShouldSucceedWhenConnected_locator_dir –
>> org.apache.geode.management.internal.cli.shell.
>> GfshExitCodeStatusCommandsTest
>> a few seconds
>> offlineStatusCommandShouldSucceedWhenConnected_locator_pid –
>> org.apache.geode.management.internal.cli.shell.
>> GfshExitCodeStatusCommandsTest
>> a few seconds
>> onlineStatusCommandShouldSucceedWhenConnected_locator_name –
>> org.apache.geode.management.internal.cli.shell.
>> GfshExitCodeStatusCommandsTest
>> a few seconds
>> onlineStatusCommandShouldSucceedWhenConnected_locator_port –
>> org.apache.geode.management.internal.cli.shell.
>> GfshExitCodeStatusCommandsTest
>> a few seconds
>> statusLocatorSucceedsWhenConnected –
>> org.apache.geode.management.internal.cli.commands.
>> StatusLocatorRealGfshTest
>> 

[GitHub] geode pull request #722: GEODE-3184: Cleaned up Cargo tests

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/722


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Nightly build failures caused by attempted use of default ports

[Anilkumar Gingade]

>> 1) use Docker for AcceptanceTest and IntegrationTest targets?
To be clear, the failing tests are only in Acceptance Test and Integration
Tests? And distributed tests are not seeing this issue as they are running
in docker nowIf moving docker address this issue, my vote is for moving
docker; this makes all the tests to be run in similar environment.

>> 2) not test default ports?
If the product supports default port; we need to have test for that...Most
of the early product evaluation is done with default port...

-Anil.


On Wed, Aug 23, 2017 at 11:15 AM, Kirk Lund  wrote:

> The following nightly build failures are tests that are testing default
> ports which are failing because the port is not available.
>
> Should we:
>
> 1) use Docker for AcceptanceTest and IntegrationTest targets?
>
> 2) not test default ports?
>
> 3) use a hacky System property to force Geode to think that some other port
> is the default port?
>
> 4) some other solution?
>
> testGet – org.apache.geode.rest.internal.web.RestServersJUnitTest
> a few seconds
> testServerStartedOnDefaultPort –
> org.apache.geode.rest.internal.web.RestServersJUnitTest
> a few seconds
> offlineStatusCommandShouldSucceedWhenConnected_server_dir –
> org.apache.geode.management.internal.cli.shell.
> GfshExitCodeStatusCommandsTest
> a few seconds
> offlineStatusCommandShouldSucceedWhenConnected_server_pid –
> org.apache.geode.management.internal.cli.shell.
> GfshExitCodeStatusCommandsTest
> a few seconds
> onlineStatusCommandShouldSucceedWhenConnected_locator_host_and_port –
> org.apache.geode.management.internal.cli.shell.
> GfshExitCodeStatusCommandsTest
> a few seconds
> offlineStatusCommandShouldSucceedEvenWhenNotConnected_server_dir –
> org.apache.geode.management.internal.cli.shell.
> GfshExitCodeStatusCommandsTest
> a few seconds
> offlineStatusCommandShouldSucceedEvenWhenNotConnected_server_pid –
> org.apache.geode.management.internal.cli.shell.
> GfshExitCodeStatusCommandsTest
> a few seconds
> onlineStatusCommandShouldSucceedWhenConnected_server_name –
> org.apache.geode.management.internal.cli.shell.
> GfshExitCodeStatusCommandsTest
> a few seconds
> offlineStatusCommandShouldSucceedWhenConnected_locator_dir –
> org.apache.geode.management.internal.cli.shell.
> GfshExitCodeStatusCommandsTest
> a few seconds
> offlineStatusCommandShouldSucceedWhenConnected_locator_pid –
> org.apache.geode.management.internal.cli.shell.
> GfshExitCodeStatusCommandsTest
> a few seconds
> onlineStatusCommandShouldSucceedWhenConnected_locator_name –
> org.apache.geode.management.internal.cli.shell.
> GfshExitCodeStatusCommandsTest
> a few seconds
> onlineStatusCommandShouldSucceedWhenConnected_locator_port –
> org.apache.geode.management.internal.cli.shell.
> GfshExitCodeStatusCommandsTest
> a few seconds
> statusLocatorSucceedsWhenConnected –
> org.apache.geode.management.internal.cli.commands.
> StatusLocatorRealGfshTest
>

Nightly build failures caused by attempted use of default ports

[Kirk Lund]

The following nightly build failures are tests that are testing default
ports which are failing because the port is not available.

Should we:

1) use Docker for AcceptanceTest and IntegrationTest targets?

2) not test default ports?

3) use a hacky System property to force Geode to think that some other port
is the default port?

4) some other solution?

testGet – org.apache.geode.rest.internal.web.RestServersJUnitTest
a few seconds
testServerStartedOnDefaultPort –
org.apache.geode.rest.internal.web.RestServersJUnitTest
a few seconds
offlineStatusCommandShouldSucceedWhenConnected_server_dir –
org.apache.geode.management.internal.cli.shell.GfshExitCodeStatusCommandsTest
a few seconds
offlineStatusCommandShouldSucceedWhenConnected_server_pid –
org.apache.geode.management.internal.cli.shell.GfshExitCodeStatusCommandsTest
a few seconds
onlineStatusCommandShouldSucceedWhenConnected_locator_host_and_port –
org.apache.geode.management.internal.cli.shell.GfshExitCodeStatusCommandsTest
a few seconds
offlineStatusCommandShouldSucceedEvenWhenNotConnected_server_dir –
org.apache.geode.management.internal.cli.shell.GfshExitCodeStatusCommandsTest
a few seconds
offlineStatusCommandShouldSucceedEvenWhenNotConnected_server_pid –
org.apache.geode.management.internal.cli.shell.GfshExitCodeStatusCommandsTest
a few seconds
onlineStatusCommandShouldSucceedWhenConnected_server_name –
org.apache.geode.management.internal.cli.shell.GfshExitCodeStatusCommandsTest
a few seconds
offlineStatusCommandShouldSucceedWhenConnected_locator_dir –
org.apache.geode.management.internal.cli.shell.GfshExitCodeStatusCommandsTest
a few seconds
offlineStatusCommandShouldSucceedWhenConnected_locator_pid –
org.apache.geode.management.internal.cli.shell.GfshExitCodeStatusCommandsTest
a few seconds
onlineStatusCommandShouldSucceedWhenConnected_locator_name –
org.apache.geode.management.internal.cli.shell.GfshExitCodeStatusCommandsTest
a few seconds
onlineStatusCommandShouldSucceedWhenConnected_locator_port –
org.apache.geode.management.internal.cli.shell.GfshExitCodeStatusCommandsTest
a few seconds
statusLocatorSucceedsWhenConnected –
org.apache.geode.management.internal.cli.commands.StatusLocatorRealGfshTest

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61829/#review183634
---


Ship it!




Ship It!

- Hitesh Khamesra


On Aug. 22, 2017, 11:41 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61829/
> ---
> 
> (Updated Aug. 22, 2017, 11:41 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3408
> https://issues.apache.org/jira/browse/GEODE-3408
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Modified the message handler to catch EOFException and effect shutdown of the 
> connection & server thread.  I also fixed the handling of IOException.
> 
> The methods invoked are the same as for the old protocol's handling of 
> EOFException and IOException.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
>  cd1647a 
> 
> 
> Diff: https://reviews.apache.org/r/61829/diff/1/
> 
> 
> Testing
> ---
> 
> as this just affects logging behavior there are no new unit tests.  I 
> verified that the behavior is correct with the manual test used to reproduce 
> GEODE-3409 (my other review that is currently open).
> 
> precheckin is running now.
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Gradle Docker Plugin Fails After Upgrading Gradle To 3.5.1

[Kirk Lund]

+1 to upgrading both

On Wed, Aug 23, 2017 at 10:49 AM, Mark Bretl  wrote:

> Hi Everyone,
>
> In the last nightly builds, the builds are not running the distributed
> tests due to the Docker plugin not being compatible with Gradle 3.5.1. I
> didn't notice this in my testing because for 'precheckin' I do not use the
> Docker option. I do see the newest version of the Docker plugin should be
> compatible with Gradle 3.5+, however, it does look like there are other
> breaking changes which we would need to update. I created GEODE-3509 for
> this issue.
>
> My inclination is to keep the Gradle Wrapper update, revert the nightly
> build config, and work on the Docker plugin as a side issue since it is
> only a 'optional' feature at the moment.
>
> Would do people think?
>
> --Mark
>

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

[Bruce Schuchardt]

> On Aug. 23, 2017, 9:29 a.m., Hitesh Khamesra wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
> > Line 68 (original), 72 (patched)
> > 
> >
> > Will this warning be printed every time when we close the socket?
> 
> Bruce Schuchardt wrote:
> When the socket is closed we get a null message from Protobuf and 
> translate that into an EOFException

so, no we won't print this warning.  That's the purpose of this change & it is 
also what the old client interface does.


- Bruce


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61829/#review183616
---


On Aug. 22, 2017, 4:41 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61829/
> ---
> 
> (Updated Aug. 22, 2017, 4:41 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3408
> https://issues.apache.org/jira/browse/GEODE-3408
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Modified the message handler to catch EOFException and effect shutdown of the 
> connection & server thread.  I also fixed the handling of IOException.
> 
> The methods invoked are the same as for the old protocol's handling of 
> EOFException and IOException.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
>  cd1647a 
> 
> 
> Diff: https://reviews.apache.org/r/61829/diff/1/
> 
> 
> Testing
> ---
> 
> as this just affects logging behavior there are no new unit tests.  I 
> verified that the behavior is correct with the manual test used to reproduce 
> GEODE-3409 (my other review that is currently open).
> 
> precheckin is running now.
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/geode/pull/716


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

[Bruce Schuchardt]

> On Aug. 23, 2017, 9:29 a.m., Hitesh Khamesra wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
> > Line 68 (original), 72 (patched)
> > 
> >
> > Will this warning be printed every time when we close the socket?

When the socket is closed we get a null message from Protobuf and translate 
that into an EOFException


- Bruce


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61829/#review183616
---


On Aug. 22, 2017, 4:41 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61829/
> ---
> 
> (Updated Aug. 22, 2017, 4:41 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3408
> https://issues.apache.org/jira/browse/GEODE-3408
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Modified the message handler to catch EOFException and effect shutdown of the 
> connection & server thread.  I also fixed the handling of IOException.
> 
> The methods invoked are the same as for the old protocol's handling of 
> EOFException and IOException.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
>  cd1647a 
> 
> 
> Diff: https://reviews.apache.org/r/61829/diff/1/
> 
> 
> Testing
> ---
> 
> as this just affects logging behavior there are no new unit tests.  I 
> verified that the behavior is correct with the manual test used to reproduce 
> GEODE-3409 (my other review that is currently open).
> 
> precheckin is running now.
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[GitHub] geode pull request #734: GEODE-3508: Remove unused internal deprecated class...

[PurelyApplied]

GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/734

GEODE-3508: Remove unused internal deprecated classes.

* Update ClusterConfigurationNotAvailableException to extend Exception 
directly, rather than the deprecated class.

--

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [n/a] Have you written or updated unit tests to verify your changes?

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-3508

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/734.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #734


commit 86e6daf53fa1660ea4744415a3d9f613f4b5a3f5
Author: Patrick Rhomberg 
Date:   2017-08-23T17:49:32Z

GEODE-3508: Remove three unused internal deprecated classes.

* Update ClusterConfigurationNotAvailableException to extend Exception 
directly, rather than the deprecated class.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Gradle Docker Plugin Fails After Upgrading Gradle To 3.5.1

[Mark Bretl]

Hi Everyone,

In the last nightly builds, the builds are not running the distributed
tests due to the Docker plugin not being compatible with Gradle 3.5.1. I
didn't notice this in my testing because for 'precheckin' I do not use the
Docker option. I do see the newest version of the Docker plugin should be
compatible with Gradle 3.5+, however, it does look like there are other
breaking changes which we would need to update. I created GEODE-3509 for
this issue.

My inclination is to keep the Gradle Wrapper update, revert the nightly
build config, and work on the Docker plugin as a side issue since it is
only a 'optional' feature at the moment.

Would do people think?

--Mark

[GitHub] geode issue #733: Keeping old versions around even during a clean

[upthewaterspout]

Github user upthewaterspout commented on the issue:

https://github.com/apache/geode/pull/733
  
> Would it be possible to include old versions as dependencies?

Yeah, that's what I would really like to do, actually. The problem is that 
gradle doesn't make it easy to cache an arbitrary url, only something that is 
published as part of a maven/ivy repo. I tried using this hack to pretend that 
a url was an ivy repo, but it doesn't seem to work for me - 
https://stackoverflow.com/a/34327202. I can try messing around with a bit more 
though. Or maybe we could publish geode 1.2.0 as a maven dependency?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61852: GEODE-3507 actualRedundantCopies stat in org.apache.geode.internal.cache.PartitionedRegionStats can go negative

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61852/#review183626
---


Ship it!




Ship It!

- Darrel Schneider


On Aug. 23, 2017, 9:55 a.m., Lynn Gallinat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61852/
> ---
> 
> (Updated Aug. 23, 2017, 9:55 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, and 
> Nick Reich.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The PartitionedRegionRedundancyTracker class can still hold a -1 to do it's 
> work, but will now not allow -1 to be written to stats
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTracker.java
>  38ef61b 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTrackerTest.java
>  0917835 
> 
> 
> Diff: https://reviews.apache.org/r/61852/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin (all green)
> I repeatedly ran one of the tests that reproduced this problem and it passed 
> 370 times.
> I ran selected partitioned region bts (totaling 536 PR tests) and the only 
> failures were auto-diagnosed.
> 
> 
> Thanks,
> 
> Lynn Gallinat
> 
>

Re: Review Request 61852: GEODE-3507 actualRedundantCopies stat in org.apache.geode.internal.cache.PartitionedRegionStats can go negative

[Eric Shu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61852/#review183627
---


Ship it!




Ship It!

- Eric Shu


On Aug. 23, 2017, 4:55 p.m., Lynn Gallinat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61852/
> ---
> 
> (Updated Aug. 23, 2017, 4:55 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, and 
> Nick Reich.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> The PartitionedRegionRedundancyTracker class can still hold a -1 to do it's 
> work, but will now not allow -1 to be written to stats
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTracker.java
>  38ef61b 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTrackerTest.java
>  0917835 
> 
> 
> Diff: https://reviews.apache.org/r/61852/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin (all green)
> I repeatedly ran one of the tests that reproduced this problem and it passed 
> 370 times.
> I ran selected partitioned region bts (totaling 536 PR tests) and the only 
> failures were auto-diagnosed.
> 
> 
> Thanks,
> 
> Lynn Gallinat
> 
>

[GitHub] geode issue #733: Keeping old versions around even during a clean

[scmbuildguy]

Github user scmbuildguy commented on the issue:

https://github.com/apache/geode/pull/733
  
I am hesitant about this change since it doesn't follow the Gradle workflow 
very well.

Would it be possible to include old versions as dependencies? Maybe then we 
could leverage Gradle Cache instead of managing it ourselves.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #733: Keeping old versions around even during a clean

[metatype]

Github user metatype commented on the issue:

https://github.com/apache/geode/pull/733
  
Um, should we add a `reallyClean` task to scrub this dir?  What about users 
of `-PbuildRoot`?

I'm inclined towards keeping temporary build files in `build`.  But IMO...

+0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61701: GEODE-3277: Fix error path constructors of Launcher inner State classess

[Patrick Rhomberg]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61701/#review183621
---




geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java
Lines 2014-2028 (original), 2013-2027 (patched)


Is there a concensus on whether this style of parameter labeling is good or 
if we should remove it?  I personally don't like it, especially since IntelliJ 
fills in the labels for you when you enter a raw value instead of passing a 
parameter.



geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/GfshStatusCommandsIntegrationTest.java
Lines 19-37 (original), 19-39 (patched)


Hat trick for my nit-picks.

* There are a couple unused imports (`InetAddress` and `ClassRule`).
* `final private static` is preferred to be `private static final`.  
(There's an IntelliJ inspection for this that is off by default.)
* That `// private int port` could be removed, along with the `// port = 
getRandomAvailablePort(SOCKET);` below



geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
Lines 47-52 (original), 47-52 (patched)


A man after my own heart.


- Patrick Rhomberg


On Aug. 22, 2017, 9:28 p.m., Ken Howe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61701/
> ---
> 
> (Updated Aug. 22, 2017, 9:28 p.m.)
> 
> 
> Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Kirk Lund, 
> and Patrick Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Updated tests for changes in the error constructors for ServerState and
> LocatorState.
> 
> Minor spelling corrections.
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/StatusLocatorRealGfshTest.java
>  3a98373938e3de21da6badcf460dae3648218ac6 
>   geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java 
> 83c1ab533e3dea323a8a99f7002b9464a54dfc25 
>   geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
> ae64691605130c9b212a3a33bb65ae37b28af02b 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/lifecycle/GfshStatusCommandsIntegrationTest.java
>  dd5841f4cffca38da07a11f381cf4174d7264349 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java
>  e7f17ef208a1708f385c7c4041affb70fd309a4c 
> 
> 
> Diff: https://reviews.apache.org/r/61701/diff/3/
> 
> 
> Testing
> ---
> 
> Precheckin from earlier ran green.
> 
> Re-running precheckin with this additional refactoring.
> 
> 
> Thanks,
> 
> Ken Howe
> 
>

Review Request 61852: GEODE-3507 actualRedundantCopies stat in org.apache.geode.internal.cache.PartitionedRegionStats can go negative

[Lynn Gallinat]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61852/
---

Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, and 
Nick Reich.


Repository: geode


Description
---

The PartitionedRegionRedundancyTracker class can still hold a -1 to do it's 
work, but will now not allow -1 to be written to stats


Diffs
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTracker.java
 38ef61b 
  
geode-core/src/test/java/org/apache/geode/internal/cache/PartitionedRegionRedundancyTrackerTest.java
 0917835 


Diff: https://reviews.apache.org/r/61852/diff/1/


Testing
---

Precheckin (all green)
I repeatedly ran one of the tests that reproduced this problem and it passed 
370 times.
I ran selected partitioned region bts (totaling 536 PR tests) and the only 
failures were auto-diagnosed.


Thanks,

Lynn Gallinat

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

[Udo Kohlmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61829/#review183620
---


Ship it!




Ship It!

- Udo Kohlmeyer


On Aug. 22, 2017, 11:41 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61829/
> ---
> 
> (Updated Aug. 22, 2017, 11:41 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3408
> https://issues.apache.org/jira/browse/GEODE-3408
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Modified the message handler to catch EOFException and effect shutdown of the 
> connection & server thread.  I also fixed the handling of IOException.
> 
> The methods invoked are the same as for the old protocol's handling of 
> EOFException and IOException.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
>  cd1647a 
> 
> 
> Diff: https://reviews.apache.org/r/61829/diff/1/
> 
> 
> Testing
> ---
> 
> as this just affects logging behavior there are no new unit tests.  I 
> verified that the behavior is correct with the manual test used to reproduce 
> GEODE-3409 (my other review that is currently open).
> 
> precheckin is running now.
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[pdxrunner]

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134804772
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
 ---
@@ -147,11 +147,10 @@ public ResultData addAsFile(String fileName, String 
fileContents, String message
 
   public ResultData addAsFile(String fileName, byte[] data, int fileType, 
String message,
   boolean addTimeStampToName) {
-byte[] bytes = data;
--- End diff --

I stand corrected. I confused myself with past experiences with other 
languages.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61816: GEODE-3409 Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even After Connections Closed

[Brian Rowe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61816/#review183617
---


Ship it!




Ship It!

- Brian Rowe


On Aug. 23, 2017, 3:47 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61816/
> ---
> 
> (Updated Aug. 23, 2017, 3:47 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3409
> https://issues.apache.org/jira/browse/GEODE-3409
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> ServerConnection cleanup was not decrementing the Acceptor's client 
> connection count when the protobuf communications mode was in effect.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
>  35cc33f3fa5547a01368a3ae3b6ad401b858610d 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
>  394d2614c0d04353c95454c8730e84688e4766fe 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  12cc08b2f6cac77dcc2b79f1d3245f0960c3e8ba 
> 
> 
> Diff: https://reviews.apache.org/r/61816/diff/2/
> 
> 
> Testing
> ---
> 
> new integration test
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

Re: Review Request 61829: GEODE-3408 Flood of EOF warnings

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61829/#review183616
---




geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
Line 68 (original), 72 (patched)


Will this warning be printed every time when we close the socket?


- Hitesh Khamesra


On Aug. 22, 2017, 11:41 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61829/
> ---
> 
> (Updated Aug. 22, 2017, 11:41 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3408
> https://issues.apache.org/jira/browse/GEODE-3408
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Modified the message handler to catch EOFException and effect shutdown of the 
> connection & server thread.  I also fixed the handling of IOException.
> 
> The methods invoked are the same as for the old protocol's handling of 
> EOFException and IOException.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/GenericProtocolServerConnection.java
>  cd1647a 
> 
> 
> Diff: https://reviews.apache.org/r/61829/diff/1/
> 
> 
> Testing
> ---
> 
> as this just affects logging behavior there are no new unit tests.  I 
> verified that the behavior is correct with the manual test used to reproduce 
> GEODE-3409 (my other review that is currently open).
> 
> precheckin is running now.
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[GitHub] geode pull request #733: Keeping old versions around even during a clean

[upthewaterspout]

GitHub user upthewaterspout opened a pull request:

https://github.com/apache/geode/pull/733

Keeping old versions around even during a clean

Putting old versions of geode in a separate directory so they are not
removed during a clean.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.

@jhuynh1 @kohlmu-pivotal 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/upthewaterspout/incubator-geode 
feature/download-outside-build

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/733.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #733


commit 4f72450533018162636f2b003c7e9900219036f3
Author: Dan Smith 
Date:   2017-08-22T20:53:16Z

Keeping old versions around even during a clean

Putting old versions of geode in a separate directory so they are not
removed during a clean.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61816: GEODE-3409 Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even After Connections Closed

[Hitesh Khamesra]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61816/#review183615
---


Ship it!




Ship It!

- Hitesh Khamesra


On Aug. 23, 2017, 3:47 p.m., Bruce Schuchardt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61816/
> ---
> 
> (Updated Aug. 23, 2017, 3:47 p.m.)
> 
> 
> Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh 
> Khamesra, Udo Kohlmeyer, and Brian Rowe.
> 
> 
> Bugs: GEODE-3409
> https://issues.apache.org/jira/browse/GEODE-3409
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> ServerConnection cleanup was not decrementing the Acceptor's client 
> connection count when the protobuf communications mode was in effect.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
>  35cc33f3fa5547a01368a3ae3b6ad401b858610d 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
>  394d2614c0d04353c95454c8730e84688e4766fe 
>   
> geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
>  12cc08b2f6cac77dcc2b79f1d3245f0960c3e8ba 
> 
> 
> Diff: https://reviews.apache.org/r/61816/diff/2/
> 
> 
> Testing
> ---
> 
> new integration test
> 
> 
> Thanks,
> 
> Bruce Schuchardt
> 
>

[GitHub] geode issue #719: GEODE-3447 Implement client authorization for the new prot...

[bschuchardt]

Github user bschuchardt commented on the issue:

https://github.com/apache/geode/pull/719
  
GetAvailableServers will be executed on a Locator which installs a no-op 
authorizer in the execution "context".  That can change if we decide later on 
that we want to perform authentication and authorization on locator requests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 61816: GEODE-3409 Protobuf Client Can't Connect Once Connection Limit Has Been Reached, Even After Connections Closed

[Bruce Schuchardt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61816/
---

(Updated Aug. 23, 2017, 8:47 a.m.)


Review request for geode, Alexander Murmann, Galen O'Sullivan, Hitesh Khamesra, 
Udo Kohlmeyer, and Brian Rowe.


Changes
---

fixed a race condition in the new test.  The setup method connects a socket to 
the server so the initial connection count ought to be 1 but often was zero.  
When it was 1 the incorrect assertions in the new test would fail.


Bugs: GEODE-3409
https://issues.apache.org/jira/browse/GEODE-3409


Repository: geode


Description
---

ServerConnection cleanup was not decrementing the Acceptor's client connection 
count when the protobuf communications mode was in effect.


Diffs (updated)
-

  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientHealthMonitor.java
 35cc33f3fa5547a01368a3ae3b6ad401b858610d 
  
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
 394d2614c0d04353c95454c8730e84688e4766fe 
  
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
 12cc08b2f6cac77dcc2b79f1d3245f0960c3e8ba 


Diff: https://reviews.apache.org/r/61816/diff/2/

Changes: https://reviews.apache.org/r/61816/diff/1-2/


Testing
---

new integration test


Thanks,

Bruce Schuchardt

Build failed in Jenkins: Geode-nightly-flaky #100

[Apache Jenkins Server]

See 


Changes:

[jstewart] GEODE-3306: Remove whitespace StringBuffers/nodes created by Apache

[ukohlmeyer] GEODE-3416: Reduce synchronization blockages in SocketCloser. This 
now

[hkhamesra] GEODE-3406: Locator accepts Protobuf requests

[hkhamesra] GEODE-3406: Address PR feedback

[hkhamesra] GEODE-3406: Exclude new exception class from analyze serialiable 
test

[hkhamesra] GEODE-3406: Address more PR feedback

[hkhamesra] GEODE-3406: Fixed test failures.

[jstewart] GEODE-3445: Add gfsh connect option --skip-ssl-validation

[dbarnes] GEODE-3395 Variable-ize product version and name in user guide - Topo 
&

[Anil] GEODE-3047 Atomic creation flag is not set if the region is recoverd

[dbarnes] GEODE-3395 Variable-ize product version and name in user guide - Topo 
&

[dbarnes] GEODE-3504: Add Experimental caveat for Redis and Auto-rebalance

[klund] GEODE-3335: add FlakyTest category to testNavigationAPIS

[klund] GEODE-2859: minor cleanup

[klund] GEODE-3164: fix flakiness with await

[klund] GEODE-3461: increase test timeouts

--
[...truncated 103.62 KB...]
Download 
https://repo1.maven.org/maven2/io/swagger/swagger-models/1.5.10/swagger-models-1.5.10.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spi/2.6.1/springfox-spi-2.6.1.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-schema/2.6.1/springfox-schema-2.6.1.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-common/2.6.1/springfox-swagger-common-2.6.1.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spring-web/2.6.1/springfox-spring-web-2.6.1.pom
Download 
https://repo1.maven.org/maven2/com/fasterxml/classmate/1.3.1/classmate-1.3.1.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-core/1.2.0.RELEASE/spring-plugin-core-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin/1.2.0.RELEASE/spring-plugin-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-metadata/1.2.0.RELEASE/spring-plugin-metadata-1.2.0.RELEASE.pom
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct/1.0.0.Final/mapstruct-1.0.0.Final.pom
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct-parent/1.0.0.Final/mapstruct-parent-1.0.0.Final.pom
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-core/2.6.1/springfox-core-2.6.1.pom
Download 
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-scala_2.10/2.8.6/jackson-module-scala_2.10-2.8.6.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger2/2.6.1/springfox-swagger2-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-ui/2.6.1/springfox-swagger-ui-2.6.1.jar
Download 
https://repo1.maven.org/maven2/org/springframework/hateoas/spring-hateoas/0.23.0.RELEASE/spring-hateoas-0.23.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/com/fasterxml/jackson/module/jackson-module-paranamer/2.8.6/jackson-module-paranamer-2.8.6.jar
Download 
https://repo1.maven.org/maven2/io/swagger/swagger-annotations/1.5.10/swagger-annotations-1.5.10.jar
Download 
https://repo1.maven.org/maven2/io/swagger/swagger-models/1.5.10/swagger-models-1.5.10.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spi/2.6.1/springfox-spi-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-schema/2.6.1/springfox-schema-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-swagger-common/2.6.1/springfox-swagger-common-2.6.1.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-spring-web/2.6.1/springfox-spring-web-2.6.1.jar
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-core/1.2.0.RELEASE/spring-plugin-core-1.2.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/springframework/plugin/spring-plugin-metadata/1.2.0.RELEASE/spring-plugin-metadata-1.2.0.RELEASE.jar
Download 
https://repo1.maven.org/maven2/org/mapstruct/mapstruct/1.0.0.Final/mapstruct-1.0.0.Final.jar
Download 
https://repo1.maven.org/maven2/com/thoughtworks/paranamer/paranamer/2.8/paranamer-2.8.jar
Download 
https://repo1.maven.org/maven2/io/springfox/springfox-core/2.6.1/springfox-core-2.6.1.jar
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:geode-web-api:processResources
:geode-web-api:classes
:geode-assembly:docs
:geode-assembly:gfshDepsJar
:geode-common:javadocJar
:geode-common:sourcesJar
:geode-common:signArchives SKIPPED
:geode-core:javadocJar
:geode-core:raJar
:geode-core:jcaJar
:geode-core:sourcesJar
:geode-core:signArchives SKIPPED
:geode-core:webJar
:geode-cq:jar
:geode-cq:javadoc
:geode-cq:javadocJar
:geode-cq:sourcesJar
:geode-cq:signArchives SKIPPED
:geode-json:javadocJar

Build failed in Jenkins: Geode-nightly #932

[Apache Jenkins Server]

See 


Changes:

[jstewart] GEODE-3306: Remove whitespace StringBuffers/nodes created by Apache

[ukohlmeyer] GEODE-3416: Reduce synchronization blockages in SocketCloser. This 
now

[hkhamesra] GEODE-3406: Locator accepts Protobuf requests

[hkhamesra] GEODE-3406: Address PR feedback

[hkhamesra] GEODE-3406: Exclude new exception class from analyze serialiable 
test

[hkhamesra] GEODE-3406: Address more PR feedback

[hkhamesra] GEODE-3406: Fixed test failures.

[jstewart] GEODE-3445: Add gfsh connect option --skip-ssl-validation

[dbarnes] GEODE-3395 Variable-ize product version and name in user guide - Topo 
&

[Anil] GEODE-3047 Atomic creation flag is not set if the region is recoverd

[dbarnes] GEODE-3395 Variable-ize product version and name in user guide - Topo 
&

[dbarnes] GEODE-3504: Add Experimental caveat for Redis and Auto-rebalance

[klund] GEODE-3335: add FlakyTest category to testNavigationAPIS

[klund] GEODE-2859: minor cleanup

[klund] GEODE-3164: fix flakiness with await

[klund] GEODE-3461: increase test timeouts

--
[...truncated 199.33 KB...]

18: Task failed with an exception.
---
* What went wrong:
Execution failed for task ':geode-web:distributedTest'.
> Could not find matching constructor for: 
> org.gradle.process.internal.worker.DefaultWorkerProcessFactory(org.gradle.api.logging.LogLevel,
>  com.pedjak.gradle.plugins.dockerizedtest.DockerizedTestPlugin$MessageServer, 
> org.gradle.api.internal.DefaultClassPathRegistry, 
> org.gradle.internal.id.LongIdGenerator, java.io.File, 
> org.gradle.api.internal.file.TmpDirTemporaryFileProvider, 
> com.sun.proxy.$Proxy84)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

19: Task failed with an exception.
---
* What went wrong:
Execution failed for task ':geode-web-api:distributedTest'.
> Could not find matching constructor for: 
> org.gradle.process.internal.worker.DefaultWorkerProcessFactory(org.gradle.api.logging.LogLevel,
>  com.pedjak.gradle.plugins.dockerizedtest.DockerizedTestPlugin$MessageServer, 
> org.gradle.api.internal.DefaultClassPathRegistry, 
> org.gradle.internal.id.LongIdGenerator, java.io.File, 
> org.gradle.api.internal.file.TmpDirTemporaryFileProvider, 
> com.sun.proxy.$Proxy84)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

20: Task failed with an exception.
---
* Where:
Script ' 
line: 116

* What went wrong:
Execution failed for task ':extensions/geode-modules-assembly:uploadArchives'.
> Could not find which method repositories() to invoke from this list:
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(groovy.lang.Closure)
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(org.gradle.api.Action)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

21: Task failed with an exception.
---
* Where:
Script ' 
line: 116

* What went wrong:
Execution failed for task ':geode-common:uploadArchives'.
> Could not find which method repositories() to invoke from this list:
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(groovy.lang.Closure)
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(org.gradle.api.Action)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

22: Task failed with an exception.
---
* Where:
Script ' 
line: 116

* What went wrong:
Execution failed for task ':geode-core:uploadArchives'.
> Could not find which method repositories() to invoke from this list:
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(groovy.lang.Closure)
public org.gradle.api.artifacts.dsl.RepositoryHandler 
org.gradle.api.tasks.Upload#repositories(org.gradle.api.Action)

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output.
==

23: Task failed with an exception.
---
* Where:
Script