RE: [DISCUSS] Bug while parsing the JSON "key which having short data type" in locate command "https://github.com/apache/geode/pull/752"

2017-09-12 Thread Dinesh Akhand
Hi Team, I fixed the first review code comments. Please review again. Thanks, Dinesh Akhand -Original Message- From: dinesh 1004 [mailto:dineshpune2...@gmail.com] Sent: Wednesday, September 6, 2017 10:23 PM To: dev@geode.apache.org Subject: RE: [DISCUSS] Bug while parsing the JSON "key

Re: 1.3.0 release

2017-09-12 Thread Swapnil Bawaskar
Sound good. I would like to volunteer to be the release manager. Thanks! On Tue, Sep 12, 2017 at 2:24 PM Anthony Baker wrote: > Hi all, > > I think we should begin discussing scope and timeline for the 1.3.0 > release. I know we’re still finalizing 1.2.1, but we released

1.3.0 release

2017-09-12 Thread Anthony Baker
Hi all, I think we should begin discussing scope and timeline for the 1.3.0 release. I know we’re still finalizing 1.2.1, but we released 1.2.0 almost two months ago and we’ve fixed almost 200 issues in that time. IMO, we should complete 1.2.1 and then immediately turn around 1.3.0.

Re: How to setup 2-phase auth for Github

2017-09-12 Thread Kirk Lund
Thanks Dave! I have the Github 2-phase auth working with GA now. Here's the URL in case anyone else ends up looking for it... https://help.github.com/articles/configuring-two-factor-authentication-via-a-totp-mobile-app/ Thanks, Kirk On Tue, Sep 12, 2017 at 11:06 AM, Dave Barnes

Re: [Discuss] Investigation of C++ object return types

2017-09-12 Thread Jacob Barrett
My biggest concern with this model is that access to the public Cache object from other public objects results in additional allocations of a Cache value. Think about when we are inside a Serializable object and we access the Cache from DataOutput. As value: Serializable*

Re: How to setup 2-phase auth for Github

2017-09-12 Thread Dave Barnes
It's kind of buried under the "TOTP Mobile App" heading. You connect Google Authenticator to Github when you shoot a photo of the code square. On Tue, Sep 12, 2017 at 10:58 AM, Kirk Lund wrote: > I'm trying to get setup for gitbox, but a couple details are not panning > out

How to setup 2-phase auth for Github

2017-09-12 Thread Kirk Lund
I'm trying to get setup for gitbox, but a couple details are not panning out correctly for me. Darrel is using Google Authenticator on iphone for 2-phase auth of Github. However, the URL that gives directions for setting up 2-phase auth of Github does NOT have a section for setting up Google

Re: [Discuss] Building objects with the Factory pattern or the Builder pattern. Adding the fluent model?

2017-09-12 Thread Kirk Lund
I don't think we currently have any design directions or architectural rules for Geode documented yet other than for GFSH. As we refactor code, we really should be following some sort of overall design guidelines. +1 for documenting (on the wiki) and promoting fluent style APIs in our design

Re: [DISCUSS] Clean build takes 10minutes to complete now

2017-09-12 Thread Udo Kohlmeyer
My apologies, I might gotten the commit reason incorrect. I just know that downloading the older product version every time is becoming painful. Yes, sometimes it is faster than other times, but imo, this is not something that should be part of the main build path. Backwards compat or integration

Re: [DISCUSS] Clean build takes 10minutes to complete now

2017-09-12 Thread Nabarun Nag
As we are working on fixing this issue, some extra parameters may help the build to get bit quicker on your machine. using -xjavadoc -xdoc Eg: ./gradlew clean build -Dskip.tests=true -xjavadoc -xdocs BUILD SUCCESSFUL Total time: 2 mins 2.729 secs Also, I think as Jason mentioned that the slow

Build failed in Jenkins: Geode-nightly-flaky #121

2017-09-12 Thread Apache Jenkins Server
See Changes: [jdeppe] GEODE-3586: Fix syntax in uploadArchives task (since gradle 3.5) [dcavender] GEODE-3587: Enable publishing distribution zip [jiliao] GEODE-2817: consolidate authorize(*) methods

Re: [DISCUSS] Clean build takes 10minutes to complete now

2017-09-12 Thread Alexander Murmann
Could we make it so that these tests for now are only run as part of pre-checkin till we got this ironed out and then revisit this? On Tue, Sep 12, 2017 at 8:32 AM, Bruce Schuchardt wrote: > The geode-old-versions module was originally created to pull in old > version

Re: [DISCUSS] Clean build takes 10minutes to complete now

2017-09-12 Thread Bruce Schuchardt
The geode-old-versions module was originally created to pull in old version jar files into your gradle cache.  This happened only once and you were good to go.  I don't think that part should be backed out as it has minimal impact and is not affecting build time. The recent changes for lucene

Review Request 62248: GEODE-3539: Add test for missing coverage of status locator command

2017-09-12 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62248/ --- Review request for geode, Jinmei Liao, Jared Stewart, and Patrick Rhomberg.

[Discuss] Investigation of C++ object return types

2017-09-12 Thread David Kimura
Follow up of attached discussion after more investigation. I created an example of returning Cache as shared pointer versus raw value: https://github.com/dgkimura/geode-native-sandbox I still like returning by value as it lets the user do what they want with their object. // Here user

Build failed in Jenkins: Geode-nightly #952

2017-09-12 Thread Apache Jenkins Server
See Changes: [jdeppe] GEODE-3586: Fix syntax in uploadArchives task (since gradle 3.5) [dcavender] GEODE-3587: Enable publishing distribution zip [jiliao] GEODE-2817: consolidate authorize(*) methods [jiliao]