Re: build problem in new module

Bruce, the message is just informational as this is the first time the upload is happening for this module. It was successful: https://repository.apache.org/content/repositories/snapshots/org/apache/geode/geode-old-versions/ --Jens On Wed, Jan 25, 2017 at 8:22 AM, Bruce Schuchardt

Re: [ANNOUNCE] Donation of improved GemFire native client

I agree with Jake - I don't think having a single build process really serves either side well. In all my time using GemFire/Geode I've never once had a need to build (or even use) the Native Client component. Given that the majority of users/developers will be only Java focused, I don't think

Unable to post to reviewboard

I'm having trouble posting to reviewboard and am getting this error (debug output): ± jd+am |feature/GEODE-2201 ✗| → rbt post -d --repository geode --tracking-branch=origin/develop --target-groups=geode --server https://reviews.apache.org >>> RBTools 0.7.5 >>> Python 2.6.9 (unknown, Jul 30 2016,

Re: Debugging JUnit / DUnit tests

DUnits are automatically run with debugging options on. This means that each VM started (5 usually, I think - 1 locator and 4 servers) ends up with a unique ephemeral debug port. Use the options that Kevin pointed out to set the debug port. You can just launch your DUnits from IntelliJ too

Re: Visualize Geode Metrics/Stats with Grafana Dashboards

This is fantastic work! I did something with the same components for a hackday last year and it looked very promising - it's great to see it fully realized here. Although it's not difficult pulling the components together, it would be awesome to provide a turnkey (ala docker) solution that Just

Re: copy files to servers

Got to chime in here and +1 on what Anthony's and Jake's sentiments are. Let's be *very* careful and try to understand what users are trying to achieve. If we're providing a 'gfsh cp' option that then requires further intervention to actually achieve what the user wants (i.e. server restart or

Re: Review Request 55109: GEODE-1657 Remove silly ^M characters

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55109/#review160341 --- Probably want to keep these for `gfsh.bat`. - Jens Deppe

Review Request 54964: GEODE-2243: reference the formatter relative to geode-core and not the root project

://reviews.apache.org/r/54964/diff/ Testing --- Build under various root directory structures Thanks, Jens Deppe

Re: CacheServer and fake in-process client

Would it be viable to consider using the REST API for this? --Jens On Mon, Apr 3, 2017 at 2:31 PM, Kirk Lund wrote: > Has anyone written a test where they use a single JVM in which they start a > server Cache and then fake up a connection from a non-existent client to > feed

Re: Orphaned Server processes

Also, don't forget that you can start a server in a 'wait for locator' mode (I forget the actual option) which should be distinguished from an actual 'orphaned' instance. --Jens On Wed, Apr 5, 2017 at 3:54 PM, Michael Stolz wrote: > I think the current behavior is probably

Re: Refactor gfsh parser

IMO I much prefer having: --member=member1,member2 vs: --member=member1 --member=member2 The latter can leave me wondering if subsequent values are additive or actually override prior ones. --Jens On Thu, Apr 20, 2017 at 1:37 PM, Jinmei Liao wrote: > In the effort of

Re: Simple Java Client

I would suggest working closely with John Blum on this as I believe he already provides similar functionality in Spring Data Geode. Also, would this be the beginning of a client-side admin API with the intention of fleshing that out completely in the future? --Jens On Mon, Apr 24, 2017 at 3:03

Re: Build failed in Jenkins: Geode-nightly #923

I'm working on enabling parallel dunits in docker to work on Jenkins. If this can happen it should help with some of these problems. However, it requires fairly beefy systems to run well, otherwise you end up with other issues around resource starvation. At worst we could just run with a

Re: Request for Jenkins config ability

Thanks Mark - I'll test it out tomorrow. On Thu, Aug 10, 2017 at 3:42 PM, Mark Bretl <mbr...@apache.org> wrote: > Hi Jens, > > Skillz have been given. > > Let me know if you have any issues, > > --Mark > > On Thu, Aug 10, 2017 at 10:46 AM, Jens Deppe <j

Review Request 61562: GEODE-3423: Provide support for running parallel docker builds in Jenkins

diff/1/ Testing --- Thanks, Jens Deppe

Re: Review Request 61562: GEODE-3423: Provide support for running parallel docker builds in Jenkins

gradle 79719740bc85fd1939d2d7859a7c78c0a87dd26e Diff: https://reviews.apache.org/r/61562/diff/2/ Changes: https://reviews.apache.org/r/61562/diff/1-2/ Testing --- Thanks, Jens Deppe

Request for Jenkins config ability

Hi, I'd like to request the ability to make Jenkins config changes for Geode builds; I want to start implementing parallel dockerized dunit tests. Could someone with the appropriate skillz set me up please? Thanks --Jens

Re: Need to know complete execution time for geode-core Junit tests

Hi Dinesh, When I run '*./gradlew clean geode-core:test*', it takes about 1:30m on an iMac. How are you invoking the build? You can see the progress by tailing the file: geode-core/build/test/test-progress.test. --Jens On Tue, Jul 25, 2017 at 1:13 AM, Dinesh Akhand

Re: Review Request 61114: GEODE-3296: Speed up Acceptance Tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61114/#review181430 --- Ship it! Ship It! - Jens Deppe On July 25, 2017, 4:58 p.m

Re: [VOTE] Using Pull Requests over Review Board

We can always set up a bit of automation so that committers are notified if a PR sits unattended for a period of time. --Jens On Mon, Jun 12, 2017 at 4:20 PM, Udo Kohlmeyer wrote: > 0 for PR - I feel that both have their benefits and downsides. > > * +1 for PR: As Naba

Re: Review Request 60142: GEODE-3071: Provide capability to parallelize distributedTests

--- Manual test on linux Thanks, Jens Deppe

Re: Enabling debugging from gfsh launched components

y 31, 2017 at 7:41 AM, Jens Deppe <jde...@pivotal.io> wrote: > > > Hi, > > > > In the past, when launching a server or locator with gfsh, I could > specify > > debugging options like this: > > > > gfsh start locator --name=locator1 \ > > --

Re: [DISCUSS] easy string based partitioning

I like the idea of keeping the configuration 'conventional' and thus not requiring any server configuration. As soon as you need to define a regex on the server you might as well be writing PartitionResolver code. As an aside I also think that using regexes to parse keys would also introduce a

Review Request 60142: GEODE-3071: Provide capability to parallelize distributedTests

ca79a3816bffa56e412d82dd570f1e0e445592be gradle/docker.gradle PRE-CREATION Diff: https://reviews.apache.org/r/60142/diff/1/ Testing --- Manual test on linux Thanks, Jens Deppe

Re: Review Request 60142: GEODE-3071: Provide capability to parallelize distributedTests

Thanks, Jens Deppe

Enabling debugging from gfsh launched components

Hi, In the past, when launching a server or locator with gfsh, I could specify debugging options like this: gfsh start locator --name=locator1 \ --J=\"-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5005\" I had to specially quote the agentlib options otherwise the commas would

Re: [DISCUSS] Clean build takes 10minutes to complete now

Right. I've added the full distribution to be uploaded as part of the 'uploadArchives' task. Here is how you can set up your gradle environment to retrieve it. Add the apache snapshot repo to your repositories: repositories { maven { url

Re: Correct Geode REST API cipher

I've responded to your stackoverflow question... --Jens On Fri, Sep 22, 2017 at 2:29 AM, Rupert St John Webster < rup...@impress-solutions.com> wrote: > Hi, > > Please can someone advise which cipher to use for > ssl-enabled-components=web and ssl-ciphers=any > > After starting Geode with web

Changes to Jenkins geode-nightly build job

Hi, I'm making changes to the geode-nightly build such that it will use docker containers for distributedTests. This means that these tests can also be parallelized, although for now I'm setting the parallelism to 1. Initially, this change should help with network isolation for tests so that

Re: Review Request 62001: GEODE-3525: Dockerize AcceptanceTests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62001/#review184271 --- Ship it! Ship It! - Jens Deppe On Aug. 30, 2017, 10 p.m

Re: git repo is gone

, Sep 1, 2017 at 2:31 PM, Jens Deppe <jde...@pivotal.io> wrote: > I believe it is. Just looking to see how/what we're supposed to use now. > > --Jens > > On Fri, Sep 1, 2017 at 2:30 PM, Bruce Schuchardt <bschucha...@pivotal.io> > wrote: > >> I'm not able to a

Re: git repo is gone

I believe it is. Just looking to see how/what we're supposed to use now. --Jens On Fri, Sep 1, 2017 at 2:30 PM, Bruce Schuchardt wrote: > I'm not able to access the Apache repo anymore > > git clone https://git-wip-us.apache.org/repos/asf/geode.git > Cloning into

Re: git repo is gone

schucha...@pivotal.io> > wrote: > > > > So we go directly to github now? Not gitbox.apache.org? > > > > I'm able to clone this: https://gitbox.apache.org/repos/asf/geode.git > > > > > >> On 9/1/17 2:37 PM, Jens Deppe wrote: > >> TL

Re: geode and open JDK / newer version of java

Hi Roi, We've spent a little time doing some cursory testing with Java 9 and there are definitely some issues: - Compilation requires additional JVM args because of the new modularization in Java 9. - A few lambda syntaxes in tests need to be adjusted. - Some tests fail due to powermock issues.

Re: Debugging intermittent dunit failures

r > > > > > > disk artifacts pollute later tests. > > > > > > > > > > > > On Mon, Dec 11, 2017 at 1:42 PM, Dan Smith <dsm...@pivotal.io> > > > wrote: > > > > > > > > > > > > > One othe

Re: Debugging intermittent dunit failures

rking directory or user's home directory. > > > > On Thu, Dec 14, 2017 at 4:08 PM, Jens Deppe <jde...@pivotal.io> wrote: > > > > > I'll do that. > > > > > > On Thu, Dec 14, 2017 at 2:02 PM, Kirk Lund <kl...@apache.org> wrote: > > &g

Debugging intermittent dunit failures

I've recently debugged various distributed tests which fail as a result of prior tests not cleaning up enough. It's somewhat painful and this is my usual debug process: - Examine the progress.txt file to determine which tests ran before my failing test. - I pick 20-25 of these tests and

Default branch for geode should be 'develop'

Currently, github has the default branch for apache/geode set to 'master'. (which is why you need to point the relevant branch to 'develop' for every new PR). Do we agree that this should be set to 'develop'? (I've messaged with some of the Infra folks and nothing appears to have changed

Has github changed some preferences?

It seems that (at least my github pages) are acting a bit differently. When creating a Pull Request make sure that you create it against *develop* and not *master*: [image: Inline image 1] I would typically just ignore this and click through but that led me to creating a PR with 100s of

Re: Default branch for geode should be 'develop'

M Bruce Schuchardt <bschucha...@pivotal.io > > > > wrote: > > > > > +1 > > > > > > > > > On 12/11/17 1:40 PM, Jens Deppe wrote: > > > > Currently, github has the default branch for apache/geode set to > > > 'master'. >

Geode PR cleanup

Hey all, Could we do some github pull request housekeeping please? Specifically: - If you have an open PR that you know is not going to be merged, please close it. - If you have reviewed a PR and requested changes which have not been made, please bump the PR and see if the original

Re: what is the command to read cacheserver.gfs file??

Hi Dinesh, Yes, that's pretty much it. That command will give you a list of all the possible stats. If you want an individual stat you can retrieve it like this: java -cp $GEODE_HOME/lib/geode-dependencies.jar org.apache.geode.internal.SystemAdmin stats vmStats:VMStats.processCpuTime

Consistent results from gfsh commands

Hi, I've noticed that various commands, that execute on multiple members, return either tabulated results (one line per member - for example CreateRegionCommand) or a single pass/fail line. In the latter case it’s possible that information would get lost. For example if a command fails on

Re: [DISCUSS]: Handling of SDTOUT/STDERR and Signals

Hi Juan, Thanks for the detailed analysis. I did some digging too and cannot see why the QUIT signal might be getting lost. I'll do some more investigation... Just for reference, you can still use the 'jstack' tool to get thread dumps although they just show on the terminal where you run the

Objections to removing 'upgrade offline-disk-store' command

The gfsh command 'upgrade offline-disk-store' exists in the code in order to upgrade diskstores from pre-Apache days (GemFire 6.x and 7.x). I don't believe the command is relevant/necessary anymore and, unless there are objections, I'd like to go ahead and remove it. --Jens

Re: Need information about vf.gf.locator.status.cmd & vf.gf.locator.status.cmd

Hi Dinesh vf.gf.locator.status.cmd and vf.gf.locator.stop.cmd are 'watchdog' files used to send commands to the locator. In this case, they are used to request status and to request the locator to stop. There are similar files, called vf.gf.server.* for the servers. These are just internal files

Better support for JSON gfsh results

Hi All, I'm working on removing our dependency on geode-json (org.json) in favor of Jackson. Initially this work has revolved around refactoring the internal results from gfsh commands (nothing that is user-visible). I'm now looking at the various gfsh 'data' commands (get, put, query and

Re: Addition of rmi-io library

re > > > port > > > > for RMI connections. > > > > > > > > We should also make sure this is not leaking open sockets/file > > > decriptors. > > > > How does this SimpleRemoteInputStream we are creating get shutdown > and > &

Re: [PROPOSAL]: Adding declarable support in Gfsh command

This also avoids the other option of implementing this by having associated 'params' options for each option which can take a Declarable, thus reducing the proliferation of options - in particular for 'create region'. i.e. --cache-listener AND --cache-listener-params. Further, this json

Re: Addition of rmi-io library

t;> All the FileContent are saved in temp folder, and get cleaned up after > >> each > >>> deployment. > >>> > >>> On Tue, Jan 23, 2018 at 3:17 PM, Dan Smith <dsm...@pivotal.io> wrote: > >>> > >>>> I don't have an issue with th

[PROPOSAL] Deprecate running JMX Manager on non-locator members

TL;DR I'd like to propose that we deprecate and ultimately remove the ability to run a JMX manager on a non-locator member. I'm not sure about the history for this capability and the original use cases but I imagine it would have been driven, to a large part, by the ability for member discovery

Re: [PROPOSAL] Deprecate running JMX Manager on non-locator members

One thing that prompted this initial proposal is that our (management and monitoring) service boundaries, (or one could say APIs), are not well defined. Case in point; we currently have a 'configuration service' which is used to persist configuration. This service is only available on locators.

Re: Revert recent Gradle upgrade

.8 for features and futureproofing (#2050) > > Enable: > * Java 10 (when ready) > * remove deprecated configuration settings > * build-cache > * incremental > * Update classpath/srcpath logic > > Disable: > * parallel (to fix Tomcat tes

Re: Proposal to support custom java.security.Provider

How does this work if the user wants to use the Trust/KeyStoreManager from the default security provider but still override other SSL properties such as ciphers or protocols? --Jens On Mon, Aug 13, 2018 at 8:32 AM Sai Boorlagadda wrote: > To make it clear about the different options: > > 1) if

Re: GitHub PR notifications

+1 for less Spam  spam  spam  spam Seriously - considering the comments started by Kirk's email, given the amount of spam, it's not surprising that folks would use a different means of getting a speedier response (Slack) rather than using email. Point being that the lower the noise/signal

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

. What does it >mean? > > Is there anything else that needs to go into 1.7? > > It seems like the best we all can do is to review Sai's PRs. Is that > correct? > > On Wed, Aug 22, 2018 at 10:59 AM, Jens Deppe wrote: > > > I'd also like to include GEODE-5619 > > > &g

Re: Admin API getMissingPersistentMembers is deprecated

If you're looking for a non-deprecated way but still (unfortunately) internal then 'ShowMissingDiskStoresFunction' will probably help. --Jens On Thu, Aug 23, 2018 at 2:27 PM Dan Smith wrote: > I think this was replaced with a gfsh command that does the same thing. > Unfortunately, we don't

Re: Windows builds failing

Not in the build process. Having them all fail simultaneously is very suspicious though. I restarted one of them and it ran fine. We're about to switch the build model for Windows to match the linux builds where a 'heavy lifter' is spawned for each job. During my testing of that I found the

Re: Windows builds failing

That went in a few days ago so this run is already using that. On Fri, Aug 24, 2018 at 2:49 PM Jacob Barrett wrote: > Dan just merged a change to gradle that drops the scanner plugin that > seems to suck up a ton of ram. > > > On Aug 24, 2018, at 2:38 PM, Je

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I'd also like to include GEODE-5619 On Tue, Aug 21, 2018 at 3:59 PM Xiaojian Zhou wrote: > +1 > > The release will be a great one with so many historical bugs fixed. > > Today I tried to use IJ to build and run with latest build.gradle and > recent moved test packages, it worked. So this

Re: PutCommandWithJsonTest and DeployWithLargeJarTest

Recently all of the AcceptanceTest failures I've looked at have been around bind exceptions on startup which implies test pollution from prior tests. --Jens On Tue, Aug 21, 2018 at 10:18 AM Sai Boorlagadda wrote: > The metrics job themselves will be green (as they complete to success) but >

Re: Moving from gradle to maven

stack overflow ( > > https://stackoverflow.com/questions/36808351/running-junit-tests-in-parallel-with-docker > ) to a homebuilt solution, but I'm unsure how replicable it is. > > -Sean. > > On Wed, Jul 18, 2018 at 1:21 PM Jens Deppe wrote: > > > +1 For moving to maven.

Re: Moving from gradle to maven

+1 For moving to maven. I think the blog Kirk linked hits all the relevant pain points. This is the third time we've done significant Gradle work and every time it is painful. It's also probably never going to get any better. For myself, Gradle certainly feels like a lot of magic happening

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Regards > > >>>>>>>>>>> Nabarun > > >>>>>>>>>>> On Mon, Aug 27, 2018 at 12:02 PM Bruce Schuchardt < > > >>>>>>>>>> bschucha...@pivotal.io> > > >>>>&

Code Reviews

I came across this article a while back but just re-read it recently and thought it would be worth sharing. https://medium.freecodecamp.org/unlearning-toxic-behaviors-in-a-code-review-culture-b7c295452a3c I don't think we're doing much, if any, of the 'toxic' behavior, but it's still good to be

Re: build is broken

The dependency is the rmi-io library. It provides functionality for streaming data over RMI. It was added a few weeks ago, so I'm not sure why your build is breaking now. --Jens On Tue, Jan 23, 2018 at 9:41 AM, Kirk Lund wrote: > Looks like this dependency is Jackcess (used

Addition of rmi-io library

Apologies that this was not raised earlier in discussion but I'm happy to describe it now. *Background:* When deploying jars into Geode they are moved through the system as simple byte[] blobs. This obviously consumes memory. The various affected areas are: - gfsh reads the jars into memory -

Re: Row-Level security with key as a regex

Hi Nilkanth, It's basically up to the provided SecurityManager how to handle the ResourcePermission passed into it. So in your implementation could be as simple as: if (rp.getKey() != null && rp.getKey().contains("system") {...} Are you perhaps looking at a specific SecurityManager

Re: [DISCUSS]: Tests requiring external services

ue, Apr 3, 2018 at 4:29 PM, Sean Goller <sgol...@pivotal.io> > > > wrote: > > > > > > > > > > > I'm actually fine with putting it in AcceptanceTest for now. > > > > > > > > > > > > Ideally I'd like to see somethi

Re: [DISCUSS]: Tests requiring external services

I'm in favor of using docker for test isolation. We already have an 'AcceptanceTest' category which you might consider using instead of creating yet another category. --Jens On Tue, Apr 3, 2018 at 2:02 PM, Nick Reich wrote: > Team, > > As part of validating the new JDBC

Re: Please use Awaitilty instead of Thread.sleep

My bad. Thanks for pointing that out Kirk. On Fri, Mar 16, 2018 at 11:22 AM, Kirk Lund wrote: > I can't believe we're still checking in new tests with Thread.sleep of 10 > seconds instead of using Awaitility. > > org.apache.geode.management.internal.configuration. >

Re: [DISCUSS] gradle checks for test categories.

The build already fails if a test is added without @Category. Do you mean it should fail if the test also does not have one of these newer categories? --Jens On Wed, Mar 21, 2018 at 9:51 AM, Nabarun Nag wrote: > Hi, > > As we have now categorized our tests to categories like

Re: [VOTE] Apache Geode 1.5.0 RC1

-0700 Source-Repository: release/1.5.0 Source-Revision: 4ef51dacd79ff69336fb024f3d4b07271e90 --Jens On Wed, Mar 21, 2018 at 9:01 AM, Dave Barnes <dbar...@pivotal.io> wrote: > +1 User Guide builds correctly from source, javadocs look up-to-date > > On Wed, Mar 21, 2018 a

Disabling DistributedRestoreSystemPropertiesTest for now

It appears that DistributedRestoreSystemPropertiesTest is intermittently failing and breaking the build. My initial analysis shows that the use of *categories* results in *all* test classes being instantiated and some of those instantiations end up launching DUnit VMs as a result of static or

Re: [VOTE] Apache Geode 1.5.0 RC1

+1 - basic gfsh functionality looks good on Windows. On Tue, Mar 20, 2018 at 5:07 PM, Anthony Baker wrote: > md5 generation is already removed from geode, just need to do this for > geode-examples. > > Anthony > > > > On Mar 20, 2018, at 3:30 PM, Swapnil Bawaskar

Re: [Discuss] Where should simple classes for tests belong?

For testing functionality like 'gfsh deploy' one has to be aware of classloading issues. Specifically, when writing dunit tests, classes are compiled from java resource files so that they are guaranteed not to be on the classpath during testing. This is less of an issue for gfsh acceptance tests

Re: Develop Compilation Failure

No worries, and thanks for the heads-up Juan. I'm really not sure anything can be done that wouldn't end up being heavy-handed and mostly just be an impedance. I should have sent out a notice describing the commons-lang change (given its scope) and that any in-flight PRs might be affected.

Re: Build Jobs not accessible?

Hi Juan. It could be a cookie problem - have you tried clearing them? Can you access the top-level https://concourse.apachegeode-ci.info? I can access your build just fine. --Jens On Fri, Nov 9, 2018 at 5:52 AM Ju@N wrote: > Hello team, > > I've submitted

Re: [VOTE] Time-based release schedule for minor releases

+1 for time-based releases. I think we would do well to gain some discipline around releasing on a predictable cadence. We're probably never going to be short on changes that are 'worthy' of going out on a release which, too often, simply lead to the release being stretched out as we add in Just

Re: Spring detecting MockPluginCommand and logging WARN in integration tests

If this test is already applying a custom log configuration, could it not also turn down the logging for org.springframework.shell? --Jens On Fri, Nov 16, 2018 at 12:53 PM Kirk Lund wrote: > I checked the DUnit grep for suspect strings and it's ignore WARNING log > level. So we may DUnit tests

Extremely long IntelliJ Gradle refresh times

Is anyone else experiencing very long Gradle refresh times in IntelliJ? Mine currently takes almost 60 minutes! I'm on IJ 2018.3.2. (I'm pretty sure that I'm not hitting this problem https://stackoverflow.com/questions/38209851/intellij-idea-takes-a-long-time-when-refreshing-a-gradle-project ).

Re: Extremely long IntelliJ Gradle refresh times

ng IntelliJ memory to 8g > > helps. > > > > Regards > > Naba > > > > On Wed, Jan 9, 2019 at 6:18 AM Jens Deppe wrote: > > > >> Is anyone else experiencing very long Gradle refresh times in IntelliJ? > >> Mine currentl

Re: Extremely long IntelliJ Gradle refresh times

at 6:32 AM Jens Deppe wrote: > Maybe it's just my system, but this commit seems to have introduced the > problem for me: > > 411b22cdd1d87f1c55f81de948ff36f421a893af - GEODE-6198: Add > geode-all-bom for dependency versioning (#2995) > > As an aside (but possibly r

Re: [PROPOSAL] Change Geode Log4J2 appenders to avoid programmatic add/remove

+1 on this approach! I'd like to work with you on this to get more familiar with our logging setup. --Jens On Thu, Sep 13, 2018 at 10:01 AM Kirk Lund wrote: > Geode currently manipulates Log4J2 at runtime to add/remove Appenders based > on the Cache lifecycle. While working on GEODE-5637, Sai

Re: Dependency review for release 1.9.0

I'd like to request GEODE-6559 "PdxInstance.getObject() is using class from older jar in case of Reconnect" be included in 1.9 if possible. Thanks --Jens On Thu, Mar 28, 2019 at 6:50 AM Sai Boorlagadda wrote: > Changes to LICENSE and NOTICE

Re: [DISCUSS] Move or remove org.apache.geode.admin

I'm not sure if I'm interpreting various parts of this conversation correctly, but it seems that one view being assumed is that the actual removal of deprecated APIs *must* happen in the first version of a major release bump. i.e. for this discussion that would be *2.0.0*. I don't believe this is

Re: Jetty Webapp marked as optional?

How are building the code that's running here? Is it a Maven or Gradle project and, if so, what dependencies are you declaring? --Jens On Tue, Mar 5, 2019 at 1:35 PM Jinmei Liao wrote: > we've made a change to create an HttpService object when a non-client cache > is created. This will allow

Re: Jetty Webapp marked as optional?

I like that approach. I'll raise a ticket to fail gracefully if the service cannot be started due to missing dependencies. --Jens On Tue, Mar 5, 2019 at 2:59 PM Jacob Barrett wrote: > > > > On Mar 5, 2019, at 1:52 PM, Jens Deppe wrote: > > > > How are building the

Re: Very red CI -> Hold merges, please

I was still working on a fix... On Thu, Feb 7, 2019 at 11:31 AM Kirk Lund wrote: > I merged it in. > > On Thu, Feb 7, 2019 at 11:28 AM Kirk Lund wrote: > > > I think we should go ahead and merge in > > https://github.com/apache/geode/pull/3172 since it resolves the > > GfshConsoleModeUnitTest

Re: Very red CI -> Hold merges, please

No worries. I think I have a better fix now. At least the builds are moving again. On Thu, Feb 7, 2019 at 12:11 PM Kirk Lund wrote: > Sorry, go ahead and revert the commit and reopen the PR. > > On Thu, Feb 7, 2019 at 11:36 AM Jens Deppe wrote: > > > I was stil

Re: GfshConsoleModeUnitTest is failing in UnitTest

I didn't touch anything in this area, but nevertheless I reverted my commit which preceded this failure (referenced in Owen's message). However, the failure is still happening. --Jens On Wed, Feb 6, 2019 at 6:20 PM Owen Nichols wrote: > There is a ticket for this, >

Re: GfshConsoleModeUnitTest is failing in UnitTest

The problem is caused by some change in test ordering (unit tests are running in parallel) which is resulting in environmental pollution. Probably Government shutdown related... :P On Wed, Feb 6, 2019 at 7:31 PM Jens Deppe wrote: > I didn't touch anything in this area, but nevertheles

Re: GfshConsoleModeUnitTest is failing in UnitTest

Oh, feel free to review https://github.com/apache/geode/pull/3172. Better suggestions on how to 'fix' the problem are most welcome. On Thu, Feb 7, 2019 at 6:49 AM Jens Deppe wrote: > The problem is caused by some change in test ordering (unit tests are > running in parallel) which is res

Re: [DISCUSS] is it time to make Windows tests gating?

I fixed the first two and started ignoring AvailablePortHelperIntegrationTest for Windows (Windows has a default active port range wildly different than Linux which makes this test very flaky, and since it's just testing test code it seemed reasonable to ignore it).

Re: "Output path is not specified for module" (IntelliJ)

I have only experienced this when I switch to building with IntelliJ (it is also dependent on what Intellij deems necessary to build). Building with gradle has never produced this. My setup is to build with gradle but run tests with IntelliJ. I've never had to do any kind of re-import for this.

Re: [DISCUSS] require reviews before merging a PR

As reviewers we should also feel empowered to request additional reviewers on a PR (perhaps beyond whomever the original submitter may already have requested). I think that, sometimes the complexity of a change prevents someone from commenting on just a portion of the change if they do not feel

Re: PR review request

Done and merged. Thanks for the PR! Sorry it took so long to get to. --Jens On Wed, Jun 12, 2019 at 5:18 AM Alberto Bustamante Reyes wrote: > Hi, > > > Two weeks ago I sent a PR to the geode-examples repo, could someone take a > look? > > https://github.com/apache/geode-examples/pull/77 > > >

Re: Pulse - Non-Embedded Mode

More accurately, I think geode-core is only required when TLS is enabled on the locator and Pulse needs to make JMX/RMI calls over TLS. I would vote for option 2 in this scenario. --Jens On Tue, Apr 30, 2019 at 1:44 PM Jinmei Liao wrote: > I believe to run pulse in non-embedded mode, you just

Re: Pulse - Non-Embedded Mode

mode. I > > don't think we've put a lot of energy into pulse recently. > > > > -Dan > > > > > > On Tue, Apr 30, 2019 at 2:12 PM Jens Deppe wrote: > > > > > More accurately, I think geode-core is only required when TLS is > enabled > > on

Re: [DISCUSS] Release Geode 1.9.1 with logging improvements

This would then imply a SBDG 1.2.1 to include Geode 1.9.1. On Tue, Aug 13, 2019 at 11:55 AM Anthony Baker wrote: > I think there’s value is doing a 1.9.1 patch release to support Spring > users. > > Anthony > > > > On Aug 13, 2019, at 11:26 AM, Kirk Lund wrote: > > > > Udo, Thanks for the

  1   2   3   >