Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/753#discussion_r136444815
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportDataCommand.java
---
@@ -41,44 +44,34 @@ public Result
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/730#discussion_r134872863
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/MBeanJMXAdapter.java
---
@@ -72,16 +72,13 @@
private DistributedMember
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/730#discussion_r134869226
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java
---
@@ -158,7 +156,7 @@
private Thread runner
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/730#discussion_r134869699
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java
---
@@ -212,8 +211,7 @@ public static void bytesToFiles(byte
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/730#discussion_r134867453
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
---
@@ -415,9 +413,8 @@ public Result
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/729#discussion_r134348604
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/AbstractProcessStreamReaderIntegrationTest.java
---
@@ -149,7 +147,7 @@ protected
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/724#discussion_r134075704
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java
---
@@ -100,7 +105,53 @@ public void
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/724#discussion_r134075750
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePid.java
---
@@ -30,37 +30,88 @@
*/
public class
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/720
Hi Dinesh,
I just commented on your earlier PR, and the same principle applies to this
one as well: Changes to public APIs should first be discussed on
dev@geode.apache.org
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/613
Hi Dinesh,
Sorry to be so slow in responding to your PR. Since the changes you are
proposing in GEODE-3151 involve changing a public-facing API (in
DistributionConfig, I think
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/708#discussion_r132591921
--- Diff: geode-docs/tools_modules/gfsh/command-pages/query.html.md.erb ---
@@ -21,7 +21,11 @@ limitations under the License.
Run queries
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/708#discussion_r132589415
--- Diff: geode-docs/tools_modules/gfsh/command-pages/query.html.md.erb ---
@@ -21,7 +21,11 @@ limitations under the License.
Run queries
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132571788
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/config/ClusterConfigurationNotAvailableException.java
---
@@ -0,0 +1,29
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132569537
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1781,8 +1782,8 @@ protected void validate
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132568184
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -1352,11 +1328,13 @@ protected void parseCommand(final
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132585045
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/FileProcessController.java
---
@@ -112,56 +119,43 @@ private void stop(final File
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132570355
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java ---
@@ -104,6 +109,8 @@
helpMap.put("bind-ad
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132562988
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/AbstractLauncher.java ---
@@ -795,25 +785,25 @@ protected String toString(final Date
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132572256
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/AttachProcessUtils.java
---
@@ -14,21 +14,28 @@
*/
package
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/699#discussion_r132585334
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/LocalProcessLauncher.java
---
@@ -96,33 +117,55 @@ void close
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/668#discussion_r131968121
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.java
---
@@ -111,10 +113,31 @@ public void
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/668#discussion_r131967266
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParser.java
---
@@ -2596,6 +2596,18 @@ private void endDeclarable
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/668#discussion_r131966460
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.java
---
@@ -128,9 +128,16 @@ public void
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/668
Hi Darren,
It looks like `xercesImpl` may need to be declared as a `testCompile`
dependency rather than `testRuntime` in case people are building with a JDK
which does not include
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/679#discussion_r130998820
--- Diff:
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java
---
@@ -0,0 +1,242
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/679#discussion_r130998592
--- Diff:
geode-web/src/test/java/org/apache/geode/management/internal/cli/commands/ConfigCommandDUnitTest.java
---
@@ -0,0 +1,242
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/664
Thanks @jujoramos, this looks good to me. Do you have any thoughts
@jinmeiliao?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/651#discussion_r130677475
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/Launcher.java
---
@@ -99,7 +99,6 @@ protected Launcher
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/651#discussion_r130678413
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
---
@@ -633,8 +631,8 @@ public
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/651#discussion_r130677047
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/process/MBeanProcessController.java
---
@@ -260,6 +265,7 @@ private JMXServiceURL
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/672#discussion_r130673499
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommandsUtils.java
---
@@ -0,0 +1,311
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/671#discussion_r130668398
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateRegionCommand.java
---
@@ -1143,4 +721,26 @@ private
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/665#discussion_r130658877
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/Interceptor.java
---
@@ -0,0 +1,79 @@
+/*
+ * Licensed
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/665#discussion_r130661310
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ExportConfigCommandDUnitTest.java
---
@@ -0,0 +1,181
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/664
Hi Juan,
Thanks for your contribution! Your changes look good to me, but our
[Criteria for Code
Submissions](https://cwiki.apache.org/confluence/display/GEODE/Criteria+for+Code
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/651#discussion_r129647633
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java
---
@@ -639,29 +639,34 @@ public Result
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/596
Merged as 451d12e
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/596
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/596#discussion_r123822645
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java
---
@@ -130,31 +125,8 @@ public Result
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/596#discussion_r123820699
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java
---
@@ -109,12 +107,10 @@ public Result
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/596#discussion_r123819260
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/beans/MemberMBean.java
---
@@ -148,7 +148,12 @@ public long
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/596#discussion_r123818520
--- Diff:
geode-core/src/test/java/org/apache/geode/management/internal/security/DiskStoreMXBeanSecurityJUnitTest.java
---
@@ -57,7 +56,48 @@ public
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/596#discussion_r123817037
--- Diff:
geode-core/src/main/java/org/apache/geode/management/CacheServerMXBean.java ---
@@ -60,48 +61,48 @@
/**
* Returns the port
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/580#discussion_r122066276
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/OrderByComparator.java
---
@@ -228,4 +139,55 @@ void addEvaluatedSortCriteria
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/508
This PR has already been merged in, but feel free to open a new ticket for
that. We unfortunately still have a lot of other "gemfire" references
scattered around.
---
If your proj
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/508
Merged as `ac404ad`. Thank you for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/566
(I also need to file a bug since that command appeared to hang.. But it did
end up starting the server despite gfsh hanging with an endless ".")
---
If your project is set up f
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/566
Some more feedback after walking through the example.. Now that we start a
locator (which starts an http server of its own on 7070) we need to specify a
different http port for the server
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/566
I think it would probably be best to omit
`--J=-Dgemfire.http-service-bind-address=localhost` from the `start server`
command for the sake of simplicity. You also might want to consider
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/508
Looks good to me. I'll merge it in shortly and cherry pick onto the
release branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/557
Looks like travis-ci failed. LGTM as soon as travis passes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/530
Thank you for your contribution, looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/551#discussion_r119420029
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/ShellExitCode.java ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/551#discussion_r119419341
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/ShellExitCode.java ---
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119233486
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -771,11 +771,18 @@ public
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119231037
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
---
@@ -2747,6 +2749,8 @@
public static final
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119229190
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -771,11 +771,18 @@ public
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119219867
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -771,11 +771,18 @@ public
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/549#discussion_r119220596
--- Diff:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
---
@@ -1794,18 +1801,20 @@ public
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/539
Thanks for your contribution, Emily! It looks like this branch will need
to be rebased onto the latest develop to apply cleanly. Would you mind
updating the PR with a rebased version
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/528
Merged as dff937f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/429
Closing this PR until GEODE-2705 and a few other concerns are addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jaredjstewart closed the pull request at:
https://github.com/apache/geode/pull/429
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/429#discussion_r107221701
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
---
@@ -126,14 +111,16 @@ public void
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/429#discussion_r107195082
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
---
@@ -144,40 +131,99 @@ public void run
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/429#discussion_r107195612
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/ClassPathLoaderTest.java ---
@@ -65,6 +65,26 @@ public void testLatestExists() throws
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/429#discussion_r107194282
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
---
@@ -126,14 +111,16 @@ public void
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/429#discussion_r107192575
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/JarDeployerIntegrationTest.java
---
@@ -39,83 +44,63 @@
@Rule
public
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/geode/pull/431
GEODE-2692: Fix tests relying on file creation time
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaredjstewart/geode GEODE-2692
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/429
Precheckin is started (still running)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/geode/pull/428
GEODE-2649: Export logs does not use file creation time
Precheckin started (still running)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/417
Weâll see if the nightly build passes in the morning :D
> On Mar 7, 2017, at 4:07 PM, Kenneth Howe <notificati...@github.com> wrote:
>
> @pdxrunner commented on th
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/geode/pull/417
GEODE-2621: Reduce time sensitivity of ExportLogsDUnitTest
Precheckin started (still running)
You can merge this pull request into a Git repository by running:
$ git pull https
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/403
It seems like it might be simpler to add an explicit dependency for
commons-beanutils to geode-core. That way if we later introduce some new
dependency which requires say commons-beanutils
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/403
Can you explain why the version override strategy is necessary? I think
geode-pulse (or any other submodule with an explicit dependency on
commons-beantuils) should end up with version 1.9.3
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/395
Precheckin started
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/geode/pull/395
GEODE-2430: Fix failing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaredjstewart/geode GEODE-2430
Alternatively you can review
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/geode/pull/393
GEODE-2430: Remove jar and zip files from test resources
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaredjstewart/geode GEODE-2430
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/393
Precheckin started
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/383#discussion_r99268355
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/InternalDataSerializerQuickcheckStringTest.java
---
@@ -0,0 +1,63
Github user jaredjstewart closed the pull request at:
https://github.com/apache/geode/pull/380
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/383#discussion_r99239963
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/InternalDataSerializerQuickcheckStringTest.java
---
@@ -0,0 +1,63
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/383#discussion_r99235354
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/InternalDataSerializerQuickcheckStringTest.java
---
@@ -0,0 +1,63
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/368
+1, this looks much better!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/380
See
[here](https://github.com/jaredjstewart/geode/blob/GEODE-2409/README.md) to
view the updated readme in your browser.
---
If your project is set up for it, you can reply to this email
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/geode/pull/380
GEODE-2409: Beautify readme
- Add Apache Geode banner image
- Add badges for the latest version in Maven Central and for the Apache
2.0 license
- Improve formatting for the table
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/374
Precheckin passed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/374
`HelpCommandsIntegrationTest` failed in precheckin. I've pushed a change
to the properties file used by that test and started a new precheckin.
---
If your project is set up for it, you can
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/374
Precheckin started
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/geode/pull/361
GEODE-2325: Improve tests for JarDeployer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaredjstewart/geode GEODE-2325
Alternatively
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/361
Precheckin passed (other than an unrelated failure in
`PRClientServerRegionFunctionExecutionFailoverDUnitTest.
testServerFailoverWithTwoServerAliveHA`)
---
If your project is set up
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/geode/pull/347
GEODE-2313: Fix PulseDataExportTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaredjstewart/geode GEODE-2313
Alternatively you can
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/geode/pull/339
GEODE-2272: Fix Pulse data browser export
* Pulse no longer loads all results into the browser before generating a
results file for download.
You can merge this pull request into a Git
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/339
Precheckin started
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user jaredjstewart commented on the issue:
https://github.com/apache/geode/pull/338
Closing for now due precheckin failures
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jaredjstewart closed the pull request at:
https://github.com/apache/geode/pull/338
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/geode/pull/338
GEODE-2272: Fix Pulse data browser export
* Pulse no longer loads all results into the browser before generating a
results file for download.
You can merge this pull request into a Git
GitHub user jaredjstewart opened a pull request:
https://github.com/apache/geode/pull/336
GEODE-2194: Fix pulse webapp context
This commit re-adds a line (which turns out to be necessary) that was
removed during the review of PR #335.
You can merge this pull request into a Git
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/335#discussion_r95899936
--- Diff: geode-pulse/src/main/webapp/WEB-INF/web.xml ---
@@ -32,7 +32,7 @@
mvc-dispatcher
-/pulse/*
--- End diff
Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/335#discussion_r95897532
--- Diff: geode-pulse/src/main/webapp/WEB-INF/web.xml ---
@@ -32,7 +32,7 @@
mvc-dispatcher
-/pulse/*
--- End diff
1 - 100 of 122 matches
Mail list logo
