: Wednesday, December 16, 2020 at 10:47 AM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Hi Owen,
Thanks for pushing this forward! Given that a lot of folks are on holiday -
maybe sometime in January might be a better time to merge this to develop to
give everyone
Sent: Tuesday, December 15, 2020 3:00 PM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Given the support this is receiving, it looks like the next step is to bring
CODEOWNERS to develop.
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F
, December 14, 2020 at 7:25 AM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
I've self-nominated for redis, management and security.
--Jens
On 12/14/20, 1:44 AM, "Owen Nichols" wrote:
Thanks @Dave and @Karen for volunteering as code owners!
o or more volunteers on each line is desirable.
From: Owen Nichols
Date: Monday, December 7, 2020 at 4:53 PM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Let’s keep this simple. If you’re nominating yourself, just commit to the
branch di
has to go through the normal PR process back to the
develop branch.
-Robert
From: Jens Deppe
Date: Monday, December 7, 2020 at 11:43 AM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Should we just be adding to Owen's PR?
If everyone creates their own PR we'l
a formal PR to bring it to
develop? We can always fill in any missing code-owners after Dec 14 via PR
against develop.
From: Robert Houghton
Date: Monday, December 7, 2020 at 1:38 PM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
To be honest, I hadn’t
back to the
develop branch.
-Robert
From: Jens Deppe
Date: Monday, December 7, 2020 at 11:43 AM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Should we just be adding to Owen's PR?
If everyone creates their own PR we'll probably end up with a bunch of merge
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
It looks like the discussion period ended Nov 25 with all comments in
support, so next phase is populating the proposed codeowners file. @Robert how
long do we have to populate this before you plan to formal
on
14 December?
From: Owen Nichols
Date: Tuesday, December 1, 2020 at 8:56 PM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
It looks like the discussion period ended Nov 25 with all comments in support,
so next phase is populating the proposed codeowners
concluded?
>
>From: Robert Houghton
> Date: Wednesday, November 18, 2020 at 2:07 PM
>To: dev@geode.apache.org
>Subject: [DISCUSS] Adding CODEOWNERS to Apache Geode
>Hello Devs.
>
>I would like to improve
concluded?
>
>From: Robert Houghton
> Date: Wednesday, November 18, 2020 at 2:07 PM
>To: dev@geode.apache.org
>Subject: [DISCUSS] Adding CODEOWNERS to Apache Geode
>Hello Devs.
>
>I would like to improve
Sent: Thursday, November 19, 2020 17:55
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
+1
I think we as a project will need to iterator on the code owners as well as the
process for code owners. But this is a model that has been adopted by a number
of OSS
reviewers by default, but when the draft transitions
> to ‘ready’, then the owners are requested to review.
>
>
>From: Ernie Burghardt
>Date: Thursday, November 19, 2020 at 9:56 AM
>To: dev@geode.apache.org
>Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
&g
, November 19, 2020 at 9:56 AM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Does GitHub allow us to limit this automated action to non-DRAFT PRs?
On 11/18/20, 8:28 PM, "Owen Nichols" wrote:
+1 This will greatly im
Hi Ernie,
DRAFT PRs do not get reviewers by default, but when the draft transitions to
‘ready’, then the owners are requested to review.
From: Ernie Burghardt
Date: Thursday, November 19, 2020 at 9:56 AM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
Does
is not
enforced (you can’t review your own PR)
* Feel free to start PRs or changes to `features/introduce_codeowners`
From: Owen Nichols
Date: Wednesday, November 18, 2020 at 8:28 PM
To: dev@geode.apache.org
Subject: Re: [DISCUSS] Adding CODEOWNERS to Apache Geode
+1 This will greatly improve
be
merged before Nov 26, or do we all just need to be patient until this review
period has concluded?
From: Robert Houghton
Date: Wednesday, November 18, 2020 at 2:07 PM
To: dev@geode.apache.org
Subject: [DISCUSS] Adding CODEOWNERS to Apache Geode
Hello Devs.
I would like
, November 18, 2020 at 2:07 PM
To: dev@geode.apache.org
Subject: [DISCUSS] Adding CODEOWNERS to Apache Geode
Hello Devs.
I would like to improve the quality of the pull-request reviews we see for
critical parts of the Apache Geode project. In discussions with other
committers, a (not the) big hurdle
Hello Devs.
I would like to improve the quality of the pull-request reviews we see for
critical parts of the Apache Geode project. In discussions with other
committers, a (not the) big hurdle to that is getting the right eyes to
look at a given PR. To that end, I propose the adoption of GitHub's
19 matches
Mail list logo
