Re: [DISCUSS] Apache Geode 1.7.0 release branch created

[UPDATE] Cherry-picking 156333bfc397c96963e7af598897066989ff0d4e GEODE-5695 to release branch On Tue, Sep 4, 2018 at 4:45 PM Nabarun Nag wrote: > So the issue is that it takes longer to start than previous releases? > Yes > > Also, is this wait time only when using Gfsh to create > gatew

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

So the issue is that it takes longer to start than previous releases? Yes Also, is this wait time only when using Gfsh to create gateway-receiver? No, even APIs On Tue, Sep 4, 2018 at 4:43 PM Anilkumar Gingade wrote: > Its not gfsh specific. Its in the Gateway receiver start. > > It loo

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Its not gfsh specific. Its in the Gateway receiver start. It looks like the changes with GEODE-5591 still hit the earlier issue (it was fixing) if the port is same as the port returned by "getPortToStart()", that was removed. I may be wrong. -Anil. On Tue, Sep 4, 2018 at 4:39 PM Sai Boorlagadda

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Why is it waiting at all in this case? Where is this 2 minute timeout coming from? -Dan On Tue, Sep 4, 2018 at 4:12 PM, Sai Boorlagadda wrote: > So the issue is that it takes longer to start than previous releases? > Also, is this wait time only when using Gfsh to create gateway-receiver? > > O

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

So the issue is that it takes longer to start than previous releases? Also, is this wait time only when using Gfsh to create gateway-receiver? On Tue, Sep 4, 2018 at 4:03 PM Nabarun Nag wrote: > Currently we have a minor issue in the release branch as pointed out by > Barry O. > We will wait til

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Reverting GEODE-5591 results in code that can produce an infinite loop, so I don't feel that's a viable option. I feel as though the code treats bind exceptions as transient occurrences, but my direct experience with them leads me to the opposite conclusion. I don't believe a long wait time is goin

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Currently we have a minor issue in the release branch as pointed out by Barry O. We will wait till a resolution is figured out for this issue. Steps: 1. create locator 2. start server --name=server1 --server-port=40404 3. start server --name=server2 --server-port=40405 4. create gateway-receiver -

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Status Update on release process for 1.7.0 - checkPom files are being modified to have version as 1.7.0 instead of 1.8.0-SNAPSHOT - gradle.properties file has been modified to reflect 1.7.0 as the version. - Version.java has been reverted to remove all changes corresponding to 1.8.0 - CommandInitia

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I have resolved GEODE-5254 Dale > On Aug 31, 2018, at 3:34 PM, Nabarun Nag wrote: > > Requesting status update on the following JIRA tickets. These tickets have > commits into develop against its name but the status is still open / > unresolved. > > GEODE-5600 - [Patrick Rhomberg] > GEODE-5578

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Announcement : The branch for 1.7.0 has been cut. Please from this point onwards use 1.8.0 as the fixed version for your JIRAs Regards Nabarun Nag On Fri, Aug 31, 2018 at 3:34 PM Nabarun Nag wrote: > Requesting status update on the following JIRA tickets. These tickets have > commits into devel

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Requesting status update on the following JIRA tickets. These tickets have commits into develop against its name but the status is still open / unresolved. GEODE-5600 - [Patrick Rhomberg] GEODE-5578 - [Robert Houghton] GEODE-5492 - [Robert Houghton] GEODE-5280 - [xiaojian zhou & Biju Kunjummen] GE

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Please continue using 1.7.0 as a fix version in JIRA till the email comes in that the 1.7.0 release branch has be cut. Changing the fixed version for the following tickets to 1.7.0 from 1.8.0 as these fixes will be included in the 1.7.0 release GEODE-5671 GEODE-5662 GEODE-5660 GEODE-5652 Regards

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

A new feature of get/set cluster config was added as new feature to gfsh. This needs to be added to the documentation. Once this is done, the branch will be ready. Regards Nabarun On Fri, Aug 31, 2018 at 2:15 PM Alexander Murmann wrote: > Nabarun, do you still see anything blocking cutting the

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Nabarun, do you still see anything blocking cutting the release at this point? Maybe we can even get a pipeline going today? 😳 On Fri, Aug 31, 2018 at 10:38 AM, Sai Boorlagadda wrote: > We can go ahead and cut 1.7 with out GEODE-5338 as I don't have the code > ready. > > GEODE-5594, adds a new

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

We can go ahead and cut 1.7 with out GEODE-5338 as I don't have the code ready. GEODE-5594, adds a new flag to enable hostname validation and is disabled by default so we are good with changes that are already merged and documentation for GEODE-5594 is ready merged. Naba, after the branch is cut

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I am waiting on the documentation tickets to get closed before cutting the branch. Regards Nabarun Nag On Fri, Aug 31, 2018 at 10:18 AM Anthony Baker wrote: > Perhaps we should cut 1.7.0 without these changes to give us more time to > review and complete the work. > > Thoughts? > > Anthony > >

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

+1 to cutting without Given the back and forth we have seen on the TLS change, I'd rather avoid rushing it. On Fri, Aug 31, 2018 at 10:18 AM, Anthony Baker wrote: > Perhaps we should cut 1.7.0 without these changes to give us more time to > review and complete the work. > > Thoughts? > > Anthon

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Perhaps we should cut 1.7.0 without these changes to give us more time to review and complete the work. Thoughts? Anthony > On Aug 31, 2018, at 8:03 AM, Sai Boorlagadda > wrote: > > I haven't yet merged GEODE-5338. The PR changes the existing behavior and > is not acceptable. > Working on c

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I haven't yet merged GEODE-5338. The PR changes the existing behavior and is not acceptable. Working on changing the implementation to have a default value derived based on how user wants to configure SSL. Sai On Wed, Aug 29, 2018 at 11:45 AM Sai Boorlagadda wrote: > I have merged GEODE-5594 to

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Please continue marking fixed versions as 1.7.0 till the release branch is ready. The following tickets' fixed versions have been changed to 1.7.0 from 1.8.0 GEODE-5579 GEODE-5646 GEODE-5648 Regards Nabarun Nag On Wed, Aug 29, 2018 at 2:20 PM Nabarun Nag wrote: > Thank you Sai, > We are also w

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Thanks Dan. I will make a note to remove these when we cut the branch. Sai On Wed, Aug 29, 2018 at 9:46 AM Dan Smith wrote: > I think we should delete the windows jobs from the release/1.7 branch. That > will make it clearer that we are intentionally don't care about the results > of those jobs

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Thank you Sai, We are also waiting on documentation to be updated to reflect the changes made by these resolved JIRAs. Once that is completed, I believe that we will be ready for the new branch. Regards Nabarun Nag On Wed, Aug 29, 2018 at 11:45 AM Sai Boorlagadda wrote: > I have merged GEODE-5

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I have merged GEODE-5594 to develop. GEODE-5338 is now waiting for PR review and precheckin. Sai On Tue, Aug 28, 2018 at 10:30 AM Sai Boorlagadda wrote: > GEODE-5338 is downvoted for the security concerns related to trusting > the default trust store and thus resulted in an improvement to add

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Fix has been checked in to develop for GEODE-5601. > On Aug 29, 2018, at 9:45 AM, Dan Smith wrote: > > I think we should delete the windows jobs from the release/1.7 branch. That > will make it clearer that we are intentionally don't care about the results > of those jobs because they are not y

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I think we should delete the windows jobs from the release/1.7 branch. That will make it clearer that we are intentionally don't care about the results of those jobs because they are not yet baked. -Dan On Wed, Aug 29, 2018 at 8:50 AM, Alexander Murmann wrote: > +1 for ignoring Windows jobs. As

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

+1 for ignoring Windows jobs. As far as I can tell it's not failing due to product issues and we don't ship the pipeline to users. On Wed, Aug 29, 2018 at 8:29 AM, Jens Deppe wrote: > I've just fixed GEODE-5661 (Pulse does not work when legacy SSL options are > used) that I'd also like included.

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I've just fixed GEODE-5661 (Pulse does not work when legacy SSL options are used) that I'd also like included. PR is approved and I will merge it in after standup. --Jens On Tue, Aug 28, 2018 at 3:42 PM Sai Boorlagadda wrote: > Develop pipeline is not dependent on Windows jobs and the initial r

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Develop pipeline is not dependent on Windows jobs and the initial reason being not to slow down the pipeline. But the WindowsIntegrationTest has not had a consistent green runs and is red either - due to gradle crashing half-way through (not enough memory?) or - a flaky test So

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I expect to close PR#2368 for GEODE-5590 without merging it due to unexpected test failures in other test categories. Instead I have PR#2389 (for GEODE 5601) to attain stable test results for AcceptanceTests. This is a simpler fix to the problem at the expense of a slightly longer runtime for A

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I waiting for a green precheckin for GEODE-5594. Sai On Tue, Aug 28, 2018 at 10:43 AM Alexander Murmann wrote: > Thanks for chiming in, Sai! Are you at this point waiting for more reviews? > > On Tue, Aug 28, 2018 at 10:30 AM, Sai Boorlagadda < > sai.boorlaga...@gmail.com > > wrote: > > > GEODE-

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Thanks for chiming in, Sai! Are you at this point waiting for more reviews? On Tue, Aug 28, 2018 at 10:30 AM, Sai Boorlagadda wrote: > GEODE-5338 is downvoted for the security concerns related to trusting > the default trust store and thus resulted in an improvement to add a > hostname > validat

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

GEODE-5338 is downvoted for the security concerns related to trusting the default trust store and thus resulted in an improvement to add a hostname validation as a feature before we can support trusting default trust store. So GEODE-5338 is blocked by GEODE-5594. Once I merge GEODE-5594, I will r

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Looks like we are now waiting for these tickets: GEODE-5601 which is a dup of GEODE-5590 which has this open PR: https://github.com/apache/geode/pull/2368. GEODE-5594 has open PR: https://github.com/apache/geode/pull/2346 GEODE-5338 has open PR: https://github.com/apache/geode/pull/2244. Does thi

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Thanks!! On Tue, Aug 28, 2018 at 9:13 AM Nabarun Nag wrote: > Hi Juan, > > GEODE-5618 as PR#2360 has been merged in to develop. The new branch has not > yet been created hence this fix will be in 1.7.0 > > Regards > Nabarun Nag > > On Tue, Aug 28, 2018 at 12:33 AM Juan José Ramos > wrote: > > >

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Hi Juan, GEODE-5618 as PR#2360 has been merged in to develop. The new branch has not yet been created hence this fix will be in 1.7.0 Regards Nabarun Nag On Tue, Aug 28, 2018 at 12:33 AM Juan José Ramos wrote: > Hello team, > > Can we also include GEODE-5618 in the next release?. The pull requ

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Hello team, Can we also include GEODE-5618 in the next release?. The pull request has been approved already, it just needs to be merged. Best regards. On Mon, Aug 27, 2018 at 11:45 PM Bruce Schuchardt wrote: > great! thanks > > > On 8/27/18 1:42 PM, Nabarun Nag wrote: > > I completely agree.

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

great!  thanks On 8/27/18 1:42 PM, Nabarun Nag wrote: I completely agree. Once the branch is created, it will undergo all compatibility and upgrade tests. The commit that you have mentioned will be reverted in 1.7.0, as well as any related commits Regards Nabarun Nag On Mon, Aug 27, 2018 at

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I completely agree. Once the branch is created, it will undergo all compatibility and upgrade tests. The commit that you have mentioned will be reverted in 1.7.0, as well as any related commits Regards Nabarun Nag On Mon, Aug 27, 2018 at 1:34 PM Bruce Schuchardt wrote: > I don't think it's as

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I don't think it's as easy as doing a rebase.  Someone added the 1.8 version to Version.java and we need to revert that.  We also need to see if it's being used anywhere for backward-compatibility.  If it's in use those changes need to be examined and probably undone on the branch if they're ta

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Hi Geode Developers, >From the discussion in this email thread we are waiting on couple of GEODE JIRAs to be resolved to continue with 1.7.0 release process. GEODE-5615 - resolved. GEODE-5601 - In-progress [DanSmith / Kenneth Howe ] GEODE-5594 - Open [Sai Boorlagadda] GEODE-5338 - Open [Sai Boorl

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

@Bruce those changes were done when 1.7.0 release process was in-progress, and a release branch was already created. But we stopped that process mid way. This happened in May 2018. We are planning to rebase the 1.7.0 brach with the current develop pretty soon. Regards Nabarun On Mon, Aug 27, 2018

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I am about to change the fixed version in GEODE JIRAs to 1.7.0 for those tickets which are marked closed or resolved with 1.8.0 as the fix version. Please do let me know if there are any concerns. The new release branch has not been created yet. Regards Nabarun Nag On Mon, Aug 27, 2018 at 10:17

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

It looks like we've cut a 1.7.0 release branch that says its 1.8.0.  Is that intentional? private static final byte GEODE_180_ORDINAL =95; public static final VersionGEODE_180 = new Version("GEODE","1.8.0", (byte)1, (byte)8, (byte)0, (byte)0,GEODE_180_ORDINAL); On 8/27/18 9:50 AM, Sai B

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

After reading through the weekend, validating against CN as a fallback should be acceptable and dont have any further concerns with default JDK's implementation as expressed[1]. Planning to merge GEODE-5594 today and following with GEODE-5338. Sai [1] https://lists.apache.org/thread.html/906540e1

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Regarding GEODE-5594, though the current implementation is good and needed more coverage. While adding tests to cover negative cases, I found something about JDK's default implementation of hostname validation which I am not happy about and so it needs a rethought. It could result in implementing

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I will be rebasing the release branch with develop, to bring in all the improvements/ enhancements that went in in the past few months. I am waiting on the tickets mentioned in this thread to be closed to start on a fresh release branch. Regards Nabarun Nag On Fri, Aug 24, 2018 at 12:20 PM Jens

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

5619 is marked as resolved now. Is the Release Manager planning to pick these onto 1.7 or should each person do their own? --Jens On Fri, Aug 24, 2018 at 10:52 AM Alexander Murmann wrote: > To summarize where we are right now in this discussion, I see the following > tickets listed in this thr

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

To summarize where we are right now in this discussion, I see the following tickets listed in this thread as want-to-haves for 1.7: - GEODE-5615 - ✅ resolved - GEODE-5601 - 🏃‍♀️ in progress - GEODE-5594 - 🏃‍♀️ waiting for PR review - GEODE-5338 - 🏃‍♀️ waiting for PR review - GEODE-5

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I'd also like to include GEODE-5619 On Tue, Aug 21, 2018 at 3:59 PM Xiaojian Zhou wrote: > +1 > > The release will be a great one with so many historical bugs fixed. > > Today I tried to use IJ to build and run with latest build.gradle and > recent moved test packages, it worked. So this refacto

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

+1 The release will be a great one with so many historical bugs fixed. Today I tried to use IJ to build and run with latest build.gradle and recent moved test packages, it worked. So this refactoring is also success. On Tue, Aug 21, 2018 at 3:52 PM, Anthony Baker wrote: > I most definitely agr

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

If not late, I would also like to include GEODE-5594 (enabling hostname verification) and GEODE-5338 (using the default SSL context) into 1.7.0. PRs for both are open and currently up for review. On Tue, Aug 21, 2018 at 2:26 PM Dan Smith wrote: > I think we do want to wait for GEODE-5615 (Distr

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I most definitely agree! Anthony > On Aug 21, 2018, at 2:26 PM, Dan Smith wrote: > > I think we do want to wait for GEODE-5615 (DistributedTest OOMEs) and > GEODE-5601 (AcceptanceTest port conflicts) to be fixed before cutting the > new 1.7 branch. It would be better if we don't create a relea

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I think we do want to wait for GEODE-5615 (DistributedTest OOMEs) and GEODE-5601 (AcceptanceTest port conflicts) to be fixed before cutting the new 1.7 branch. It would be better if we don't create a release branch from a point where we have these systematic issues with our pipeline. -Dan On Tue,

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

I will wait for a day to give all developers sometime to commit any new fixes into develop that is needed in 1.7.0. Please do let me know if there is any concern. Regards Nabarun Nag On Tue, Aug 21, 2018 at 12:42 PM Nabarun Nag wrote: > Yeah , I can continue with the release manager tasks. My

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Yeah , I can continue with the release manager tasks. My understanding from Dan's email is that every JIRA that was closed as 1.8 needs to be changed to 1.7 after we rebase develop over release/1.7 branch. Regards Nabarun Nag On Tue, Aug 21, 2018 at 11:57 AM Dan Smith wrote: > +1 to updating t

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

+1 to updating the 1.7 branch. There is also a 1.8 version in JIRA, and I think a bunch of things are marked as resolved in 1.8. So if you update the release branch you should probably update the fixed version on all these issues. -Dan On Tue, Aug 21, 2018 at 11:39 AM, Alexander Murmann wrote:

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Hi everyone! We cut this release branch 3 months ago and then the release got stalled. Since then we’ve added another 432 commits to develop. We also have 83 resolved Jira tickets marked as 1.8 and another 91 Jira tickets that are labeled as 1.7, but were resolved after the 1.7 branch was cut 🙄.

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

+1 On Wed, May 23, 2018 at 9:29 AM Michael Stolz wrote: > +1 > > -- > Mike Stolz > Principal Engineer, GemFire Product Lead > Mobile: +1-631-835-4771 > Download the GemFire book here. > < > https://content.pivotal.io/ebooks/scaling-data-services-with-pivotal-gemfire > > > > On Wed, May 23, 2018

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

+1 -- Mike Stolz Principal Engineer, GemFire Product Lead Mobile: +1-631-835-4771 Download the GemFire book here. On Wed, May 23, 2018 at 12:24 PM, Barbara Pruijn wrote: > +1 > > > On May 23, 2018, at 8:33 AM, Joey M

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

+1 > On May 23, 2018, at 8:33 AM, Joey McAllister wrote: > > +1 for including these. They are documentation-only changes that are > applicable to 1.7. > > On Wed, May 23, 2018 at 8:24 AM Karen Miller wrote: > >> Geode devs, I think that my merges of commits for GEODE-5071 and >> GEODE-5242 r

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

+1 for including these. They are documentation-only changes that are applicable to 1.7. On Wed, May 23, 2018 at 8:24 AM Karen Miller wrote: > Geode devs, I think that my merges of commits for GEODE-5071 and > GEODE-5242 really > belong in Geode 1.7. They just missed making it in before the rel

Re: [DISCUSS] Apache Geode 1.7.0 release branch created

Geode devs, I think that my merges of commits for GEODE-5071 and GEODE-5242 really belong in Geode 1.7. They just missed making it in before the release branch was cut. I'm going to cherry pick them into the 1.7 release branch. If anyone disagrees with this, let's discuss why, and we can always

[DISCUSS] Apache Geode 1.7.0 release branch created

Hello Geode dev community, We have created a release branch for Apache Geode 1.7.0 - "release/1.7.0" Please do review and raise any issue with the release branch. If no concerns are raised we will start with voting for release candidate within a week. Regards Nabarun Nag