Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

gt; Sent: Thursday, June 10, 2021 10:15 AM > To: dev@geode.apache.org > Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from > PRs > > +1 to new report from Owen > +1 to re-introduce the stress-test > > Great ideas Naba! > > On 6/10/21, 9:50 AM, &quo

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

From: Mark Hanson Sent: Thursday, June 10, 2021 10:15 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs +1 to new report from Owen +1 to re-introduce the stress-test Great ideas Naba! On 6/10/21, 9:50 AM, "Nabarun Nag" wrot

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

abarun Nag From: Kirk Lund Sent: Thursday, June 10, 2021 9:37 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs Ok, I wanted to give this discussion another night and we still have consensus for making both stress-ne

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

ards Nabarun Nag From: Kirk Lund Sent: Thursday, June 10, 2021 9:37 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs Ok, I wanted to give this discussion another night and we still have

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

these resolved collectively as a community. (results of the mass tests maybe). Thank you. Regards Nabarun Nag From: Kirk Lund Sent: Thursday, June 10, 2021 9:37 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

Ok, I wanted to give this discussion another night and we still have consensus for making both stress-new-test non-required. I just filed PR #6602 to change stress-new-test from required to non-required. Please review! On Wed, Jun 9, 2021 at 2:11 PM

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

Count me as -0. I have some concerns, but I’m okay trying this and seeing how it goes. Dale From: Owen Nichols Date: Wednesday, June 9, 2021 at 2:25 PM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs Summarizing this thread so far

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

Summarizing this thread so far: In favor of making stress-new non-required: Kirk Mark Myself In favor of making all PR checks non-required: Jake In favor of hashing out a more nuanced balance between making it possible (but not too easy) to ignore stress-new failures: Donal Dale Maybe that's

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

If we have consensus, no need to VOTE. > On Jun 9, 2021, at 12:52 PM, Owen Nichols wrote: > > Ok, I'm on board with changing stress-new-test from a required PR check to > non-required. It's simple, codeowners still have the final say, and it > neatly avoids the whole topic of overrides.

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

Dale From: Kirk Lund Date: Wednesday, June 9, 2021 at 9:59 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

scenario, the extra burden on code owners arises only at the committer’s request. Dale From: Owen Nichols Date: Wednesday, June 9, 2021 at 11:15 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PR

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

t 9:59 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs I do like the suggestions offered up by Dale and would encourage (or even plead) with my fellow contributors to consider these:

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

From: Owen Nichols Date: Wednesday, June 9, 2021 at 11:15 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs This would substantially increase the burden on codeowners, because now in addition to looking at the code itself, they

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

Date: Wednesday, June 9, 2021 at 11:15 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs This would substantially increase the burden on codeowners, because now in addition to looking at the code itself, they would have to wait for any

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

Date: Wednesday, June 9, 2021 at 9:59 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs I do like the suggestions offered up by Dale and would encourage (or even

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

frame as: We have too many tests whose results we don’t trust. Dale From: Kirk Lund Date: Wednesday, June 9, 2021 at 9:59 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

Date: Wednesday, June 9, 2021 at 9:59 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs I do like the suggestions offered up by Dale and would encourage (or even plead) with my fellow contributors to consider th

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

, none of this fixes the underlying problem, which I’d frame as: We have too many tests whose results we don’t trust. Dale From: Kirk Lund Date: Wednesday, June 9, 2021 at 9:59 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement fr

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

: Wednesday, June 9, 2021 10:16 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs One other thing to think about is perhaps having a rotating team to deal with flaky tests, a small team commissioned every three or 6 months to clear out flaky tests

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

than 2% of the time due to this one test failure. Yikes! > > -Dan > > From: Kirk Lund > Sent: Tuesday, June 8, 2021 9:33 AM > To: dev@geode.apache.org > Subj

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

as: We have too many tests whose results we don’t trust. Dale From: Kirk Lund Date: Wednesday, June 9, 2021 at 9:59 AM To: dev@geode.apache.org Subject: Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs I do like the suggestions offered up by Dale and would encourage (or even

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

ilure. Yikes! > > -Dan > > From: Kirk Lund > Sent: Tuesday, June 8, 2021 9:33 AM > To: dev@geode.apache.org > Subject: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs > > Our require

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

___ > From: Kirk Lund > Sent: Tuesday, June 8, 2021 9:33 AM > To: dev@geode.apache.org > Subject: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs > > Our requirement for stress-new-test-openjdk11 to pass before allowing merge > do

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

. I don’t have any ideas for how to > declare such an exclusion, but if it could be done via a file it would be > subject to code owner review. > > Dale > > From: Kirk Lund > Date: Tuesday, June 8, 2021 at 9:33 AM > To: dev@geode.apache.org > Subject: [DISCUSS] Remov

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

Lund > Sent: Tuesday, June 8, 2021 9:33 AM > To: dev@geode.apache.org > Subject: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs > > Our requirement for stress-new-test-openjdk11 to pass before allowing merge > doesn't really work as intended for fixing dist

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

re. Yikes! -Dan From: Kirk Lund Sent: Tuesday, June 8, 2021 9:33 AM To: dev@geode.apache.org Subject: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs Our requirement for stress-new-test-openjdk11 to pass before allowi

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

more than 2% of the time due to this one test failure. Yikes! -Dan From: Kirk Lund Sent: Tuesday, June 8, 2021 9:33 AM To: dev@geode.apache.org Subject: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs Our requirement for stress-new-test-openjdk11

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

for how to declare such an exclusion, but if it could be done via a file it would be subject to code owner review. Dale From: Kirk Lund Date: Tuesday, June 8, 2021 at 9:33 AM To: dev@geode.apache.org Subject: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs Our requirement

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

I think repeated tests shouldn’t be a blocker to merging for the reasons outlined below. A committer that is a good steward for the project should be allowed to make the judgement call when merging a PR. We have placed too many rigid processes in place that eliminated the good judgement of

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

Thanks Kirk for tackling some of our flakiest tests! I agree, we don't want to discourage anyone interested in paying down tech debt. The Geode community has spoken clearly against bypassing or weakening required PR checks, so relaxing requirements in general might be a tough sell, but I'm

Re: [DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

I understand the challenge, but I disagree. It is only through requirement that we keep new flakey tests out. While I don't think one should have to fix all the flaky tests to get their unrelated change in, I think it serves a purpose. IMHO, the problems that you are seeing are indications that

[DISCUSS] Remove stress-new-test-openjdk11 requirement from PRs

Our requirement for stress-new-test-openjdk11 to pass before allowing merge doesn't really work as intended for fixing distributed tests that contain multiple flaky test methods. In fact, I think it causes contributors to avoid tackling flaky tests. I've been working on GEODE-9103: CI Failure: