[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

Github user asfgit closed the pull request at: https://github.com/apache/geode-native/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

I've modified PR #13 to remove the vestigial executable and to elide the duplicate GEODE_ in the legacy include guards. Sarge > On 17 Feb, 2017, at 11:06, pivotal-jbarrett wrote: > > Github user pivotal-jbarrett commented on a diff in the pull request: > >

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/13#discussion_r101825168 --- Diff: src/cppcache/include/geode/AttributesFactory.hpp --- @@ -1,7 +1,7 @@ #pragma once -#ifndef

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/13#discussion_r101824812 --- Diff: src/CMakeLists.txt --- @@ -224,7 +222,7 @@ add_subdirectory(cppcache) add_subdirectory(cryptoimpl) add_subdirectory(dhimpl)

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/13#discussion_r101796694 --- Diff: src/CMakeLists.txt --- @@ -224,7 +222,7 @@ add_subdirectory(cppcache) add_subdirectory(cryptoimpl) add_subdirectory(dhimpl)

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

Github user PivotalSarge commented on a diff in the pull request: https://github.com/apache/geode-native/pull/13#discussion_r101796329 --- Diff: src/cppcache/include/geode/AttributesFactory.hpp --- @@ -20,7 +20,7 @@ * limitations under the License. */

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

Github user mmartell commented on a diff in the pull request: https://github.com/apache/geode-native/pull/13#discussion_r101783052 --- Diff: src/cppcache/include/geode/AttributesFactory.hpp --- @@ -20,7 +20,7 @@ * limitations under the License. */ -#include

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

Github user mmartell commented on a diff in the pull request: https://github.com/apache/geode-native/pull/13#discussion_r101782908 --- Diff: src/cppcache/include/geode/AttributesFactory.hpp --- @@ -1,7 +1,7 @@ #pragma once -#ifndef GEODE_GFCPP_ATTRIBUTESFACTORY_H_

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/13#discussion_r101659366 --- Diff: src/CMakeLists.txt --- @@ -224,7 +222,7 @@ add_subdirectory(cppcache) add_subdirectory(cryptoimpl) add_subdirectory(dhimpl)

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/13#discussion_r101659601 --- Diff: src/cppcache/include/geode/AttributesFactory.hpp --- @@ -1,7 +1,7 @@ #pragma once -#ifndef

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

Github user pivotal-jbarrett commented on a diff in the pull request: https://github.com/apache/geode-native/pull/13#discussion_r101659693 --- Diff: src/cppcache/include/geode/AttributesFactory.hpp --- @@ -20,7 +20,7 @@ * limitations under the License. */

[GitHub] geode-native pull request #13: GEODE-2476: Replace gfcpp with geode.

GitHub user PivotalSarge opened a pull request: https://github.com/apache/geode-native/pull/13 GEODE-2476: Replace gfcpp with geode. - Rename directories and files with gfcpp into their name to instead use geode and update all references thereto. - Rename the gfcpp