[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[PurelyApplied]

Github user PurelyApplied closed the pull request at:

https://github.com/apache/geode/pull/730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[PurelyApplied]

Github user PurelyApplied closed the pull request at:

https://github.com/apache/geode/pull/730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[PurelyApplied]

GitHub user PurelyApplied reopened a pull request:

https://github.com/apache/geode/pull/730

GEODE-3472: Remove a great deal of commented-out code.

* Correct imports in touched files
* Correct several misspellings
* Removed redundant modifier and specifiers
* Corrected modifier orderings to adhere to style standard
* Removed several //TODO comments
* Removed "throws CheckedException" from methods that no longer throw the 
checked exception.
* Minor refactorings: iterator loops to for-each, simplified conditionals, 
etc.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [n/a] Have you written or updated unit tests to verify your changes? 
[n/a: Non-functional changes.]

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-3472

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #730


commit 80f44577b8f1431c14934a935f6d426f28ed0dea
Author: Patrick Rhomberg 
Date:   2017-08-18T20:59:44Z

GEODE-3472: Remove a great deal of commented-out code.

* Correct imports in touched files
* Correct several misspellings
* Removed redundant modifier and specifiers
* Corrected modifier orderings to adhere to style standard
* Removed several //TODO comments
* Removed "throws CheckedException" from methods that no longer throw the 
checked exception.
* Minor refactorings: iterator loops to for-each, simplified conditionals, 
etc.

commit 7a0db737bc7327adea58a5c972ad04856850c8b7
Author: Patrick Rhomberg 
Date:   2017-08-28T20:41:19Z

GEODE-3472: Suggested changes in pull request.

* Corrected incorrect correction of a typo in Gfsh.java
* Removed dead, trivial method
* Moved constant field from MBeanJMXAdapter to its use in VMStatsMonitor

commit 1324ed15533dbf5fe95a81e214d81d2355f239fd
Author: Patrick Rhomberg 
Date:   2017-08-28T22:10:51Z

empty commit to trigger Travis.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[PurelyApplied]

Github user PurelyApplied closed the pull request at:

https://github.com/apache/geode/pull/730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[PurelyApplied]

GitHub user PurelyApplied reopened a pull request:

https://github.com/apache/geode/pull/730

GEODE-3472: Remove a great deal of commented-out code.

* Correct imports in touched files
* Correct several misspellings
* Removed redundant modifier and specifiers
* Corrected modifier orderings to adhere to style standard
* Removed several //TODO comments
* Removed "throws CheckedException" from methods that no longer throw the 
checked exception.
* Minor refactorings: iterator loops to for-each, simplified conditionals, 
etc.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [n/a] Have you written or updated unit tests to verify your changes? 
[n/a: Non-functional changes.]

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-3472

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #730


commit 80f44577b8f1431c14934a935f6d426f28ed0dea
Author: Patrick Rhomberg 
Date:   2017-08-18T20:59:44Z

GEODE-3472: Remove a great deal of commented-out code.

* Correct imports in touched files
* Correct several misspellings
* Removed redundant modifier and specifiers
* Corrected modifier orderings to adhere to style standard
* Removed several //TODO comments
* Removed "throws CheckedException" from methods that no longer throw the 
checked exception.
* Minor refactorings: iterator loops to for-each, simplified conditionals, 
etc.

commit 7a0db737bc7327adea58a5c972ad04856850c8b7
Author: Patrick Rhomberg 
Date:   2017-08-28T20:41:19Z

GEODE-3472: Suggested changes in pull request.

* Corrected incorrect correction of a typo in Gfsh.java
* Removed dead, trivial method
* Moved constant field from MBeanJMXAdapter to its use in VMStatsMonitor

commit 1324ed15533dbf5fe95a81e214d81d2355f239fd
Author: Patrick Rhomberg 
Date:   2017-08-28T22:10:51Z

empty commit to trigger Travis.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[PurelyApplied]

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r135626288
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java 
---
@@ -212,8 +211,7 @@ public static void bytesToFiles(byte[][] fileData, 
String parentDirPath, boolean
   }
 
   public static boolean isValidFileName(String filePath, String extension) 
{
-boolean isValid = true;
-return isValid;
+return true;
--- End diff --

Looks unused.  Must've just condensed the return from IntelliJ's inspection 
window and not looked too closely at this silly method.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[PurelyApplied]

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r135625955
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java
 ---
@@ -158,7 +156,7 @@
   private Thread runner;
   private boolean debugON;
   private Terminal terminal;
-  private boolean supressScriptCmdOutput;
+  private boolean suppressScriptCadOutput;
--- End diff --

IntelliJ Autocorrect strikes again!  Good catch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[PurelyApplied]

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r135625773
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
 ---
@@ -415,9 +413,8 @@ public Result toCommandResult() {
   toCommandResult_isPut(section, table);
 } else if (isRemove()) {
   toCommandResult_isRemove(section, table);
-} else if (isSelect()) {
-  // its moved to its separate method
 }
+// isSelect() moved to a separate method
--- End diff --

It was a little intentional to leave it.  In the context, I couldn't tell 
if it was actually helpful to explicitly comment that "No, we didn't forget 
about `isSelect()`", but I also didn't investigate too closely to see why 
`toCommandResult()` necessarily won't git on a select command.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134872863
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/MBeanJMXAdapter.java
 ---
@@ -72,16 +72,13 @@
   private DistributedMember distMember;
 
   /**
-   * log writer, or null if there is no distributed system available
-   */
-  // private LogWriterI18n logger = 
InternalDistributedSystem.getLoggerI18n();
-
-  /**
* public constructor
*/
 
+  public static final int VALUE_NOT_AVAILABLE = -1;
--- End diff --

Should this live in VMStatsMonitor since that's the only place it appears 
to be used?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134869226
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java
 ---
@@ -158,7 +156,7 @@
   private Thread runner;
   private boolean debugON;
   private Terminal terminal;
-  private boolean supressScriptCmdOutput;
+  private boolean suppressScriptCadOutput;
--- End diff --

This looks like a newly introduced typo :P


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134869699
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java 
---
@@ -212,8 +211,7 @@ public static void bytesToFiles(byte[][] fileData, 
String parentDirPath, boolean
   }
 
   public static boolean isValidFileName(String filePath, String extension) 
{
-boolean isValid = true;
-return isValid;
+return true;
--- End diff --

Can we just delete this method entirely?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[jaredjstewart]

Github user jaredjstewart commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134867453
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
 ---
@@ -415,9 +413,8 @@ public Result toCommandResult() {
   toCommandResult_isPut(section, table);
 } else if (isRemove()) {
   toCommandResult_isRemove(section, table);
-} else if (isSelect()) {
-  // its moved to its separate method
 }
+// isSelect() moved to a separate method
--- End diff --

Did you intended to leave this comment?  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[pdxrunner]

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134804772
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
 ---
@@ -147,11 +147,10 @@ public ResultData addAsFile(String fileName, String 
fileContents, String message
 
   public ResultData addAsFile(String fileName, byte[] data, int fileType, 
String message,
   boolean addTimeStampToName) {
-byte[] bytes = data;
--- End diff --

I stand corrected. I confused myself with past experiences with other 
languages.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[PurelyApplied]

Github user PurelyApplied commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134618712
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
 ---
@@ -147,11 +147,10 @@ public ResultData addAsFile(String fileName, String 
fileContents, String message
 
   public ResultData addAsFile(String fileName, byte[] data, int fileType, 
String message,
   boolean addTimeStampToName) {
-byte[] bytes = data;
--- End diff --

I might by projecting my Python and C expectations into my relatively new 
Java experience, but I thought this assignment wouldn't change the mutability 
of `data`.  Wouldn't this need `byte[] bytes = data.clone();` to actually 
provided immutability to `data`?  Or is Java more defensive than I realized?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[pdxrunner]

Github user pdxrunner commented on a diff in the pull request:

https://github.com/apache/geode/pull/730#discussion_r134616035
  
--- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java
 ---
@@ -147,11 +147,10 @@ public ResultData addAsFile(String fileName, String 
fileContents, String message
 
   public ResultData addAsFile(String fileName, byte[] data, int fileType, 
String message,
   boolean addTimeStampToName) {
-byte[] bytes = data;
--- End diff --

I think the contents of `data` should be treated as if it were immutable in 
this usage, so don't make this and the following change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #730: GEODE-3472: Remove a great deal of commented-out co...

[PurelyApplied]

GitHub user PurelyApplied opened a pull request:

https://github.com/apache/geode/pull/730

GEODE-3472: Remove a great deal of commented-out code.

* Correct imports in touched files
* Correct several misspellings
* Removed redundant modifier and specifiers
* Corrected modifier orderings to adhere to style standard
* Removed several //TODO comments
* Removed "throws CheckedException" from methods that no longer throw the 
checked exception.
* Minor refactorings: iterator loops to for-each, simplified conditionals, 
etc.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [n/a] Have you written or updated unit tests to verify your changes? 
[n/a: Non-functional changes.]

- [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
submit an update to your PR as soon as possible. If you need help, please 
send an
email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PurelyApplied/geode geode-3472

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #730


commit 9fb4414b363e9bbc584b67456158ad3f880e269b
Author: Patrick Rhomberg 
Date:   2017-08-18T20:59:44Z

GEODE-3472: Remove a great deal of commented-out code.

* Correct imports in touched files
* Correct several misspellings
* Removed redundant modifier and specifiers
* Corrected modifier orderings to adhere to style standard
* Removed several //TODO comments
* Removed "throws CheckedException" from methods that no longer throw the 
checked exception.
* Minor refactorings: iterator loops to for-each, simplified conditionals, 
etc.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---