Re: No more hardcoded region separators!

2020-05-28 Thread Donal Evans
; is "correct" without looking at the actual code and how it's used. From: Murtuza Boxwala Sent: Thursday, May 28, 2020 10:37 AM To: dev@geode.apache.org Subject: Re: No more hardcoded region separators! Is there any way to enforce that with some kind of LG

Re: No more hardcoded region separators!

2020-05-28 Thread Murtuza Boxwala
Is there any way to enforce that with some kind of LGTM or spotless rule? On 5/28/20, 12:46 PM, "Donal Evans" wrote: I'm happy to say that as of about 5 minutes ago, there are no uses of hardcoded "/" in region paths/names in the geode codebase, as all of them have been replaced by the

Re: No more hardcoded region separators!

2020-05-28 Thread Donal Evans
Thanks for the suggestion, Dave. I'll be sure to add something soon. From: Dave Barnes Sent: Thursday, May 28, 2020 10:32 AM To: dev@geode.apache.org Subject: Re: No more hardcoded region separators! Excellent, Donal! If you have not already done so, please

Re: No more hardcoded region separators!

2020-05-28 Thread Dave Barnes
Excellent, Donal! If you have not already done so, please consider documenting the practice you're advocating in a place where all community contributors have a chance of seeing it. Maybe https://cwiki.apache.org/confluence/display/GEODE/How+to+Contribute? On Thu, May 28, 2020 at 9:46 AM Donal

No more hardcoded region separators!

2020-05-28 Thread Donal Evans
I'm happy to say that as of about 5 minutes ago, there are no uses of hardcoded "/" in region paths/names in the geode codebase, as all of them have been replaced by the Region.SEPARATOR constant (with the exception of a few occurrences in the geode-management module, which while not having an