Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

2017-04-25 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58238/#review172978 --- Fix it, then Ship it! Fix and Ship!

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

2017-04-25 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58238/#review172976 --- Ship it! Ship It! - Patrick Rhomberg On April 6, 2017, 9:12

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

2017-04-06 Thread Jinmei Liao
> On April 6, 2017, 11:07 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java > > Line 56 (original), 53 (patched) > > > > > >

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

2017-04-06 Thread Jared Stewart
> On April 6, 2017, 11:07 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java > > Line 56 (original), 53 (patched) > > > > > >

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

2017-04-06 Thread Jinmei Liao
> On April 6, 2017, 11:07 p.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/management/internal/web/controllers/support/LoginHandlerInterceptor.java > > Line 56 (original), 53 (patched) > > > > > >

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

2017-04-06 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58238/#review171269 --- Ship it! Ship It! - Jared Stewart On April 6, 2017, 9:12

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

2017-04-06 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58238/#review171268 ---

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

2017-04-06 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58238/ --- (Updated April 6, 2017, 9:12 p.m.) Review request for geode, Jared Stewart,

Re: Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

2017-04-06 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58238/#review171229 --- Ship it! Ship It! - Kirk Lund On April 6, 2017, 4:52 p.m.,

Review Request 58238: GEODE-2756: Do not put security-* properties in the env.

2017-04-06 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58238/ --- Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick