Re: Review Request 34814: GEODE-38. Gfsh init script ignored

2015-05-29 Thread Roman Shaposhnik
Done! On Fri, May 29, 2015 at 8:52 AM, Roman Shaposhnik r...@apache.org wrote: Yeah that seems to have been a typo in a config. Let me look into this... Thanks, Roman. On Fri, May 29, 2015 at 8:41 AM, Anthony Baker aba...@pivotal.io wrote: The link in this email is incorrect…should be

Re: Review Request 34814: GEODE-38. Gfsh init script ignored

2015-05-29 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34814/#review85742 --- This looks good, with the exception that I think there needs to be

Re: Review Request 34814: GEODE-38. Gfsh init script ignored

2015-05-29 Thread Anthony Baker
The link in this email is incorrect…should be “issues.apache.org” not “issue.apache.org”. Any idea how to fix it? Anthony On May 29, 2015, at 8:39 AM, Roman Shaposhnik r...@apache.org wrote: --- This is an automatically

Review Request 34814: GEODE-38. Gfsh init script ignored

2015-05-29 Thread Roman Shaposhnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34814/ --- Review request for geode. Repository: geode Description --- Gfsh

Re: Review Request 34814: GEODE-38. Gfsh init script ignored

2015-05-29 Thread Kirk Lund
1) System Rules for JUnit 4 I really like System Rules for JUnit 4. This library has been added to our build on GitLabs develop but not in ASF git yet http://stefanbirkner.github.io/system-rules/. This line resets all System Properties changes you make in your tests: @Rule public final

Re: Review Request 34814: GEODE-38. Gfsh init script ignored

2015-05-29 Thread Roman Shaposhnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34814/ --- (Updated May 29, 2015, 3:39 p.m.) Review request for geode. Bugs: GEODE-38

Geode is now available on reviewboard

2015-05-29 Thread Roman Shaposhnik
Hi! last bit of infrastructure is finally in place: https://reviews.apache.org/groups/geode/ At this point reviewers of any proposed changes have three options: 0. Review patches as they are attached to JIRA 1. Ask for a Github pull request 2. Ask for a Reviewboard submission #0 is

Re: Bringing geode website into the project

2015-05-29 Thread David Yozie
On Thu, May 28, 2015 at 6:34 PM, Roman Shaposhnik ro...@shaposhnik.org wrote: On Thu, May 28, 2015 at 8:53 AM, David Yozie dyo...@pivotal.io wrote: If we want to continue using the same publishing system we should probably manage the end-user docs source in a separate branch of whatever repo

Re: Code contributions wiki page

2015-05-29 Thread Vincent Ford
Hi, In step (1) you may want to have a pointer to the github documentation on how-to fork a project there say something along the lines of For additional details on forking a project using github see the following url . You may also want in step (14) to point to the page for any requirements

Re: Review Request 34814: GEODE-38. Gfsh init script ignored

2015-05-29 Thread Darrel Schneider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34814/#review85760 --- Please clean up the indentation. Two spaces should be used for each