Re: Review Request 50715: GEODE-1128: Fixes for colocation configuration problems

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50715/#review146054 ---

Re: git commit messages

Yeah, 50 chars seems a bit short. I think I've been aiming for 72 personally. -Dan On Wed, Aug 17, 2016 at 4:37 PM, Kirk Lund wrote: > Some examples from feature/GEODE-1781-02 which are my latest unmerged > commits... > > 1) 1st line is 62 chars. To shorten to 50:

Re: git commit messages

Agree with Kirk, 50 chars is really short by the time you use up the first 12 characters for the Jira tag. If we’re going to have a guideline, I’d rather be longer - somewhat arbitrarily I’d probably make it 20-30 chars more. It’s been a long time since text listings were intended to fit on a

Re: git commit messages

To me, having a meaningful short summary line is still pretty useful. I use git oneline and github and my ide also use that summary line. -Dan On Wed, Aug 17, 2016 at 3:45 PM, Kevin Duling wrote: > The format is very similar to the one most other git shops I've worked in

Re: Review Request 50715: GEODE-1128: Fixes for colocation configuration problems

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50715/ --- (Updated Aug. 17, 2016, 11:12 p.m.) Review request for geode, Darrel

Re: git commit messages

The format is very similar to the one most other git shops I've worked in before use. I don't believe we ever had formal length limits. Typically, it was: -: > blank line The Atlassian plugin for IDEA automates a lot of this. There are limits on the length of a jira ticket summary,

Re: git commit messages

50 chars including "GEODE-: " is awfully short. http://chris.beams.io/posts/git-commit/ does say that's just a general rule of thumb and not a hard limit. The author's reasoning seems to be specifically for using "git log --oneline" -- does anyone use that option with git log? I don't. I

Fwd: git commit messages

Here's the git commit message guidelines we discussed and voted on last year. I just checked and my own git commit message line lengths have grown beyond what we decided to use. Most other are also not following this guideline. Here's the list of folks who voted last year along with their vote:

Re: Geode Clubhouse TOMORROW Thursday, Aug 18, 9AM Pacific: What's New with Spring Data Geode

Dear Geode Community, Just reminding you about tomorrow's Geode Clubhouse at 9AM Pacific: Join here | Add reminder to Calendar

Re: Review Request 51188: GEODE-1776: Always read all of the results in ExecuteRegionFunctionOp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51188/#review146033 --- Ship it! Ship It! - Barry Oglesby On Aug. 17, 2016, 5:41

Re: Flaky tests failing with BindException

The membership-port-range changes have been checked in for a while now. Le 8/17/2016 à 10:51 AM, Kirk Lund a écrit : Have we made all of the changes that we think will help prevent BindException failures? Last night's nightly build failed with one again: :geode-core:flakyTest

Re: Flaky tests failing with BindException

Have we made all of the changes that we think will help prevent BindException failures? Last night's nightly build failed with one again: :geode-core:flakyTest com.gemstone.gemfire.security.ClientAuthenticationDUnitTest > testCredentialsForNotifications FAILED

Re: Review Request 51183: GEODE-67: fix nonTxnFindObject for partitioned region

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51183/#review146009 --- Ship it! Ship It! - Ken Howe On Aug. 17, 2016, 4:56 p.m.,

Review Request 51187: GEODE-1760 Sending partial results to user's ResultCollector

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51187/ --- Review request for geode and Barry Oglesby. Repository: geode Description

Review Request 51188: GEODE-1776: Always read all of the results in ExecuteRegionFunctionOp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51188/ --- Review request for geode and Barry Oglesby. Repository: geode Description

Review Request 51186: GEODE-1760, GEODE-1762: Tests of function exceptions from clients

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51186/ --- Review request for geode and Barry Oglesby. Repository: geode Description

Review Request 51183: GEODE-67: fix nonTxnFindObject for partitioned region

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51183/ --- Review request for geode, Eric Shu, Scott Jewell, and Ken Howe. Bugs: GEODE-67