[GitHub] incubator-geode issue #177: GEODE-11: Index and AEQ stored in the same disk ...

[gesterzhou]

Github user gesterzhou commented on the issue:

https://github.com/apache/incubator-geode/pull/177
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #183: GEODE-1615: gfsh unable to destroy region that h...

[jinmeiliao]

Github user jinmeiliao commented on the issue:

https://github.com/apache/incubator-geode/pull/183
  
the fix looks good. Where is the test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Geode website tagged with minor Apache branding issue in audit

[Greg Chase]

Dear Geode community,
I see the Apache Geode website got tagged with a minor branding concern in
a recent audit of incubating projects.

See the wiki entry here:
https://wiki.apache.org/incubator/BrandingAuditJune2016

See start of the thread in gene...@incubator.apache.org here:
http://mail-archives.apache.org/mod_mbox/incubator-general/201606.mbox/%3CCAOqetn-c49sfXSMck8hx%3DjGZQEw6paEmbdtMg32meLkHKcTPnQ%40mail.gmail.com%3E

Basically the Apache & Apache incubator logos, and the incubator disclaimer
are not prominent enough, but at least they are present.

Next time we look at a website update, we might see how we can make these
more obvious.

Suggestions are welcome on this thread.

-Greg

Re: Valid characters in region names?

[William Markito]

We already discussed this on the previous thread and got general consensus
on getting "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz12345678
90_-" for Geode...  Anything other than this can be problematic for JMX and
other components that will then require special treatment to handle unusual
chars.

If any user is coming from GemFire , they still can use snapshots to
export/import data into the new regions.

I'd also recommend enforcing the rules for region creation in all possible
APIs, for consistency...  (GFSH, cache.xml, RegionFactory...)

On Thu, Jun 30, 2016 at 4:49 PM, Anilkumar Gingade 
wrote:

> Here is what GemFire docs states about region names:
>
>
> http://gemfire.docs.pivotal.io/docs-gemfire/latest/basic_config/data_regions/region_naming.html
>
> But again, we have supported other chars as part of region names...
>
> The Query engine allows/detects region name with:  "_", “+”, “-“, “:”, “#”,
> “@“, “$”.
>
> -Anil.
>
>
>
>
> On Thu, Jun 30, 2016 at 11:03 AM, Kevin Duling  wrote:
>
> > I'm working on a bug where it is not possible to delete a region that
> has a
> > hyphen in it.  E.g., the region was created with:
> >
> > create region --name=not-good --type=REPLICATE
> >
> > I've a solution done, but see this as an opportunity to add a test for
> > other special characters.  Is there a list of valid and invalid
> characters
> > for a region name?
> >
>



-- 

~/William

Re: update website for WAN, CQ and native client

[Swapnil Bawaskar]

Thanks everyone for chiming in!
These change have been pushed. checkout: http://geode.incubator.apache.org/


On Wed, Jun 22, 2016 at 11:34 AM, Udo Kohlmeyer 
wrote:

> +1,
>
> to me "Multi-site" is too rigid. People might forget that this is a
> inter-cluster comms channel. Which would allow them to have many clusters
> running in the same DC, sharing data between them, satisfying the data
> requirements for different systems/applications.
>
>
>
> On 22/06/2016 4:54 AM, Gregory Chase wrote:
>
>> I'm +0 to "Multi-site", but like "multi-cluster" slightly better for two
>> reasons...
>>
>> 1) It comes after "Clustering", showing a ++ more clearly
>> 2) In my opinion its more inclusive of both "multi-site" and also workload
>> partitioning where two clusters might be in the same data center, but have
>> different applications they serve.
>>
>> Thoughts?
>>
>> On Tue, Jun 21, 2016 at 11:49 AM, John Blum  wrote:
>>
>> +1
>>>
>>> On Tue, Jun 21, 2016 at 11:43 AM, Swapnil Bawaskar >> >
>>> wrote:
>>>
>>> Take 3: http://i.imgur.com/VUQRw4u.png
 1. Replaced Redis logo with http://fontawesome.io/icon/plug/
 2. Changed WAN to Multi-Site.

 Thanks!
 Swapnil.

 On Sat, Jun 18, 2016 at 7:22 PM, theseusyang 
 wrote:

 I agree with Greg, "Multi-Cluster"  is accurated especially for
> cluster-2-cluster replication in one DC site.
>
>
>
> --
> View this message in context:
>
>
>>> http://apache-geode-incubating-developers-forum.70738.x6.nabble.com/update-website-for-WAN-CQ-and-native-client-tp6659p6763.html
>>>
 Sent from the Apache Geode (Incubating) Developers Forum mailing list
> archive at Nabble.com.
>
>
>>>
>>> --
>>> -John
>>> 503-504-8657
>>> john.blum10101 (skype)
>>>
>>>
>>
>>
>

[GitHub] incubator-geode pull request #177: GEODE-11: Index and AEQ stored in the sam...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/incubator-geode/pull/177#discussion_r69231478
  
--- Diff: 
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
 ---
@@ -77,13 +77,13 @@ public void initialize() {
   final String fileRegionName = createFileRegionName();
   PartitionAttributes partitionAttributes = 
dataRegion.getPartitionAttributes();
   if (!fileRegionExists(fileRegionName)) {
-fileRegion = createFileRegion(regionShortCut, fileRegionName, 
partitionAttributes);
+fileRegion = createFileRegion(regionShortCut, fileRegionName, 
partitionAttributes, ra);
--- End diff --

Its a nitpicky stuff but can we rename ra as regionAttributes. Just to keep 
things uniform... all other variables have full explanation names like 
regionShortcut, fileRegionName but just "ra" is the extra short one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #177: GEODE-11: Index and AEQ stored in the same disk ...

[nabarunnag]

Github user nabarunnag commented on the issue:

https://github.com/apache/incubator-geode/pull/177
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 49481: summarize the investigation results on numeric field range query into a integration test case

[xiaojian zhou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49481/
---

Review request for geode, anilkumar gingade and Dan Smith.


Bugs: GEODE-11
https://issues.apache.org/jira/browse/GEODE-11


Repository: geode


Description
---

The code case archived following conclusions related with research on range 
query
1) lucene's QueryParser does not work for numeric range query
2) Need a IntPoint.newRangeQuery to do numeric range query for int field. 
Similar for float, double and long fields.
3) If field has 2 values with different types, lucene will throw IAE. 
4) Define a sample implementation for LuceneQueryProvider. This can also be 
used for demo or sample code for customer in the future.


Diffs
-

  
geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneQueryFactoryImpl.java
 62b4f56 
  
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java
 988e4f5 

Diff: https://reviews.apache.org/r/49481/diff/


Testing
---


Thanks,

xiaojian zhou

Re: Valid characters in region names?

[Anilkumar Gingade]

Here is what GemFire docs states about region names:

http://gemfire.docs.pivotal.io/docs-gemfire/latest/basic_config/data_regions/region_naming.html

But again, we have supported other chars as part of region names...

The Query engine allows/detects region name with:  "_", “+”, “-“, “:”, “#”,
“@“, “$”.

-Anil.




On Thu, Jun 30, 2016 at 11:03 AM, Kevin Duling  wrote:

> I'm working on a bug where it is not possible to delete a region that has a
> hyphen in it.  E.g., the region was created with:
>
> create region --name=not-good --type=REPLICATE
>
> I've a solution done, but see this as an opportunity to add a test for
> other special characters.  Is there a list of valid and invalid characters
> for a region name?
>

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

[nabarun nag]

> On June 30, 2016, 11:14 p.m., nabarun nag wrote:
> > geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java,
> >  line 303
> > 
> >
> > Hi Jason, 
> > While debugging this ticket we found out that the boolean 
> > startAckReaderThread is completely ignore by the method getConnection. 
> > Should we make use of it in line 329 
> > if (this.ackReaderThread == null || !this.ackReaderThread.isRunning())
> > 
> > Or refactor the method signature.

Sorry, i dont know what the protocol is for "open" issue. Checked it by mistake 
and I can't edit it


- nabarun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49102/#review140264
---


On June 22, 2016, 5:52 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49102/
> ---
> 
> (Updated June 22, 2016, 5:52 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> When closing a sender, the close connection message is sent on the same 
> connection that is used by the ack reader thread.  This causes an issue as 
> two threads are now reading off the same socket concurrently.  The fix is to 
> prevent this from happening but to do so, the input stream needs to be closed 
> (to free up from a socket read()).  
> The dispatcher also needs to shut down before the close connection is sent 
> out or it will spawn off another ack reader thread.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
>  ce08e8d 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderEventProcessor.java
>  07a3be5 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessor.java
>  ff810ec 
>   
> geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
>  b178192 
> 
> Diff: https://reviews.apache.org/r/49102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49102/#review140264
---




geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
 (line 303)


Hi Jason, 
While debugging this ticket we found out that the boolean 
startAckReaderThread is completely ignore by the method getConnection. 
Should we make use of it in line 329 
if (this.ackReaderThread == null || !this.ackReaderThread.isRunning())

Or refactor the method signature.


- nabarun nag


On June 22, 2016, 5:52 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49102/
> ---
> 
> (Updated June 22, 2016, 5:52 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> When closing a sender, the close connection message is sent on the same 
> connection that is used by the ack reader thread.  This causes an issue as 
> two threads are now reading off the same socket concurrently.  The fix is to 
> prevent this from happening but to do so, the input stream needs to be closed 
> (to free up from a socket read()).  
> The dispatcher also needs to shut down before the close connection is sent 
> out or it will spawn off another ack reader thread.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
>  ce08e8d 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderEventProcessor.java
>  07a3be5 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessor.java
>  ff810ec 
>   
> geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
>  b178192 
> 
> Diff: https://reviews.apache.org/r/49102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

[GitHub] incubator-geode pull request #184: GEODE-1452 Add @Ignore to disabled tests

[gracemeilen]

GitHub user gracemeilen opened a pull request:

https://github.com/apache/incubator-geode/pull/184

GEODE-1452 Add @Ignore to disabled tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gracemeilen/incubator-geode 
feature/GEODE-1452-3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/184.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #184


commit d008a428b8e92ba454cfc4f7022559d394c9c1b4
Author: gmeilen 
Date:   2016-06-30T23:11:12Z

GEODE-1452 Add @Ignore to disabled tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 49471: GEODE-1374: Flaky tests will now have junit xml recorded into seperate directory

[nabarun nag]

> On June 30, 2016, 11:06 p.m., nabarun nag wrote:
> > Ship It!

Change made in Jenkins Precheckin to pick up the new folder.


- nabarun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49471/#review140261
---


On June 30, 2016, 8:50 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49471/
> ---
> 
> (Updated June 30, 2016, 8:50 p.m.)
> 
> 
> Review request for geode, Kirk Lund, nabarun nag, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Flaky xml results were overwriting non flaky test results that had the same 
> FQCN
> We now can write these xml results into their own directory and have jenkins 
> crawl this new folder as well
> 
> 
> Diffs
> -
> 
>   gradle/test.gradle eb10cad 
> 
> Diff: https://reviews.apache.org/r/49471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: Review Request 49471: GEODE-1374: Flaky tests will now have junit xml recorded into seperate directory

[nabarun nag]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49471/#review140261
---


Ship it!




Ship It!

- nabarun nag


On June 30, 2016, 8:50 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49471/
> ---
> 
> (Updated June 30, 2016, 8:50 p.m.)
> 
> 
> Review request for geode, Kirk Lund, nabarun nag, and Dan Smith.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Flaky xml results were overwriting non flaky test results that had the same 
> FQCN
> We now can write these xml results into their own directory and have jenkins 
> crawl this new folder as well
> 
> 
> Diffs
> -
> 
>   gradle/test.gradle eb10cad 
> 
> Diff: https://reviews.apache.org/r/49471/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

Re: [INFO REQUEST] Uploading the podling report

[Nabarun Nag]

Thanks Swapnil. Email sent.

On Thu, Jun 30, 2016 at 3:51 PM Swapnil Bawaskar 
wrote:

> Send an email to gene...@incubator.apache.org asking for permissions to
> the
> wiki for uploading the podling report.
>
> On Thu, Jun 30, 2016 at 3:19 PM, Nabarun Nag  wrote:
>
> > Hi,
> >
> > Thank you all for the reviews.
> >
> > Can someone please tell me the steps to append the podling report to
> > http://wiki.apache.org/incubator/July2016.
> >
> >
> > Regards
> > Nabarun Nag
> >
>

Re: [INFO REQUEST] Uploading the podling report

[Swapnil Bawaskar]

Send an email to gene...@incubator.apache.org asking for permissions to the
wiki for uploading the podling report.

On Thu, Jun 30, 2016 at 3:19 PM, Nabarun Nag  wrote:

> Hi,
>
> Thank you all for the reviews.
>
> Can someone please tell me the steps to append the podling report to
> http://wiki.apache.org/incubator/July2016.
>
>
> Regards
> Nabarun Nag
>

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #356 was SUCCESSFUL (with 1410 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #356 was successful.
---
Scheduled
1412 tests in total.

https://build.spring.io/browse/SGF-NAG-356/





--
This message is automatically generated by Atlassian Bamboo

Re: Valid characters in region names?

[Karen Miller]

Here is the page of the documentation on region naming:

http://docs-geode-develop.cfapps.io/docs/basic_config/data_regions/region_naming.html

I'm guessing that a JIRA for also including a dash was not implemented.
When you find the
JIRA number, please post it on this thread.


On Thu, Jun 30, 2016 at 12:57 PM, Kevin Duling  wrote:

> Do you know if a Jira ticket was opened on it?  I'm currently working on
> https://issues.apache.org/jira/browse/GEODE-1615 and would like to link to
> it.
>
> On Thu, Jun 30, 2016 at 12:38 PM, Michael Stolz  wrote:
>
> > Yes we did discuss adding hyphen in Geode, and we discussed actually
> > checking during create.
> >
> > --
> > Mike Stolz
> > Principal Engineer, GemFire Product Manager
> > Mobile: 631-835-4771
> >
> > On Thu, Jun 30, 2016 at 3:30 PM, Kevin Duling 
> wrote:
> >
> > > I found a thread from March of this year where this was discussed and
> '-'
> > > is also included in that list.
> > >
> > > Shouldn't the creation of a region with an invalid character raise an
> > > exception?  I'm finding that I can create and list regions with a
> variety
> > > of non-alphanumeric characters.  But I can only destroy a subset of
> > those.
> > >
> > >  It appears to be because some are created with quotes around the
> region
> > > name.
> > >
> > > E.g.,
> > >
> > > service=Region, name=/good, type=Member
> > > service=Region, name="/not*good", type=Member
> > >
> > > The name lookup fails in the Destroy call.  The rule that applied the
> > > quotes for /not*good during Create isn't applied in Destroy
> > >
> > > On Thu, Jun 30, 2016 at 12:06 PM, Michael Stolz 
> > wrote:
> > >
> > > > The only characters that should be used in Region names are
> > > > ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890_
> > > >
> > > > --
> > > > Mike Stolz
> > > > Principal Engineer, GemFire Product Manager
> > > > Mobile: 631-835-4771
> > > >
> > > > On Thu, Jun 30, 2016 at 2:03 PM, Kevin Duling 
> > > wrote:
> > > >
> > > > > I'm working on a bug where it is not possible to delete a region
> that
> > > > has a
> > > > > hyphen in it.  E.g., the region was created with:
> > > > >
> > > > > create region --name=not-good --type=REPLICATE
> > > > >
> > > > > I've a solution done, but see this as an opportunity to add a test
> > for
> > > > > other special characters.  Is there a list of valid and invalid
> > > > characters
> > > > > for a region name?
> > > > >
> > > >
> > >
> >
>

[INFO REQUEST] Uploading the podling report

[Nabarun Nag]

Hi,

Thank you all for the reviews.

Can someone please tell me the steps to append the podling report to
http://wiki.apache.org/incubator/July2016.


Regards
Nabarun Nag

[GitHub] incubator-geode pull request #183: GEODE-1615: gfsh unable to destroy region...

[kjduling]

GitHub user kjduling opened a pull request:

https://github.com/apache/incubator-geode/pull/183

GEODE-1615: gfsh unable to destroy region that has an hyphen in its name

Added a test for whether or not the region contains a hyphen in the name.  
If it does, it is necessary to wrap the region name within quotes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjduling/incubator-geode feature/GEODE-1615

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #183


commit 80af962ef2f7eee4053804a20a28f41b46fb3192
Author: Kevin J. Duling 
Date:   2016-06-30T22:07:22Z

GEODE-1615: gfsh unable to destroy region that has an hyphen in its name




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #182: GEODE-1566: rename GeodeRedisServer and r...

[gracemeilen]

GitHub user gracemeilen opened a pull request:

https://github.com/apache/incubator-geode/pull/182

GEODE-1566: rename GeodeRedisServer and repackage in org.apache.geode



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gracemeilen/incubator-geode feature/GEODE-1566

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #182


commit 03c75c04e2c459da9d18cd85d24b68ad61546f5d
Author: gmeilen 
Date:   2016-06-30T22:01:32Z

GEODE-1566: rename GeodeRedisServer and repackage redis code into 
org.apache.geode




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Review Request 49471: GEODE-1374: Flaky tests will now have junit xml recorded into seperate directory

[Jason Huynh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49471/
---

Review request for geode, Kirk Lund, nabarun nag, and Dan Smith.


Repository: geode


Description
---

Flaky xml results were overwriting non flaky test results that had the same FQCN
We now can write these xml results into their own directory and have jenkins 
crawl this new folder as well


Diffs
-

  gradle/test.gradle eb10cad 

Diff: https://reviews.apache.org/r/49471/diff/


Testing
---


Thanks,

Jason Huynh

Re: Valid characters in region names?

[Kevin Duling]

Do you know if a Jira ticket was opened on it?  I'm currently working on
https://issues.apache.org/jira/browse/GEODE-1615 and would like to link to
it.

On Thu, Jun 30, 2016 at 12:38 PM, Michael Stolz  wrote:

> Yes we did discuss adding hyphen in Geode, and we discussed actually
> checking during create.
>
> --
> Mike Stolz
> Principal Engineer, GemFire Product Manager
> Mobile: 631-835-4771
>
> On Thu, Jun 30, 2016 at 3:30 PM, Kevin Duling  wrote:
>
> > I found a thread from March of this year where this was discussed and '-'
> > is also included in that list.
> >
> > Shouldn't the creation of a region with an invalid character raise an
> > exception?  I'm finding that I can create and list regions with a variety
> > of non-alphanumeric characters.  But I can only destroy a subset of
> those.
> >
> >  It appears to be because some are created with quotes around the region
> > name.
> >
> > E.g.,
> >
> > service=Region, name=/good, type=Member
> > service=Region, name="/not*good", type=Member
> >
> > The name lookup fails in the Destroy call.  The rule that applied the
> > quotes for /not*good during Create isn't applied in Destroy
> >
> > On Thu, Jun 30, 2016 at 12:06 PM, Michael Stolz 
> wrote:
> >
> > > The only characters that should be used in Region names are
> > > ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890_
> > >
> > > --
> > > Mike Stolz
> > > Principal Engineer, GemFire Product Manager
> > > Mobile: 631-835-4771
> > >
> > > On Thu, Jun 30, 2016 at 2:03 PM, Kevin Duling 
> > wrote:
> > >
> > > > I'm working on a bug where it is not possible to delete a region that
> > > has a
> > > > hyphen in it.  E.g., the region was created with:
> > > >
> > > > create region --name=not-good --type=REPLICATE
> > > >
> > > > I've a solution done, but see this as an opportunity to add a test
> for
> > > > other special characters.  Is there a list of valid and invalid
> > > characters
> > > > for a region name?
> > > >
> > >
> >
>

Re: Valid characters in region names?

[Michael Stolz]

Yes we did discuss adding hyphen in Geode, and we discussed actually
checking during create.

--
Mike Stolz
Principal Engineer, GemFire Product Manager
Mobile: 631-835-4771

On Thu, Jun 30, 2016 at 3:30 PM, Kevin Duling  wrote:

> I found a thread from March of this year where this was discussed and '-'
> is also included in that list.
>
> Shouldn't the creation of a region with an invalid character raise an
> exception?  I'm finding that I can create and list regions with a variety
> of non-alphanumeric characters.  But I can only destroy a subset of those.
>
>  It appears to be because some are created with quotes around the region
> name.
>
> E.g.,
>
> service=Region, name=/good, type=Member
> service=Region, name="/not*good", type=Member
>
> The name lookup fails in the Destroy call.  The rule that applied the
> quotes for /not*good during Create isn't applied in Destroy
>
> On Thu, Jun 30, 2016 at 12:06 PM, Michael Stolz  wrote:
>
> > The only characters that should be used in Region names are
> > ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890_
> >
> > --
> > Mike Stolz
> > Principal Engineer, GemFire Product Manager
> > Mobile: 631-835-4771
> >
> > On Thu, Jun 30, 2016 at 2:03 PM, Kevin Duling 
> wrote:
> >
> > > I'm working on a bug where it is not possible to delete a region that
> > has a
> > > hyphen in it.  E.g., the region was created with:
> > >
> > > create region --name=not-good --type=REPLICATE
> > >
> > > I've a solution done, but see this as an opportunity to add a test for
> > > other special characters.  Is there a list of valid and invalid
> > characters
> > > for a region name?
> > >
> >
>

Re: Valid characters in region names?

[Kevin Duling]

I found a thread from March of this year where this was discussed and '-'
is also included in that list.

Shouldn't the creation of a region with an invalid character raise an
exception?  I'm finding that I can create and list regions with a variety
of non-alphanumeric characters.  But I can only destroy a subset of those.

 It appears to be because some are created with quotes around the region
name.

E.g.,

service=Region, name=/good, type=Member
service=Region, name="/not*good", type=Member

The name lookup fails in the Destroy call.  The rule that applied the
quotes for /not*good during Create isn't applied in Destroy

On Thu, Jun 30, 2016 at 12:06 PM, Michael Stolz  wrote:

> The only characters that should be used in Region names are
> ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz1234567890_
>
> --
> Mike Stolz
> Principal Engineer, GemFire Product Manager
> Mobile: 631-835-4771
>
> On Thu, Jun 30, 2016 at 2:03 PM, Kevin Duling  wrote:
>
> > I'm working on a bug where it is not possible to delete a region that
> has a
> > hyphen in it.  E.g., the region was created with:
> >
> > create region --name=not-good --type=REPLICATE
> >
> > I've a solution done, but see this as an opportunity to add a test for
> > other special characters.  Is there a list of valid and invalid
> characters
> > for a region name?
> >
>

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

[Jason Huynh]

> On June 29, 2016, 9:02 p.m., anilkumar gingade wrote:
> > Nice to have unit test for this.

Agreed, however this would require quite a few test hooks in product code.  
There are multiple scenarios that can cause this issue.  I've inserted a "test 
case" to the ticket that will reproduce the issue without test hooks but it 
would not really be a test I would want to check in.

The problem is that there are multiple scenarios that can cause this to occur.  
Three different threads that would need to have test hooks to sync each other 
at specific points.   The ack reader thread can be stuck on a socket read() or 
it can have already processed the header for the read, or it could be 
interrupted right before the read or it could be dead.  All the while the 
dispatcher thread could be running and spawn a new ack reader thread (if it 
were dead) on a new connection or sending off a new batch.  The gateway stopper 
thread could possibly send a close connectio on the old socket or if the ack 
reader thread was recreated, it would send on the new socket. 

All those scenarios now are invalid... we have changed the shut down to 
shutdown the dispatcher thread (not allowing it to spawn a new ack reader 
thread if it's shutting down).  The connection is also being closed which will 
force the ack reader to break out of the read() or prevent it from reading 
anything else from the input stream.  All the new test hooks would be added and 
some of these scenarios are now unable to be hit.


- Jason


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49102/#review140051
---


On June 22, 2016, 5:52 p.m., Jason Huynh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49102/
> ---
> 
> (Updated June 22, 2016, 5:52 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan 
> Smith, and xiaojian zhou.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> When closing a sender, the close connection message is sent on the same 
> connection that is used by the ack reader thread.  This causes an issue as 
> two threads are now reading off the same socket concurrently.  The fix is to 
> prevent this from happening but to do so, the input stream needs to be closed 
> (to free up from a socket read()).  
> The dispatcher also needs to shut down before the close connection is sent 
> out or it will spawn off another ack reader thread.
> 
> 
> Diffs
> -
> 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java
>  ce08e8d 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderEventProcessor.java
>  07a3be5 
>   
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessor.java
>  ff810ec 
>   
> geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
>  b178192 
> 
> Diff: https://reviews.apache.org/r/49102/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Huynh
> 
>

[GitHub] incubator-geode pull request #181: GEODE-1598 Fixed autocomplete for first o...

[gracemeilen]

GitHub user gracemeilen opened a pull request:

https://github.com/apache/incubator-geode/pull/181

GEODE-1598 Fixed autocomplete for first option



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gracemeilen/incubator-geode 
feature/GEODE-1598-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-geode/pull/181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #181


commit 3fbe800a3f0db1eaa9cc7cff34d2610cc72bb066
Author: gmeilen 
Date:   2016-06-30T18:52:35Z

GEODE-1598 Fixed autocomplete for first option




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #180: GEODE-1598 Fixed autocomplete for first o...

[gracemeilen]

Github user gracemeilen closed the pull request at:

https://github.com/apache/incubator-geode/pull/180


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: Geode-nightly #515

[Apache Jenkins Server]

See 

Changes:

[klund] GEODE-1598: avoid deletion of options during GFSH autocomplete

[upthewaterspout] GEODE-11: Cleaning up old IndexRepositoryImpls when buckets 
move

--
[...truncated 536 lines...]
:geode-web:javadoc UP-TO-DATE
:geode-web:javadocJar
:geode-web:sourcesJar
:geode-web:war
:geode-web:signArchives SKIPPED
:geode-web-api:jar
:geode-web-api:javadoc
:geode-web-api:javadocJar
:geode-web-api:sourcesJar
:geode-web-api:war
:geode-web-api:signArchives SKIPPED
:geode-assembly:distTar
:geode-assembly:distZip
:geode-assembly:writeBuildInfo
:geode-assembly:srcDistTar
:geode-assembly:srcDistZip
:geode-assembly:signArchives SKIPPED
:geode-assembly:assemble
:geode-assembly:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-assembly:processTestResources
:geode-assembly:testClasses
:geode-assembly:checkMissedTests
:geode-assembly:installDist
:geode-assembly:test
:geode-assembly:check
:geode-assembly:build
:geode-assembly:distributedTest
:geode-assembly:flakyTest
:geode-assembly:integrationTest
:geode-common:assemble
:geode-common:compileTestJava
:geode-common:processTestResources UP-TO-DATE
:geode-common:testClasses
:geode-common:checkMissedTests
:geode-common:test
:geode-common:check
:geode-common:build
:geode-common:distributedTest
:geode-common:flakyTest
:geode-common:integrationTest
:geode-core:assemble
:geode-core:checkMissedTests
:geode-core:test
:geode-core:check
:geode-core:build
:geode-core:distributedTest
:geode-core:flakyTest

com.gemstone.gemfire.cache.query.internal.index.InitializeIndexEntryDestroyQueryDUnitTest
 > testAsyncIndexInitDuringEntryDestroyAndQueryOnPR FAILED
java.lang.AssertionError: asyInvk0 failed
at com.gemstone.gemfire.test.dunit.Assert.fail(Assert.java:64)
at 
com.gemstone.gemfire.cache.query.internal.index.InitializeIndexEntryDestroyQueryDUnitTest.testAsyncIndexInitDuringEntryDestroyAndQueryOnPR(InitializeIndexEntryDestroyQueryDUnitTest.java:340)

Caused by:
java.lang.AssertionError: Index creation failed

Caused by:
com.gemstone.gemfire.cache.query.IndexNameConflictException: Index 
named ' statusIndex ' already exists.

187 tests completed, 1 failed, 6 skipped
:geode-core:flakyTest FAILED
:geode-core:integrationTest
:geode-cq:assemble
:geode-cq:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-cq:processTestResources
:geode-cq:testClasses
:geode-cq:checkMissedTests
:geode-cq:test
:geode-cq:check
:geode-cq:build
:geode-cq:distributedTest
:geode-cq:flakyTest
:geode-cq:integrationTest
:geode-json:assemble
:geode-json:compileTestJava UP-TO-DATE
:geode-json:processTestResources UP-TO-DATE
:geode-json:testClasses UP-TO-DATE
:geode-json:checkMissedTests UP-TO-DATE
:geode-json:test UP-TO-DATE
:geode-json:check
:geode-json:build
:geode-json:distributedTest UP-TO-DATE
:geode-json:flakyTest UP-TO-DATE
:geode-json:integrationTest UP-TO-DATE
:geode-junit:javadoc
:geode-junit:javadocJar
:geode-junit:sourcesJar
:geode-junit:signArchives SKIPPED
:geode-junit:assemble
:geode-junit:compileTestJava
:geode-junit:processTestResources UP-TO-DATE
:geode-junit:testClasses
:geode-junit:checkMissedTests
:geode-junit:test
:geode-junit:check
:geode-junit:build
:geode-junit:distributedTest
:geode-junit:flakyTest
:geode-junit:integrationTest
:geode-lucene:assemble
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:jar
:geode-rebalancer:javadoc
:geode-rebalancer:javadocJar
:geode-rebalancer:sourcesJar