Review Request 53752: Removing the Flaky Tag

/misc/WanAutoDiscoveryDUnitTest.java 388760e Diff: https://reviews.apache.org/r/53752/diff/ Testing --- Ran it for multiple iterations. Thanks, nabarun nag

Re: Build failed in Jenkins: Geode-nightly #647

spotlessApply added to DiskSpaceLimitIntegrationTest.java and pushed to develop. - local build was successful with no error. On Tue, Nov 8, 2016 at 8:06 AM Nabarun Nag <n...@pivotal.io> wrote: > Fixing it. > On Tue, Nov 8, 2016 at 7:48 AM Apache Jenkins Server < > jenk...

Re: more spotless problems on Windows

s you add a .gitattributes file to tell git "forget the > platform, do what this file says". > >> > >> Remove lineEndings 'UNIX' in your build.gradle [Jared - we should put > ‘GIT_ATTRIBUTES’ in its place], and add a .gitattributes file in your root > director

Re: more spotless problems on Windows

be set to on a windows machine for geode dev work. For my experiments value of core.autocrlf was set to true. [recommended for cross platform development] Regards Naba On Thu, Nov 3, 2016 at 10:18 PM Nabarun Nag <n...@pivotal.io> wrote: > @Jared > I ran ./gradlew spotlessApply on th

Re: more spotless problems on Windows

> >> > >> --Udo > >> > >> > >> On 4/11/16 9:00 am, Bruce Schuchardt wrote: > >>> It's been working on my Windows 7 machine under a cygwin shell. I > just ran it again using "clean bulid -Dskip.tests=true" from the root Geode >

Re: more spotless problems on Windows

I tested gradlew build on a windows 10 machine to test the spotless feature. Steps: 1. git clone https://git-wip-us.apache.org/repos/asf/incubator-geode.git open 2. cd open 3. git checkout -b develop origin/develop 4. ./gradlew clean build -Dskip.tests=true The build failed with multiple

Re: Build failed in Jenkins: Geode-nightly #642

I will get this fixed. On Thu, Nov 3, 2016 at 8:54 AM Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > > Changes: > > [kmiller] GEODE-2050 Remove doc of statistics no longer present > > [kmiller] GEODE-2050 Add docs for

Review Request 53401: GEODE-1932: Protected use of global variables

heckin IntelliJ multiple executions. Thanks, nabarun nag

Re: Review Request 53345: Adding new PDX , order by and Index Query tests to the open side

/HashIndexDUnitTest.java (line 74) <https://reviews.apache.org/r/53345/#comment223984> This was to trick precheckin to accept my patch. - nabarun nag On Nov. 1, 2016, 6:22 p.m., nabarun nag wrote: > > --- > This is a

Review Request 53345: Adding new PDX , order by and Index Query tests to the open side

-CREATION Diff: https://reviews.apache.org/r/53345/diff/ Testing --- Precheck-in passed Thanks, nabarun nag

Re: [DISCUSS] Graduation

+1 On Wed, Oct 26, 2016 at 12:07 PM Mark Bretl wrote: > +1 > > On Wed, Oct 26, 2016 at 12:04 PM, Ashvin A wrote: > > > +1 > > > > On Tue, Oct 25, 2016 at 5:25 PM, Roman Shaposhnik > wrote: > > > > > inactive > > >

Review Request 53026: GEODE-502: Startup timeout increased to 2min in DUnitLauncher

- geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java 6618d2a Diff: https://reviews.apache.org/r/53026/diff/ Testing --- precheck Thanks, nabarun nag

Re: Review Request 52805: GEODE-1981: Wrapping user ResultCollector in synchronized wrapper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52805/#review152401 --- Ship it! Ship It! - nabarun nag On Oct. 12, 2016, 8:58 p.m

Review Request 52793: GEODE-1353: Added listeners to slow down the receiver.

/serial/SerialWANStatsDUnitTest.java 4db4890 Diff: https://reviews.apache.org/r/52793/diff/ Testing --- * Precheckin * 100 Runs on IntelliJ Thanks, nabarun nag

Review Request 52789: GEODE-1978: Slowing down the receivers

- geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentWANPropagation_1_DUnitTest.java 8bfd8e7 Diff: https://reviews.apache.org/r/52789/diff/ Testing --- * Precheckin * 100 runs on IntelliJ Thanks, nabarun nag

Re: Coding practices/standards

+1 On Wed, Oct 12, 2016 at 10:06 AM Dan Smith wrote: > +1 > > This might be a good time to reformat the code since I don't think there > are too many long lived feature branches outstanding. > > -Dan > > On Wed, Oct 12, 2016 at 10:00 AM, Jared Stewart >

Re: Adding Apache License header to GetRegionsFunctionJUnitTest

--Mark > > On Fri, Oct 7, 2016 at 11:50 AM, Nabarun Nag <n...@pivotal.io> wrote: > > > Hi, > > > > I am adding the license header to this file. Resolving rat issue. > > > > Regards > > Naba > > >

Adding Apache License header to GetRegionsFunctionJUnitTest

Hi, I am adding the license header to this file. Resolving rat issue. Regards Naba

Review Request 52619: GEODE-1967 Old key are not removed from the removedKeyValuesEntries after it was removed from Compact Range Indexes

/geode/cache/query/internal/index/MapRangeIndexMaintenanceJUnitTest.java b651272 Diff: https://reviews.apache.org/r/52619/diff/ Testing --- precheck Additional tests were written. Thanks, nabarun nag

Re: CI bugs

will be removed after an alternative to the pause is found. Regards Nabarun On Tue, Oct 4, 2016 at 5:01 PM Udo Kohlmeyer <ukohlme...@pivotal.io> wrote: > +1 > > > On 5/10/2016 6:28 AM, Nabarun Nag wrote: > > Hi, > > > > I removed the flaky tags from the te

Log related test failures in GEODE

- The following tests are failing on precheck as well as in IntelliJ Tests : - CustomConfigWithCacheIntegrationTest

Re: Review Request 52398: GEODE-1949: Remove the dependency on quartz from the rebalancer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52398/#review151034 --- Ship it! Ship It! - nabarun nag On Sept. 29, 2016, 10:57

Re: Review Request 52176: GEODE-1926: Modification of peedAhead() function check if heapCopy is successful before adding the key to peekedIds

t; Minor nit - can't you just write this code like this? > > > > Long currentKey = getCurrentKey(); > > if(currentKey == null) { > > > > Seems less confusing that way. > > nabarun nag wrote: > I completely agree with th

Re: Review Request 52176: GEODE-1926: Modification of peedAhead() function check if heapCopy is successful before adding the key to peekedIds

but no serialWANConflationDUnitTest in Geode, Am I missing something or are serial WAN conflation tests under a different class. - nabarun nag On Sept. 23, 2016, 9:58 p.m., nabarun nag wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 52176: GEODE-1926: Modification of peedAhead() function check if heapCopy is successful before adding the key to peekedIds

/SerialGatewaySenderQueue.java a8bb72d Diff: https://reviews.apache.org/r/52176/diff/ Testing --- precheck Thanks, nabarun nag

Re: Review Request 52176: GEODE-1926: Modification of peedAhead() function check if heapCopy is successful before adding the key to peekedIds

eviews.apache.org/r/52176/#review150201 --- On Sept. 22, 2016, 9:46 p.m., nabarun nag wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 52176: GEODE-1926: Modification of peedAhead() function check if heapCopy is successful before adding the key to peekedIds

barun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52176/#review150094 --- On Sept. 22, 2016, 9:46 p.m., nabarun nag wrote: > > --- &g

Re: Review Request 51734: GEODE-1864: CompactMapRangeIndex not updating old keys properly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51734/#review149905 --- Ship it! Ship It! - nabarun nag On Sept. 21, 2016, 4 p.m

Review Request 52137: GEODE-1925 : Copy the resources directory inside build directory

/org/apache/geode/modules/session/EmbeddedTomcat.java 1d97149 extensions/geode-modules/src/test/java/org/apache/geode/modules/session/TestSessionsBase.java a680d9e Diff: https://reviews.apache.org/r/52137/diff/ Testing --- Thanks, nabarun nag

Re: Review Request 51735: GEODE-1840: Certain map queries combine OR predicates into an AND junction

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51735/#review148587 --- Ship it! Ship It! - nabarun nag On Sept. 8, 2016, 10:26 p.m

Re: IntelliJ project dependencies

+1 Same issue as Bruce's 1st email with IntelliJ 2016.2.1 Upgraded to 2016.2.2 - same issue again. MacOS 10.11.6 The dependencies break down when a new IntelliJ major version is released. GEODE-1194 fixed by Jens was for the dependency issue in IntelliJ 2016.1.1. On Tue, Aug 16, 2016 at

Re: Review Request 51044: GEODE-1737: gfsh query on region that does not exist may cause NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51044/#review145635 --- Ship it! Ship It! - nabarun nag On Aug. 12, 2016, 4:44 p.m

Re: Review Request 51044: GEODE-1737: gfsh query on region that does not exist may cause NPE

/internal/cli/commands/DataCommands.java (line 1315) <https://reviews.apache.org/r/51044/#comment211949> Can it be put as an else condition here? (as we are already doing the check here) - nabarun nag On Aug. 12, 2016, 4:44 p.m., Jason Huynh

Re: Review Request 50615: GEODE-1676: Multiple Not Equals in query with Compact Range Index returns incorrect results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50615/#review144832 --- Ship it! Ship It! - nabarun nag On July 29, 2016, 9:16 p.m

Review Request 50811: GEODE-1241: Fixing the misspelt words in the geode-wan

Thanks, nabarun nag

Re: Flaky tests failing with BindException

+1 for the retry. In my opinion, maintaining available port lists maybe hard as we move towards running test modules in parallel. Also maybe some non-geode entity may come up and pick up a port hence we will need to constantly refresh/update the list before/after each test run. (1 ports needs

Review Request 50304: GEODE-1674: Using a immuatable object to pass the HashIndexSet and its mask

://reviews.apache.org/r/50304/diff/ Testing --- Precheck-in with no failures. Thanks, nabarun nag

Re: Missing Sign Off on Board Report

As per the incubator wiki, Tue July 12 Mentor signoff due by end of day Please do let us know if any modifications are required in the report. Regards Nabarun Nag On Tue, Jul 12, 2016 at 11:00 AM Kirk Lund <kl...@pivotal.io> wrote: > Please let us know if we skipped anything o

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

> On June 30, 2016, 11:14 p.m., nabarun nag wrote: > > geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java, > > line 303 > > <https://reviews.apache.org/r/49102/diff/1/?file=1427588#file1427588line303> > >

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

ne 329 if (this.ackReaderThread == null || !this.ackReaderThread.isRunning()) Or refactor the method signature. - nabarun nag On June 22, 2016, 5:52 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e

Re: Review Request 49471: GEODE-1374: Flaky tests will now have junit xml recorded into seperate directory

> On June 30, 2016, 11:06 p.m., nabarun nag wrote: > > Ship It! Change made in Jenkins Precheckin to pick up the new folder. - nabarun --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 49471: GEODE-1374: Flaky tests will now have junit xml recorded into seperate directory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49471/#review140261 --- Ship it! Ship It! - nabarun nag On June 30, 2016, 8:50 p.m

Re: [INFO REQUEST] Uploading the podling report

Thanks Swapnil. Email sent. On Thu, Jun 30, 2016 at 3:51 PM Swapnil Bawaskar <sbawas...@pivotal.io> wrote: > Send an email to gene...@incubator.apache.org asking for permissions to > the > wiki for uploading the podling report. > > On Thu, Jun 30, 2016 at 3:19 PM, Nabarun

[INFO REQUEST] Uploading the podling report

Hi, Thank you all for the reviews. Can someone please tell me the steps to append the podling report to http://wiki.apache.org/incubator/July2016. Regards Nabarun Nag

Re: Podling Report Reminder - July 2016

PMC members elected? Nabarun Nag (2016-06-14) Signed-off-by: [ ](geode) Konstantin Boudnik [ ](geode) Chip Childers [ ](geode) Justin Erenkrantz [ ](geode) Jan Iversen [ ](geode) Chris Mattmann [ ](geode) William A. Rowe Jr. [ ](geode) Roman Shaposhnik On Tue, Jun 28, 2016 at 10:4

Re: Podling Report Reminder - July 2016

Jason and I are giving it a shot. I will send the first draft soon. Regards Naba On Tue, Jun 28, 2016 at 9:58 AM Dan Smith wrote: > I can take a crack at this if no one else wants to do it. I'll need some > help from people have done the previous reports. > > -Dan > > On

Re: Review Request 48661: GEODE-1543: Changed the log level from error to warn

> On June 13, 2016, 9:33 p.m., Dan Smith wrote: > > If this is expected behavior, I think this message should be info level or > > lower. warning still indicates that something is going wrong. > > Jason Huynh wrote: > I agree, probably should be info for this

Re: Review Request 48661: GEODE-1543: Changed the log level from error to warn

. To reply, visit: https://reviews.apache.org/r/48661/#review137390 --- On June 13, 2016, 7:33 p.m., nabarun nag wrote: > > --- > This is an automatically generated

Review Request 48661: GEODE-1543: Changed the log level from error to warn

. * This is an expected behaviour and hence should not be logged as error but rather as a warning. Diffs - geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java 8b9664f Diff: https://reviews.apache.org/r/48661/diff/ Testing --- Thanks, nabarun nag

Re: Review Request 46914: GEODE-11: Fixing a class cast exception when LuceneFunction has an error

geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunction.java (line 111) <https://reviews.apache.org/r/46914/#comment195402> Same here why rather doing an isInstanceOf call and throwing the corresponding exception - nabarun nag On May 2, 2016, 10:

Re: Review Request 45938: GEODE-1062: Undoing reduction in wait time

- Barry Oglesby > > On April 8th, 2016, 8:26 p.m. UTC, Jason Huynh wrote: > Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, > Dan Smith, and xiaojian zhou. > By Jason Huynh. > > *Updated April 8, 2016, 8:26 p.m.* > *Repository: * geode > Desc

Re: Review Request 45497: GEODE-1079: Removing unused dist.gemstone.com repository

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45497/#review126217 --- Ship it! Ship It! - nabarun nag On March 30, 2016, 5:34 p.m