[GitHub] incubator-geode issue #283: GEODE-2098: Moved gfsh history file location fro...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/283 Agreed. This could be handled in a release note: âIf you want to preserve your gfsh history, please copyâ¦â Anthony > On Nov 14, 2016, at 10:57 AM, Dan Smith wrote: > > IMO losing your gfsh history on an upgrade is probably not a big deal. > > â > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub <https://github.com/apache/incubator-geode/pull/283#issuecomment-260427020>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACqT2dEBRv5RJyZjnBFGW1o76-yAooPwks5q-K7_gaJpZM4KxirC>. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/278 @davinash I merged the PR. Next time make sure to prefix your commit message with "Geode-NNN" so the commits are linked to the JIRA issue. I also marked the issue as resolved. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/278 As a committer (https://people.apache.org/phonebook.html?uid=adongre) you should have write access. If that isn't working send a note to priv...@geode.incubator.apache.org and we will help sort that out. If you'd have someone else merge the PR, let me know and I will follow the steps at https://cwiki.apache.org/confluence/display/GEODE/Code+contributions. Cheers! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #278: Feature/geode 1896 unable to specify a Partition...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/278 @davinash Thanks for the contribution! Looks like the review is wrapped up from the above comments. If you need help pushing the changes, let me know. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #277: GEODE-1098: Fix gfsh.bat error with default Java...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/277 @upthewaterspout I think you closed PR "227" instead of "277". --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #275: [GEODE-1871] - Updating and cleaning up D...
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/275#discussion_r85631878 --- Diff: docker/Dockerfile --- @@ -14,25 +14,34 @@ # See the License for the specific language governing permissions and # limitations under the License. -FROM geode/base:0.1 -MAINTAINER Geode Community +FROM centos:7 +MAINTAINER Apache Geode Community LABEL Vendor="Apache Geode (incubating)" -LABEL version=unstable +LABEL version=1.0.0 # download JDK 8 -# ENV JAVA_HOME /jdk1.8.0_51 +ENVJAVA_HOME /jdk1.8.0_111 -RUNgit clone -b develop https://github.com/apache/incubator-geode.git \ +RUNyum install -y wget which tar git \ + && wget --no-cookies --no-check-certificate --header "Cookie: gpw_e24=http%3A%2F%2Fwww.oracle.com%2F; oraclelicense=accept-securebackup-cookie" "http://download.oracle.com/otn-pub/java/jdk/8u111-b14/jdk-8u111-linux-x64.tar.gz"; \ --- End diff -- What about just doing `yum install java-1.8.0-openjdk` and avoid any legal issues with redistributing the oracle jdk? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #277: GEODE-1098: Fix gfsh.bat error with default Java...
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/277 Thanks for your contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/265#discussion_r84112416
--- Diff:
geode-assembly/src/test/java/org/apache/geode/rest/internal/web/RestSecurityIntegrationTest.java
---
@@ -94,7 +94,7 @@ public static void before() throws Exception {
@Test
public void testFunctions() throws Exception {
String json = "{\"@type\":\"double\",\"@value\":210}";
-
+Thread.sleep(50);
--- End diff --
This seems like a really long pause for an integration test. Is there
another way to do this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/265#discussion_r84111969 --- Diff: gradle/dependency-versions.properties --- @@ -100,8 +100,8 @@ spring-tx.version = 4.3.2.RELEASE springframework.version = 4.3.2.RELEASE stephenc-findbugs.version = 1.3.9-1 spymemcached.version = 2.9.0 -swagger.version = 1.3.2 -swagger-springmvc.version = 0.8.2 +swagger.version=1.3.13 --- End diff -- Verified that the license is still ASL 2.0 so no changes to LICENSE. Also does not include a NOTICE file so we do not need to propagate anything in our NOTICE. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #259: Feature/geode 1952 2
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/259 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #259: Feature/geode 1952 2
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/259 I think the README could use a few clarifications: 1) You also need to run `bundle install` in the final_app dir. 2) How do we take the generated html site and merge it into the asf-site branch so it can be hosted on geode.apache.org. I also ran into some strange ruby errors installing libv8 / therubyracer that required google's help. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #259: Feature/geode 1952 2
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/259 Is `geode-book` a generated dir or a source directory? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #258: Feature/geode 1952 2
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/258 I think the the CONTRIBUTE.md file needs some updates: - Remove everything before "Working with Markdown Files" - Replace references to 'Project Geode' with 'Apache Geode' The README.md also uses 'Project Geode' and seems to be out of date. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #248: GEODE-1548: Specifying --J=-Dgemfire.jmx-...
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/248#discussion_r81408700 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/security/JavaRmiServerNameJunitTest.java --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.geode.management.internal.security; + +import static org.apache.geode.distributed.ConfigurationProperties.*; +import static org.junit.Assert.*; + +import java.util.Properties; + +import org.junit.Test; +import org.junit.experimental.categories.Category; + +import org.apache.geode.cache.CacheFactory; +import org.apache.geode.internal.AvailablePort; +import org.apache.geode.test.junit.categories.UnitTest; + +@Category(UnitTest.class) --- End diff -- Oh got it, I missed the previous comment around @IntegrationTest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #248: GEODE-1548: Specifying --J=-Dgemfire.jmx-...
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/248#discussion_r81408523 --- Diff: geode-core/src/test/java/org/apache/geode/management/internal/security/JavaRmiServerNameJunitTest.java --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.geode.management.internal.security; + +import static org.apache.geode.distributed.ConfigurationProperties.*; +import static org.junit.Assert.*; + +import java.util.Properties; + +import org.junit.Test; +import org.junit.experimental.categories.Category; + +import org.apache.geode.cache.CacheFactory; +import org.apache.geode.internal.AvailablePort; +import org.apache.geode.test.junit.categories.UnitTest; + +@Category(UnitTest.class) --- End diff -- Isn't the convention to use *JUnitTest for unit tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode issue #231: Feature/geode 1743
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/231 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #230: GEODE-1744: Probable bugs from == use fix...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/230#discussion_r74339073
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/admin/AlertLevel.java ---
@@ -145,8 +147,8 @@ public boolean equals(Object other) {
final AlertLevel that = (AlertLevel) other;
if (this.severity != that.severity) return false;
- if (this.name != that.name &&
- !(this.name != null &&
+ if (!Objects.equals(this.name, that.name) &&
+!(this.name != null &&
this.name.equals(that.name))) return false;
--- End diff --
@kjduling I think you need a `!` in there somewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #230: GEODE-1744: Probable bugs from == use fixed
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/230 Is there a test that exposes the probable bug and verifies that the issue is fixed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #199: GEODE-88: code fixes for c++ client
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/199#discussion_r71169682
--- Diff: geode-client-native/src/cppcache/impl/CppCacheLibrary.cpp ---
@@ -79,7 +84,6 @@ typedef
ACE_Singleton TheLibrary;
// internals are prepared. fw_helper framework will handle this.
CppCacheLibrary* CppCacheLibrary::initLib( void )
{
- ACE::init();
--- End diff --
Won't removing the ACE::init() call affect all existing users? That is,
they would need to modify their applications to add the invocation directly. I
understand this is important for your use case. Is there a way you could
conditionally skip the library initialization rather than remove it entirely?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request #199: GEODE-88: code fixes for c++ client
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/199#discussion_r71168319
--- Diff:
geode-client-native/src/cppcache/impl/ThinClientRedundancyManager.hpp ---
@@ -56,7 +56,7 @@ namespace gemfire {
void netDown( );
void acquireRedundancyLock( ) { m_redundantEndpointsLock.acquire_read(
); }
void releaseRedundancyLock( ) { m_redundantEndpointsLock.release( ); }
- volatile bool allEndPointDiscon() { return m_IsAllEpDisCon;}
+ bool allEndPointDiscon() { return m_IsAllEpDisCon;} //Copyright: Amdocs
Software Systems Limited, 2016
--- End diff --
Source code attribution comments are generally discouraged within ASF
projects since the code is owned and maintained by the community, not
individual contributors or companies.
Some references:
http://s.apache.org/iZl
http://mail-archives.apache.org/mod_mbox/incubator-nifi-dev/201505.mbox/%3CCAGHyZ6LcrZ1aPMUjJ%3DrJkkK19Cmveew7PmTUKuWprK_bz3jxmg%40mail.gmail.com%3E
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode issue #167: GEODE-985: rebrand GFSH help for Apache Geode
Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/167 IIRC, the requirement is to mention (incubating) on the first reference. Here are the branding requirements: http://incubator.apache.org/guides/branding.html Anthony > On Jun 17, 2016, at 12:11 PM, scmbuildguy wrote: > > I did mention in a couple of places, however, in generalI think when referencing the project as 'Apache Geode', I think we should be using 'Apache Geode (incubating)' until Geode is a top-level Apache project. > > â > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub <https://github.com/apache/incubator-geode/pull/167#issuecomment-226856252>, or mute the thread <https://github.com/notifications/unsubscribe/ACqT2UpegGSG3w9EgNMT1e76gbEEmtr5ks5qMvFSgaJpZM4I4nll>. > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request #152: GEODE-68: GFSH SYS_HOST_NAME variable sho...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/152#discussion_r66146482
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/shell/Gfsh.java
---
@@ -279,7 +281,12 @@ protected Gfsh(boolean launchShell, String[] args,
GfshConfig gfshConfig) throws
private void initializeEnvironment() {
env.put(ENV_SYS_USER, System.getProperty("user.name"));
env.put(ENV_SYS_USER_HOME, System.getProperty("user.home"));
-env.put(ENV_SYS_HOST_NAME, System.getProperty("user.name"));
+try {
+ env.put(ENV_SYS_HOST_NAME,
InetAddress.getLocalHost().getHostName());
--- End diff --
@bschuchardt Do we have utility code for doing hostname lookup? Do you see
any problems with timeouts or DNS failures here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request: Feature/geode 904
Github user metatype commented on the pull request: https://github.com/apache/incubator-geode/pull/126#issuecomment-207566042 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request: Feature/geode 904
Github user metatype commented on the pull request: https://github.com/apache/incubator-geode/pull/126#issuecomment-207558046 This looks awesome!! Only change I would make is to add this to the CDDL license for the javax* dependencies: ``` NOTICE PURSUANT TO SECTION 9 OF THE COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) The code released under the CDDL shall be governed by the laws of the State of California (excluding conflict-of-law provisions). Any litigation relating to this License shall be subject to the jurisdiction of the Federal Courts of the Northern District of California and the state courts of the State of California, with venue lying in Santa Clara County, California. ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request: GEODE-904 Adds file listings to LICE...
Github user metatype commented on the pull request: https://github.com/apache/incubator-geode/pull/124#issuecomment-206030069 One more thing: these changes need to be propagated into the LICENSE for the binary distribution located at geode-assembly/src/main/dist/LICENSE. Probably best for future maintenance to break that file in two sections: one for c-n-p of the src LICENSE and one section for the bundled dependencies of the binary distro. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request: GEODE-904 Adds file listings to LICE...
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/124#discussion_r58622668 --- Diff: LICENSE --- @@ -202,160 +202,221 @@ === -Apache Geode includes a number of components and libraries with separate -copyright notices and license terms. Your use of those components are -subject to the terms and conditions of the following licenses. +Apache Geode includes a number of components and libraries with separate +copyright notices and license terms. Your use of those components are +subject to the terms and conditions of the following licenses. --- -Backbone (http://backbonejs.org) +ANSIBuffer (http://jline.sourceforge.net/apidocs/jline/ANSIBuffer.html) --- -This product bundles Backbone which is available under an MIT license. -For details see http://www.opensource.org/licenses/mit-license.php. +This product bundles ANSIBuffer, which is available under a BSD license. +For details, see http://opensource.org/licenses/BSD-3-Clause. + +--- +Backbone.js (http://backbonejs.org) +--- +This product bundles Backbone.js, which is available under an MIT license. +For details see http://opensource.org/licenses/mit-license.php. + +--- +Bootflat (http://bootflat.github.io/) +--- +This product bundles Bootflat, which is available under an MIT license. +For details, see http://opensource.org/licenses/mit-license.html. + +--- +Bootstrap (http://getbootstrap.com/) +--- +This product bundles Bootstrap, which is available under an MIT license. +For details, see http://opensource.org/licenses/mit-license.html. --- CompactConcurrentHashSet2 (http://gee.cs.oswego.edu/dl/concurrency-interest) --- -This product bundles CompactConcurrentHashSet2 derived from JSR-166 -ConcurrentHashMap v1.43 which is available in the public domain. +This product bundles CompactConcurrentHashSet2, derived from JSR-166 +ConcurrentHashMap v1.43, which is available in the public domain. + +--- +Font Awesome (https://fortawesome.github.io/Font-Awesome/) +--- +This product bundles Font Awesome, which is available under the SIL OFL 1.1 +license (font) and the MIT license (code). For details, see +http://scripts.sil.org/OFL and http://opensource.org/licenses/mit-license.html. --- Handlebars (http://handlebarsjs.com) --- -This product bundles Handlebars which is available under an MIT license. +This product bundles Handlebars, which is available under an MIT license. For details see http://www.opensource.org/licenses/mit-license.php. --- +HeadJS (http://headjs.com/) +--- +This product bundles HeadJS, which is available under an MIT license. +For details, see http://opensource.org/licenses/mit-license.html. + +--- highlight.js (https://highlightjs.org) --- -This product bundles highlight.js which is available under a BSD 3 clauses license. -For details see http://opensource.org/licenses/BSD-3-Clause. +This product bundles highlight.js, which is available under a BSD 3-clause +license. For details see http://opensource.org/licenses/BSD-3-Clause. + +--- +HTML5 Shiv (https://github.com/aFarkas/html5shiv) +--- +This product bundles HTML5 Shiv, which is available under an
[GitHub] incubator-geode pull request: GEODE-874: Place all build-from-sour...
Github user metatype commented on the pull request: https://github.com/apache/incubator-geode/pull/114#issuecomment-197391062 +1 If you follow the commit comment conventions at [1] our commit history will be more readable and consistent. Thanks! [1] http://chris.beams.io/posts/git-commit/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request: GEODE-36 Interim fix to display corr...
Github user metatype commented on the pull request: https://github.com/apache/incubator-geode/pull/109#issuecomment-193358388 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request: GEODE-52: Remove @author tags from J...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/100#discussion_r53523831
--- Diff:
extensions/gemfire-modules-session/src/test/java/com/gemstone/gemfire/modules/session/junit/NamedRunner.java
---
@@ -27,7 +27,6 @@
* marked with @After and @Before (but also the Test method itself) can
request
* this name for which it is running.
*
- * @author Rudy De Busscher
*/
public class NamedRunner extends BlockJUnit4ClassRunner {
--- End diff --
This code appears to be copied from Apache myfaces project. We should
preserve the author tag and possibly add to NOTICE.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-geode pull request: GEODE-52: Remove @author tags from J...
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/100#discussion_r53524020 --- Diff: extensions/gemfire-modules-session/src/test/java/com/gemstone/gemfire/modules/session/junit/SeparateClassloaderTestRunner.java --- @@ -23,7 +23,6 @@ import java.net.URLClassLoader; /** - * @author StackOverflow --- End diff -- We need to investigate the origin of this code to ensure it is safe to include in the geode code base. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request: GEODE-52: Remove @author tags from J...
Github user metatype commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/100#discussion_r53523369 --- Diff: extensions/gemfire-modules-hibernate/src/test/java/com/gemstone/gemfire/modules/Owner.java --- @@ -34,9 +34,6 @@ /** * Simple JavaBean domain object representing an owner. * - * @author Ken Krebs --- End diff -- This files looks to be copied from spring-petclinic. We need to preserve the author tags and reapply the original copyright header. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request: GEODE-901: Remove invalid source hea...
Github user metatype commented on the pull request: https://github.com/apache/incubator-geode/pull/94#issuecomment-184871752 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request: GEODE-854: refactor gemfire-pulse no...
Github user metatype commented on the pull request: https://github.com/apache/incubator-geode/pull/78#issuecomment-174831927 LGTM! +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request: GEM-164: move the security tests in ...
Github user metatype commented on the pull request: https://github.com/apache/incubator-geode/pull/52#issuecomment-163792393 Can you remove the Pivotal copyright and add the ASF license header? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request: GEODE-479 - Updating build.gradle to...
Github user metatype commented on the pull request: https://github.com/apache/incubator-geode/pull/23#issuecomment-150641759 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-geode pull request: Support for creating Maven distribut...
Github user metatype commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/1#discussion_r29622369
--- Diff: build.gradle ---
@@ -25,6 +25,11 @@ allprojects {
if (!buildRoot.isEmpty()) {
buildDir = buildRoot + project.path.replace(":", "/") + "/build"
}
+
--- End diff --
Mark, can you wrap this in a whenReady closure?
```
gradle.taskGraph.whenReady({ graph ->
...
}
```
That will avoid potential ordering problems...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
