[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269358 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -85,34 +87,53 @@ public void testLoadClass() throws Exception {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045314578 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045267812 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -42,27 +44,27 @@ public class JarArchiveTest { @BeforeClass

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045267857 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -42,27 +44,27 @@ public class JarArchiveTest { @BeforeClass

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045267775 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -42,27 +44,27 @@ public class JarArchiveTest { @BeforeClass

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045282542 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -85,34 +87,53 @@ public void testLoadClass() throws Exception {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045307959 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045307959 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045268062 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045268118 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -71,12 +73,12 @@ public void testGetBytecode() throws Exception {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269988 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] rmannibucau commented on pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

rmannibucau commented on PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#issuecomment-1345631321 Open point to maybe discuss (can be on the list): do we want to deprecate `public JarArchive(ClassLoader loader, URL url) {` and promote a `public JarArchive(ClassLoader loader,

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269988 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269358 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -85,34 +87,53 @@ public void testLoadClass() throws Exception {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045271076 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -85,34 +87,53 @@ public void testLoadClass() throws Exception {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045268414 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -85,34 +87,53 @@ public void testLoadClass() throws Exception {

[GitHub] [geronimo-xbean] dblevins commented on pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

dblevins commented on PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#issuecomment-1345609708 I'll take a look at this tomorrow as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045268414 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -85,34 +87,53 @@ public void testLoadClass() throws Exception {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269988 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045281610 ## xbean-finder/src/test/java/org/apache/xbean/finder/archive/JarArchiveTest.java: ## @@ -85,34 +87,53 @@ public void testLoadClass() throws Exception {

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045267258 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269988 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045269988 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045307959 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045267357 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] powerbroker commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

powerbroker commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045267541 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045281235 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045282353 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045261031 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045496483 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] rmannibucau commented on a diff in pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

rmannibucau commented on code in PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#discussion_r1045497969 ## xbean-finder/src/main/java/org/apache/xbean/finder/archive/JarArchive.java: ## @@ -41,22 +43,52 @@ public class JarArchive implements Archive { private

[GitHub] [geronimo-xbean] rmannibucau commented on pull request #34: XBEAN-337 jar path with exclamation signs(!) should be resolved correctly

rmannibucau commented on PR #34: URL: https://github.com/apache/geronimo-xbean/pull/34#issuecomment-1345503365 This actually hits a java bug where nested '!' are not supported in urls. Can you at least add a boolean toggle in JarArchuve to switch the behavior cause opposite bug exists