Re: Disallow 1.5 on trunk (until its actually supported)?

2006-08-21 Thread Alan Cabrera
Thanks for pointing this out for me. It seems like a reasonable idea. Regards, Alan Jason Dillon wrote: We already have this... this just means that compiles will continue to gen 1.4 bytecode. Some tests have been known to fail because they were run with 1.5, and then all that orb stuff.

Re: Disallow 1.5 on trunk (until its actually supported)?

2006-08-21 Thread Jason Dillon
Okay, I'm going to commit this. If anyone see anything strange, like you are using a 1.4 JDK and it complains please let me know right away and I will fix and/or back- out this change. --jason On Aug 21, 2006, at 5:34 PM, Alan Cabrera wrote: Thanks for pointing this out for me. It

Disallow 1.5 on trunk (until its actually supported)?

2006-08-20 Thread Jason Dillon
I keep running into problems switching my local jdk (ala setjdk) from 1.4 to 1.5 and forgetting to switch it back again when making G builds. I though it would be nice if the build would fail early if I had the wrong JDK configured. So, I wroke a require-java-version goal in a new

Re: Disallow 1.5 on trunk (until its actually supported)?

2006-08-20 Thread Jacek Laskowski
On 8/20/06, Jason Dillon [EMAIL PROTECTED] wrote: Thoughts? Good idea! I had to create some aliases to work with the project and I'm not facing the issue anymore, but I'm sure there're others (if not all) who work with both, so the sooner they know they use incorrect jvm during the build the

Re: Disallow 1.5 on trunk (until its actually supported)?

2006-08-20 Thread Jacek Laskowski
On 8/20/06, Jason Dillon [EMAIL PROTECTED] wrote: Seems like folks who build with 1.5 run into errors... so maybe its a good thing to force 1.4? One more thing, it would be good to introduce a setting to turn it on for people who want to migrate Geronimo to Java 5. Jacek -- Jacek Laskowski

Re: Disallow 1.5 on trunk (until its actually supported)?

2006-08-20 Thread Jason Dillon
I added a skip flag... and I have not tried, but you should be able to create a profiles.xml to set that flag. --jason On Aug 20, 2006, at 1:07 AM, Jacek Laskowski wrote: On 8/20/06, Jason Dillon [EMAIL PROTECTED] wrote: Seems like folks who build with 1.5 run into errors... so maybe its

Re: Disallow 1.5 on trunk (until its actually supported)?

2006-08-20 Thread Gianny Damour
+1 Gianny On 20/08/2006, at 5:44 PM, Jason Dillon wrote: I keep running into problems switching my local jdk (ala setjdk) from 1.4 to 1.5 and forgetting to switch it back again when making G builds. I though it would be nice if the build would fail early if I had the wrong JDK

Re: Disallow 1.5 on trunk (until its actually supported)?

2006-08-20 Thread Alan D. Cabrera
Jason Dillon wrote: I keep running into problems switching my local jdk (ala setjdk) from 1.4 to 1.5 and forgetting to switch it back again when making G builds. I though it would be nice if the build would fail early if I had the wrong JDK configured. So, I wroke a require-java-version goal

Re: Disallow 1.5 on trunk (until its actually supported)?

2006-08-20 Thread Bill Dudney
Problem is that the 1.5 jdk does not include the sun orb so compile fails, but not till late in the build +1 from me -bd- On Aug 20, 2006, at 11:36 AM, Alan D. Cabrera wrote: Jason Dillon wrote: I keep running into problems switching my local jdk (ala setjdk) from 1.4 to 1.5 and

Re: Disallow 1.5 on trunk (until its actually supported)?

2006-08-20 Thread Jason Dillon
We already have this... this just means that compiles will continue to gen 1.4 bytecode. Some tests have been known to fail because they were run with 1.5, and then all that orb stuff. We warn everyone all over the place to not use 1.5 with G right now... figured we should just enforce