Re: svn commit: r574770 - in /geronimo/devtools/eclipse-plugin/branches/2.0.0: ./ plugins/org.apache.geronimo.deployment.model.edit/ plugins/org.apache.geronimo.deployment.model/ plugins/org.apache.ge

2007-09-14 Thread Lin Sun
Thanks Tim and Kevan! Lin Tim McConnell wrote: Hi Kevan, yes I shall handle via: http://issues.apache.org/jira/browse/GERONIMODEVTOOLS-207 Kevan Miller wrote: On Sep 13, 2007, at 5:39 PM, Kevan Miller wrote: On Sep 13, 2007, at 4:44 PM, Lin Sun wrote: I think we also need to update the

Re: svn commit: r574770 - in /geronimo/devtools/eclipse-plugin/branches/2.0.0:

2007-09-14 Thread Tim McConnell
Hi Lin/Kevan, do you all feel this change is a show-stopped for RC2 ?? If so, I'll cancel the vote and start another one for RC3. Please advise. Thanks. Lin Sun wrote: Thanks Tim and Kevan! Lin Tim McConnell wrote: Hi Kevan, yes I shall handle via:

Re: svn commit: r574770 - in /geronimo/devtools/eclipse-plugin/branches/2.0.0:

2007-09-14 Thread Lin Sun
Hi Tim, I think it would be nice to get this addressed, as this is the GUI that users will see before they click on the accept radio button to accept the license. But I can be convinced the other way too. Do you need to spin another build because of this site below is still pointing at

Re: svn commit: r574770 - in /geronimo/devtools/eclipse-plugin/branches/2.0.0:

2007-09-14 Thread Kevan Miller
On Sep 14, 2007, at 10:48 AM, Tim McConnell wrote: Hi Lin/Kevan, do you all feel this change is a show-stopped for RC2 ?? If so, I'll cancel the vote and start another one for RC3. Please advise. Thanks. Hey Tim, From a binary perspective, things are fine. However, if the installation

Re: svn commit: r574770 - in /geronimo/devtools/eclipse-plugin/branches/2.0.0:

2007-09-14 Thread Tim McConnell
Hi again Lin, I'll create an RC3 to fix the licensing problems. But the plugin.xml for geronimo.st.v20.core_2.0.0.jar is correct if you look at it from the actual deployable zip that is being (and will be) voted on, or even in svn. It actually points to a real eclipse update site (e.g.,

Re: svn commit: r574770 - in /geronimo/devtools/eclipse-plugin/branches/2.0.0:

2007-09-14 Thread Tim McConnell
Okay, thanks for the information Kevan Miller wrote: On Sep 14, 2007, at 10:48 AM, Tim McConnell wrote: Hi Lin/Kevan, do you all feel this change is a show-stopped for RC2 ?? If so, I'll cancel the vote and start another one for RC3. Please advise. Thanks. Hey Tim, From a binary

Re: svn commit: r574770 - in /geronimo/devtools/eclipse-plugin/branches/2.0.0:

2007-09-14 Thread Lin Sun
Hi Tim, cool. as long as you got it covered that is great. I was only looking at what I downloaded (didn't check the svn.). Lin Tim McConnell wrote: Hi again Lin, I'll create an RC3 to fix the licensing problems. But the plugin.xml for geronimo.st.v20.core_2.0.0.jar is correct if you look

Re: svn commit: r574770 - in /geronimo/devtools/eclipse-plugin/branches/2.0.0: ./ plugins/org.apache.geronimo.deployment.model.edit/ plugins/org.apache.geronimo.deployment.model/ plugins/org.apache.ge

2007-09-13 Thread Kevan Miller
On Sep 13, 2007, at 5:39 PM, Kevan Miller wrote: On Sep 13, 2007, at 4:44 PM, Lin Sun wrote: I think we also need to update the license in the feature.properties file for each of the feature we provide. Right now, I only saw ASL 2.0 there. The license in the feature.properties file

Re: svn commit: r574770 - in /geronimo/devtools/eclipse-plugin/branches/2.0.0: ./ plugins/org.apache.geronimo.deployment.model.edit/ plugins/org.apache.geronimo.deployment.model/ plugins/org.apache.ge

2007-09-13 Thread Tim McConnell
Hi Kevan, yes I shall handle via: http://issues.apache.org/jira/browse/GERONIMODEVTOOLS-207 Kevan Miller wrote: On Sep 13, 2007, at 5:39 PM, Kevan Miller wrote: On Sep 13, 2007, at 4:44 PM, Lin Sun wrote: I think we also need to update the license in the feature.properties file for each