Am I missing something, or the PageRankBenchmark does not support output?
--
Claudio Martella
claudio.marte...@gmail.com
On April 8, 2013, 5:27 p.m., Avery Ching wrote:
Overall, I think it's great that we make toolkits like Yourkit easy to use
in Giraph and this is a good first step. Personally I feel a little
strange though with adding the actual logging calls in the usercode. Also,
I am a bit
[
https://issues.apache.org/jira/browse/GIRAPH-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627682#comment-13627682
]
Hudson commented on GIRAPH-612:
---
Integrated in Giraph-trunk-Commit #908 (See
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claudio Martella updated GIRAPH-613:
Attachment: GIRAPH-613.diff
passes verify and text both local and destributed.
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627744#comment-13627744
]
Claudio Martella commented on GIRAPH-613:
-
Actually, I would have like to test it
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627831#comment-13627831
]
Maja Kabiljo commented on GIRAPH-613:
-
Refactor was really just a refactor, so it's
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627844#comment-13627844
]
Claudio Martella commented on GIRAPH-613:
-
Makes sense. Tested also with
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627904#comment-13627904
]
Maja Kabiljo commented on GIRAPH-613:
-
Looks good overall, apart from one concern -
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627908#comment-13627908
]
Claudio Martella commented on GIRAPH-613:
-
I'm not sure where we reuse objects in
[
https://issues.apache.org/jira/browse/GIRAPH-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Claudio Martella updated GIRAPH-616:
Attachment: GIRAPH-616.diff
Implements the decoupling inside of the OOC graph, and
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627965#comment-13627965
]
Maja Kabiljo commented on GIRAPH-613:
-
It's not exactly that you broke it, but earlier
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627972#comment-13627972
]
Claudio Martella commented on GIRAPH-613:
-
Ok, I see. Nonetheless, it would be
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627988#comment-13627988
]
Avery Ching commented on GIRAPH-613:
[~majakabiljo], you have a great memory. As you
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627990#comment-13627990
]
Claudio Martella commented on GIRAPH-613:
-
So, it's not this patch that broke it,
[
https://issues.apache.org/jira/browse/GIRAPH-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628006#comment-13628006
]
Claudio Martella commented on GIRAPH-616:
-
We get the expected improvement, but
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10389/#review18960
---
Ship it!
This is a nice refactor. Also a few hidden improvements
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628053#comment-13628053
]
Maja Kabiljo commented on GIRAPH-613:
-
The patch makes it impossible to reuse objects
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628055#comment-13628055
]
Maja Kabiljo commented on GIRAPH-613:
-
I thought our distributed tests are broken? :-)
[
https://issues.apache.org/jira/browse/GIRAPH-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628058#comment-13628058
]
Maja Kabiljo commented on GIRAPH-616:
-
Awesome results!
If you were to try with
On April 10, 2013, 5:58 p.m., Avery Ching wrote:
This is a nice refactor. Also a few hidden improvements such as not
putting the partition back. Looks good!
Thanks Avery, committing!
- Maja
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10387/#review18969
---
I don't see an updated diff. Why were my issues marked as resolved?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10343/
---
(Updated April 10, 2013, 7:08 p.m.)
Review request for giraph.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10343/#review18971
---
Ship it!
Ship It!
- Alessandro Presta
On April 10, 2013, 7:08
[
https://issues.apache.org/jira/browse/GIRAPH-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628167#comment-13628167
]
Jan van der Lugt commented on GIRAPH-543:
-
So how big is the performance
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628277#comment-13628277
]
Claudio Martella commented on GIRAPH-613:
-
Honestly, I do not understand your
[
https://issues.apache.org/jira/browse/GIRAPH-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628279#comment-13628279
]
Claudio Martella commented on GIRAPH-616:
-
Maybe my cluster is introducing the
[
https://issues.apache.org/jira/browse/GIRAPH-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628339#comment-13628339
]
Maja Kabiljo commented on GIRAPH-543:
-
There are two benefits:
- Int, float version
[
https://issues.apache.org/jira/browse/GIRAPH-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maja Kabiljo updated GIRAPH-543:
Summary: Fix PageRankBenchmark and make WeightedPageRankBenchmark (was:
PageRankBenchmark has
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628346#comment-13628346
]
Maja Kabiljo commented on GIRAPH-613:
-
I am not sure which patch you are referring to,
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628387#comment-13628387
]
Claudio Martella commented on GIRAPH-613:
-
Then I must have misunderstood what you
[
https://issues.apache.org/jira/browse/GIRAPH-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628449#comment-13628449
]
Avery Ching commented on GIRAPH-612:
[~cmartella], this is not a bug =). We can
[
https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628455#comment-13628455
]
Maja Kabiljo commented on GIRAPH-613:
-
I'm sorry for the confusion. There was
[
https://issues.apache.org/jira/browse/GIRAPH-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628479#comment-13628479
]
Hudson commented on GIRAPH-543:
---
Integrated in Giraph-trunk-Commit #909 (See
[
https://issues.apache.org/jira/browse/GIRAPH-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628480#comment-13628480
]
Hudson commented on GIRAPH-615:
---
Integrated in Giraph-trunk-Commit #909 (See
[
https://issues.apache.org/jira/browse/GIRAPH-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628485#comment-13628485
]
Maja Kabiljo commented on GIRAPH-543:
-
It shoudln't be GC because I conducted
[
https://issues.apache.org/jira/browse/GIRAPH-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maja Kabiljo resolved GIRAPH-543.
-
Resolution: Fixed
Fix PageRankBenchmark and make WeightedPageRankBenchmark
36 matches
Mail list logo