PageRankBenchmark supports VertexOutputFormat but not Output path

2013-04-10 Thread Claudio Martella
Am I missing something, or the PageRankBenchmark does not support output? -- Claudio Martella claudio.marte...@gmail.com

Re: Review Request: YourKit profiling API for easy profiling of giraph

2013-04-10 Thread Nitay Joffe
On April 8, 2013, 5:27 p.m., Avery Ching wrote: Overall, I think it's great that we make toolkits like Yourkit easy to use in Giraph and this is a good first step. Personally I feel a little strange though with adding the actual logging calls in the usercode. Also, I am a bit

[jira] [Commented] (GIRAPH-612) Improve website for upcoming release

2013-04-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627682#comment-13627682 ] Hudson commented on GIRAPH-612: --- Integrated in Giraph-trunk-Commit #908 (See

[jira] [Updated] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Claudio Martella (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claudio Martella updated GIRAPH-613: Attachment: GIRAPH-613.diff passes verify and text both local and destributed.

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Claudio Martella (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627744#comment-13627744 ] Claudio Martella commented on GIRAPH-613: - Actually, I would have like to test it

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627831#comment-13627831 ] Maja Kabiljo commented on GIRAPH-613: - Refactor was really just a refactor, so it's

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Claudio Martella (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627844#comment-13627844 ] Claudio Martella commented on GIRAPH-613: - Makes sense. Tested also with

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627904#comment-13627904 ] Maja Kabiljo commented on GIRAPH-613: - Looks good overall, apart from one concern -

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Claudio Martella (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627908#comment-13627908 ] Claudio Martella commented on GIRAPH-613: - I'm not sure where we reuse objects in

[jira] [Updated] (GIRAPH-616) Decouple vertices and edges in DiskBackedPartitionStore and avoid writing back edges when the algorithm does not change topology.

2013-04-10 Thread Claudio Martella (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claudio Martella updated GIRAPH-616: Attachment: GIRAPH-616.diff Implements the decoupling inside of the OOC graph, and

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627965#comment-13627965 ] Maja Kabiljo commented on GIRAPH-613: - It's not exactly that you broke it, but earlier

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Claudio Martella (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627972#comment-13627972 ] Claudio Martella commented on GIRAPH-613: - Ok, I see. Nonetheless, it would be

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627988#comment-13627988 ] Avery Ching commented on GIRAPH-613: [~majakabiljo], you have a great memory. As you

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Claudio Martella (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627990#comment-13627990 ] Claudio Martella commented on GIRAPH-613: - So, it's not this patch that broke it,

[jira] [Commented] (GIRAPH-616) Decouple vertices and edges in DiskBackedPartitionStore and avoid writing back edges when the algorithm does not change topology.

2013-04-10 Thread Claudio Martella (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628006#comment-13628006 ] Claudio Martella commented on GIRAPH-616: - We get the expected improvement, but

Re: Review Request: GIRAPH-615: Add support for multithreaded output

2013-04-10 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10389/#review18960 --- Ship it! This is a nice refactor. Also a few hidden improvements

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628053#comment-13628053 ] Maja Kabiljo commented on GIRAPH-613: - The patch makes it impossible to reuse objects

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628055#comment-13628055 ] Maja Kabiljo commented on GIRAPH-613: - I thought our distributed tests are broken? :-)

[jira] [Commented] (GIRAPH-616) Decouple vertices and edges in DiskBackedPartitionStore and avoid writing back edges when the algorithm does not change topology.

2013-04-10 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628058#comment-13628058 ] Maja Kabiljo commented on GIRAPH-616: - Awesome results! If you were to try with

Re: Review Request: GIRAPH-615: Add support for multithreaded output

2013-04-10 Thread Maja Kabiljo
On April 10, 2013, 5:58 p.m., Avery Ching wrote: This is a nice refactor. Also a few hidden improvements such as not putting the partition back. Looks good! Thanks Avery, committing! - Maja --- This is an automatically

Re: Review Request: InternalVertexRunner.run() should take GiraphConfiguration, not GiraphClasses

2013-04-10 Thread Alessandro Presta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10387/#review18969 --- I don't see an updated diff. Why were my issues marked as resolved?

Re: Review Request: PageRankBenchmark - WeightedPageRankBenchmark and create FastPageRankBenchmark

2013-04-10 Thread Maja Kabiljo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10343/ --- (Updated April 10, 2013, 7:08 p.m.) Review request for giraph. Changes

Re: Review Request: PageRankBenchmark - WeightedPageRankBenchmark and create FastPageRankBenchmark

2013-04-10 Thread Alessandro Presta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10343/#review18971 --- Ship it! Ship It! - Alessandro Presta On April 10, 2013, 7:08

[jira] [Commented] (GIRAPH-543) PageRankBenchmark has unnecessary edge weights

2013-04-10 Thread Jan van der Lugt (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628167#comment-13628167 ] Jan van der Lugt commented on GIRAPH-543: - So how big is the performance

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Claudio Martella (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628277#comment-13628277 ] Claudio Martella commented on GIRAPH-613: - Honestly, I do not understand your

[jira] [Commented] (GIRAPH-616) Decouple vertices and edges in DiskBackedPartitionStore and avoid writing back edges when the algorithm does not change topology.

2013-04-10 Thread Claudio Martella (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628279#comment-13628279 ] Claudio Martella commented on GIRAPH-616: - Maybe my cluster is introducing the

[jira] [Commented] (GIRAPH-543) PageRankBenchmark has unnecessary edge weights

2013-04-10 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628339#comment-13628339 ] Maja Kabiljo commented on GIRAPH-543: - There are two benefits: - Int, float version

[jira] [Updated] (GIRAPH-543) Fix PageRankBenchmark and make WeightedPageRankBenchmark

2013-04-10 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maja Kabiljo updated GIRAPH-543: Summary: Fix PageRankBenchmark and make WeightedPageRankBenchmark (was: PageRankBenchmark has

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628346#comment-13628346 ] Maja Kabiljo commented on GIRAPH-613: - I am not sure which patch you are referring to,

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Claudio Martella (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628387#comment-13628387 ] Claudio Martella commented on GIRAPH-613: - Then I must have misunderstood what you

[jira] [Commented] (GIRAPH-612) Improve website for upcoming release

2013-04-10 Thread Avery Ching (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628449#comment-13628449 ] Avery Ching commented on GIRAPH-612: [~cmartella], this is not a bug =). We can

[jira] [Commented] (GIRAPH-613) Remove Writable from the interfaces implemented by Vertex

2013-04-10 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628455#comment-13628455 ] Maja Kabiljo commented on GIRAPH-613: - I'm sorry for the confusion. There was

[jira] [Commented] (GIRAPH-543) Fix PageRankBenchmark and make WeightedPageRankBenchmark

2013-04-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628479#comment-13628479 ] Hudson commented on GIRAPH-543: --- Integrated in Giraph-trunk-Commit #909 (See

[jira] [Commented] (GIRAPH-615) Add support for multithreaded output

2013-04-10 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628480#comment-13628480 ] Hudson commented on GIRAPH-615: --- Integrated in Giraph-trunk-Commit #909 (See

[jira] [Commented] (GIRAPH-543) Fix PageRankBenchmark and make WeightedPageRankBenchmark

2013-04-10 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628485#comment-13628485 ] Maja Kabiljo commented on GIRAPH-543: - It shoudln't be GC because I conducted

[jira] [Resolved] (GIRAPH-543) Fix PageRankBenchmark and make WeightedPageRankBenchmark

2013-04-10 Thread Maja Kabiljo (JIRA)
[ https://issues.apache.org/jira/browse/GIRAPH-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maja Kabiljo resolved GIRAPH-543. - Resolution: Fixed Fix PageRankBenchmark and make WeightedPageRankBenchmark