+1
Thanks
Binwei
-Original Message-
From: XiDuo You
Sent: Thursday, March 28, 2024 5:33 AM
To: dev@gluten.apache.org
Subject: Re: About Branch Protection rule
Thank you Weiting!
+1
Jacky Lee 于2024年3月28日周四 16:01写道：
>
> +1
>
> Yang Zhang 于2024年3月28日周四 15:50写道
Thank you Weiting!
+1
Jacky Lee 于2024年3月28日周四 16:01写道：
>
> +1
>
> Yang Zhang 于2024年3月28日周四 15:50写道：
> >
> > +1
> >
> > On 2024/03/27 14:07:32 WeitingChen wrote:
> > > Currently, Gluten's Branch Protection rule is null, which means no rule
> > > right now and anyone who has written permission
+1
Yang Zhang 于2024年3月28日周四 15:50写道：
>
> +1
>
> On 2024/03/27 14:07:32 WeitingChen wrote:
> > Currently, Gluten's Branch Protection rule is null, which means no rule
> > right now and anyone who has written permission can merge PR.
> > Many developers from multiple companies highlight this and
+1
On 2024/03/27 14:07:32 WeitingChen wrote:
> Currently, Gluten's Branch Protection rule is null, which means no rule
> right now and anyone who has written permission can merge PR.
> Many developers from multiple companies highlight this and request to set a
> more strict rule.
> Before we
+1
On 2024/03/28 01:51:28 Zhang Hongze wrote:
> Thanks Weiting.
>
> > is set to *require at least one review approval*
>
> If I understand correctly, we are going to add this restriction back to
> Apache Gluten repo, is that correct?
>
> I think for some trivial PRs committers may want to keep
Thanks Weiting.
> is set to *require at least one review approval*
If I understand correctly, we are going to add this restriction back to
Apache Gluten repo, is that correct?
I think for some trivial PRs committers may want to keep some
flexibility to merge by themselves as long as they are
Currently, Gluten's Branch Protection rule is null, which means no rule
right now and anyone who has written permission can merge PR.
Many developers from multiple companies highlight this and request to set a
more strict rule.
Before we contribute to Apache the rule is set to *require at least
