[jira] [Work logged] (GOBBLIN-868) Job statuses are still used for determining if a flow is running
[ https://issues.apache.org/jira/browse/GOBBLIN-868?focusedWorklogId=308140&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308140 ] ASF GitHub Bot logged work on GOBBLIN-868: -- Author: ASF GitHub Bot Created on: 06/Sep/19 20:34 Start Date: 06/Sep/19 20:34 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #2723: [GOBBLIN-868] Check flow status instead of job status to determine if flow is running URL: https://github.com/apache/incubator-gobblin/pull/2723 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 308140) Time Spent: 1h 10m (was: 1h) > Job statuses are still used for determining if a flow is running > > > Key: GOBBLIN-868 > URL: https://issues.apache.org/jira/browse/GOBBLIN-868 > Project: Apache Gobblin > Issue Type: Bug >Reporter: Jack Moseley >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (GOBBLIN-868) Job statuses are still used for determining if a flow is running
[ https://issues.apache.org/jira/browse/GOBBLIN-868?focusedWorklogId=308089&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308089 ] ASF GitHub Bot logged work on GOBBLIN-868: -- Author: ASF GitHub Bot Created on: 06/Sep/19 18:47 Start Date: 06/Sep/19 18:47 Worklog Time Spent: 10m Work Description: codecov-io commented on issue #2723: [GOBBLIN-868] Check flow status instead of job status to determine if flow is running URL: https://github.com/apache/incubator-gobblin/pull/2723#issuecomment-528971056 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=h1) Report > Merging [#2723](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/3523dbcdf41d489ece761c37f5849539cfc8948d?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `57.14%`. [](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#2723 +/- ## + Coverage 45.01% 45.01% +<.01% - Complexity 8740 8744 +4 Files 1884 1884 Lines 7026670267 +1 Branches 7709 7710 +1 + Hits 3162831634 +6 + Misses3570935703 -6 - Partials 2929 2930 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...gobblin/service/monitoring/JobStatusRetriever.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXNSZXRyaWV2ZXIuamF2YQ==) | `0% <0%> (ø)` | `2 <2> (+2)` | :arrow_up: | | [...org/apache/gobblin/service/FlowStatusResource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93U3RhdHVzUmVzb3VyY2UuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...obblin/service/monitoring/FlowStatusGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9GbG93U3RhdHVzR2VuZXJhdG9yLmphdmE=) | `82.14% <100%> (-7.15%)` | `11 <1> (-1)` | | | [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `66.19% <0%> (+0.46%)` | `29% <0%> (ø)` | :arrow_down: | | [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `39.25% <0%> (+3.73%)` | `13% <0%> (+1%)` | :arrow_up: | | [...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=) | `92.85% <0%> (+7.14%)` | `3% <0%> (ø)` | :arrow_down: | | [...g/apache/gobblin/service/monitoring/JobStatus.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2723/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9Kb2JTdGF0dXMuamF2YQ==) | `23.52% <0%> (+11.76%)` | `4% <0%> (+2%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=footer). Last update [3523dbc...bb1564d](https://codecov.io/gh/apache/incubator-gobblin/pull/2723?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[jira] [Work logged] (GOBBLIN-868) Job statuses are still used for determining if a flow is running
[ https://issues.apache.org/jira/browse/GOBBLIN-868?focusedWorklogId=307554&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307554 ] ASF GitHub Bot logged work on GOBBLIN-868: -- Author: ASF GitHub Bot Created on: 06/Sep/19 00:43 Start Date: 06/Sep/19 00:43 Worklog Time Spent: 10m Work Description: sv2000 commented on issue #2723: [GOBBLIN-868] Check flow status instead of job status to determine if flow is running URL: https://github.com/apache/incubator-gobblin/pull/2723#issuecomment-528661396 @jack-moseley travis failed. can you check? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 307554) Time Spent: 50m (was: 40m) > Job statuses are still used for determining if a flow is running > > > Key: GOBBLIN-868 > URL: https://issues.apache.org/jira/browse/GOBBLIN-868 > Project: Apache Gobblin > Issue Type: Bug >Reporter: Jack Moseley >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (GOBBLIN-868) Job statuses are still used for determining if a flow is running
[ https://issues.apache.org/jira/browse/GOBBLIN-868?focusedWorklogId=307527&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307527 ] ASF GitHub Bot logged work on GOBBLIN-868: -- Author: ASF GitHub Bot Created on: 05/Sep/19 23:24 Start Date: 05/Sep/19 23:24 Worklog Time Spent: 10m Work Description: jack-moseley commented on issue #2723: [GOBBLIN-868] Check flow status instead of job status to determine if flow is running URL: https://github.com/apache/incubator-gobblin/pull/2723#issuecomment-528644372 @sv2000 please merge This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 307527) Time Spent: 40m (was: 0.5h) > Job statuses are still used for determining if a flow is running > > > Key: GOBBLIN-868 > URL: https://issues.apache.org/jira/browse/GOBBLIN-868 > Project: Apache Gobblin > Issue Type: Bug >Reporter: Jack Moseley >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (GOBBLIN-868) Job statuses are still used for determining if a flow is running
[ https://issues.apache.org/jira/browse/GOBBLIN-868?focusedWorklogId=307526&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307526 ] ASF GitHub Bot logged work on GOBBLIN-868: -- Author: ASF GitHub Bot Created on: 05/Sep/19 23:23 Start Date: 05/Sep/19 23:23 Worklog Time Spent: 10m Work Description: arjun4084346 commented on issue #2723: [GOBBLIN-868] Check flow status instead of job status to determine if flow is running URL: https://github.com/apache/incubator-gobblin/pull/2723#issuecomment-528644066 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 307526) Time Spent: 0.5h (was: 20m) > Job statuses are still used for determining if a flow is running > > > Key: GOBBLIN-868 > URL: https://issues.apache.org/jira/browse/GOBBLIN-868 > Project: Apache Gobblin > Issue Type: Bug >Reporter: Jack Moseley >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (GOBBLIN-868) Job statuses are still used for determining if a flow is running
[
https://issues.apache.org/jira/browse/GOBBLIN-868?focusedWorklogId=307502&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307502
]
ASF GitHub Bot logged work on GOBBLIN-868:
--
Author: ASF GitHub Bot
Created on: 05/Sep/19 22:47
Start Date: 05/Sep/19 22:47
Worklog Time Spent: 10m
Work Description: jack-moseley commented on pull request #2723:
[GOBBLIN-868] Check flow status instead of job status to determine if flow is
running
URL: https://github.com/apache/incubator-gobblin/pull/2723
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-868
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
After updating to use flow level events for job status, this code should be
using the flow level status instead of using jobs.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 307502)
Remaining Estimate: 0h
Time Spent: 10m
> Job statuses are still used for determining if a flow is running
>
>
> Key: GOBBLIN-868
> URL: https://issues.apache.org/jira/browse/GOBBLIN-868
> Project: Apache Gobblin
> Issue Type: Bug
>Reporter: Jack Moseley
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
[jira] [Work logged] (GOBBLIN-868) Job statuses are still used for determining if a flow is running
[ https://issues.apache.org/jira/browse/GOBBLIN-868?focusedWorklogId=307503&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307503 ] ASF GitHub Bot logged work on GOBBLIN-868: -- Author: ASF GitHub Bot Created on: 05/Sep/19 22:47 Start Date: 05/Sep/19 22:47 Worklog Time Spent: 10m Work Description: jack-moseley commented on issue #2723: [GOBBLIN-868] Check flow status instead of job status to determine if flow is running URL: https://github.com/apache/incubator-gobblin/pull/2723#issuecomment-528620952 @arjun4084346 please review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 307503) Time Spent: 20m (was: 10m) > Job statuses are still used for determining if a flow is running > > > Key: GOBBLIN-868 > URL: https://issues.apache.org/jira/browse/GOBBLIN-868 > Project: Apache Gobblin > Issue Type: Bug >Reporter: Jack Moseley >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
