Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/140
@lewismc Yes implementation really simple, since Flink has this Hadoop
Input format wrappers so we can reuse the Gora Input formats directly as data
sources and sinks to Apache Flink jobs. I
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/140#discussion_r237632179
--- Diff: gora-core/pom.xml ---
@@ -171,6 +187,12 @@
hadoop-minicluster
test
+
--- End diff --
+1
---
GitHub user djkevincr opened a pull request:
https://github.com/apache/gora/pull/140
GORA-548 Apache Flink support for Gora
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djkevincr/gora flink_backend
Alternatively you can
GitHub user djkevincr opened a pull request:
https://github.com/apache/gora/pull/139
GORA-547 Upgrade Aerospike client to 4.2.2
Upgrade Aerospike client to 4.2.2.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djkevincr/gora
GitHub user djkevincr opened a pull request:
https://github.com/apache/gora/pull/138
GORA-543 Upgrade Apache parent POM to version 21
Upgrade Apache parent POM to version 21.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user djkevincr opened a pull request:
https://github.com/apache/gora/pull/137
Remove committed nbactions.xml file
Remove netbeans IDE specific build file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djkevincr/gora
GitHub user djkevincr opened a pull request:
https://github.com/apache/gora/pull/136
GORA-534 Upgrade HBase to 2.1.1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djkevincr/gora GORA-534-HBase-Upgrade
Alternatively you can
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/134
@lewismc I will have a look Lewis. Sorry about the delays. If it all fine i
will proceed merging to master.
---
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/134
@carlosrmng This is excellent work Carlos. Thank you for all hard work you
have put into this in summer. I hope you enjoyed your work. Please do address
my comments, Let's get this thing merged. :)
---
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211539734
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java ---
@@ -0,0 +1,565 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211541050
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java ---
@@ -0,0 +1,565 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211546949
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/query/IgniteResult.java ---
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211537029
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java ---
@@ -0,0 +1,565 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211539151
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java ---
@@ -0,0 +1,565 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211546620
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/query/package-info.java ---
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211529507
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java ---
@@ -0,0 +1,565 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211546255
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/query/package-info.java ---
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211527142
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/utils/package-info.java ---
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211529975
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java ---
@@ -0,0 +1,565 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211538913
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java ---
@@ -0,0 +1,565 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211522113
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/utils/IgniteSQLBuilder.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211522585
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/utils/IgniteSQLBuilder.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211519945
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteStore.java ---
@@ -0,0 +1,565 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211249639
--- Diff:
gora-ignite/src/test/java/org/apache/gora/ignite/store/TestIgniteStore.java ---
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211246685
--- Diff: nbactions.xml ---
@@ -0,0 +1,13 @@
+
--- End diff --
+1 please remove nbactions.xml.
---
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211247029
--- Diff: .gitignore ---
@@ -37,3 +37,4 @@ ivy/ivy*.jar
**/gora-solr-5/src/test/conf/solr/collection1/data/
**/_rest_managed.json
**/gora-solr
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211245661
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/utils/IgniteSQLBuilder.java ---
@@ -0,0 +1,353 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211238621
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteParameters.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211230897
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteMappingBuilder.java
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211221573
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/store/IgniteMapping.java ---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211221395
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/store/Column.java ---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211216655
--- Diff:
gora-ignite/src/main/java/org/apache/gora/ignite/package-info.java ---
@@ -0,0 +1,20 @@
+/**
--- End diff --
Yes Please
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211214999
--- Diff: gora-ignite/pom.xml ---
@@ -0,0 +1,172 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-ins
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211215194
--- Diff: gora-ignite/pom.xml ---
@@ -0,0 +1,182 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-ins
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/134#discussion_r211214861
--- Diff: gora-ignite/pom.xml ---
@@ -0,0 +1,172 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-ins
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/134
Overall PR looks great Carloz :+1: I will go through PR in detail.
---
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/131#discussion_r189883057
--- Diff: gora-core/src/main/java/org/apache/gora/util/IOUtils.java ---
@@ -660,7 +657,8 @@ public static void writeStringArray(DataOutput out,
String[] arr
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/133
This is great @carlosrmng Thank you very much for the PR :)
---
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/133
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Gora ... SUCCESS [1.296s]
[INFO] Apache Gora :: Compiler ... SUCCESS [2.198s
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/133
@carlosrmng As we discussed offline, Can you please update the PR?
---
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/132
Awesome work Carlos :+1: One minor thing to point out, it s good if you can
be consistent with commit messages. Have look at this post.
[1] https://chris.beams.io/posts/git-commit/
---
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/133
This looks good :) Thanks for the PR Carlos. Will keep other s to review as
well. If no one have concerns, I will proceed merging this to the master.
---
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/132
If any one have concerns please raise, otherwise I will proceed merging
this PR to master.
---
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/132
+1
---
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/112
@lewismc this is merged now. You may proceed pushing a release candidate
for Gora 0.8. :)
---
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/112
@lewismc please give me bit of time working on this.
---
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/112
@lewismc I will merge this changes within today best case or it will be end
of tomorrow. Sorry about the delays. Hope that's fine with you. We need to get
this thing to the release and that would
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/119
Will locally test and merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/118
@nishadi Merged the PR. This is great :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/117
Merged the PR. Thanks @nishadi :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r132825580
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java
---
@@ -0,0 +1,279 @@
+/*
+ * Licensed
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r132824780
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/compiler/GoraCassandraNativeCompiler.java
---
@@ -0,0 +1,319
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r132824702
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/GoraCassandraTestDriver.java
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r132824517
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestCassandraStore.java
---
@@ -0,0 +1,204 @@
+/**
+ * Licensed
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r132824405
--- Diff: gora-cassandra-cql/src/test/conf/gora.properties ---
@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r132824244
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestNativeSerializationWithUDT.java
---
@@ -0,0 +1,84
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r132824225
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestNativeSerializationWithUDT.java
---
@@ -0,0 +1,84
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r132824045
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestCassandraStore.java
---
@@ -0,0 +1,204 @@
+/**
+ * Licensed
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r132823884
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/store/CassandraClient.java
---
@@ -0,0 +1,515 @@
+/*
+ * Licensed
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r132823832
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/compiler/GoraCassandraNativeCompiler.java
---
@@ -0,0 +1,319
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r132823605
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestAvroSerializationWithUDT.java
---
@@ -0,0 +1,91 @@
+/**
+ * Licensed
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r132717674
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/serializers/CassandraSerializer.java
---
@@ -0,0 +1,216 @@
+/*
+ * Licensed
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r132715495
--- Diff: gora-cassandra-cql/pom.xml ---
@@ -0,0 +1,238 @@
+
+
+
+http://www.w3.org/2001/XMLSchema-instance;
xmlns="http://maven.apach
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/116
@nishadi PR is merged. Thanks for the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/115
@nishadi Merged the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/115
[INFO] Apache Gora ... SUCCESS [1.683s]
[INFO] Apache Gora :: Compiler ... SUCCESS [1.866s]
[INFO] Apache Gora :: Compiler-CLI
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/116
@nishadi PR looks good. I think we can omit the test cases for now as per
the explanation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/115
@nishadi PR looks good. Will let some time allowing others to take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/114
@oscerd I have merged your PR. Looking forward to your future contributions
:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/114
@oscerd This is great. Will locally test the PR and merge to the master.
Thanks for the contribution :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r130064480
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestCassandraStoreWithNativeSerialization.java
---
@@ -0,0 +1,305
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r130028159
--- Diff: gora-cassandra-cql/src/test/conf/gora.properties ---
@@ -0,0 +1,30 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r130028052
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/GoraCassandraTestDriver.java
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r130027626
--- Diff:
gora-cassandra-cql/src/test/conf/nativeSerialization/gora.properties ---
@@ -0,0 +1,26 @@
+#
+# Licensed to the Apache Software
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r130027514
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/GoraCassandraTestDriver.java
---
@@ -0,0 +1,190 @@
+/*
+ * Licensed
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r130025998
--- Diff:
gora-cassandra-cql/src/examples/java/org/apache/gora/cassandra/example/generated/nativeSerialization/ComplexTypes.java
---
@@ -0,0 +1,102
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r130023982
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/bean/CassandraKey.java
---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r130017958
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/serializers/AvroCassandraUtils.java
---
@@ -0,0 +1,292 @@
+/**
+ * Licensed
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/111
Locally tested Aerospike datastore tests with activating maven profile -
mvn clean install -P aerospike-with-test
Results :
Tests run: 33, Failures: 0, Errors: 0, Skipped: 8
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/111
Build passes without any issue.
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Gora
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/111#discussion_r129768438
--- Diff: gora-aerospike/pom.xml ---
@@ -0,0 +1,174 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/110
@madhawa-gunasekara this looks very good :) heading in right direction.
Please address my comments as go though implementing the rest of the datastore
methods.
---
If your project is set up
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r124046726
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/serializers/CassandraNativePersistent.java
---
@@ -0,0 +1,91 @@
+package
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r124050129
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/store/CassandraStore.java
---
@@ -0,0 +1,788 @@
+/*
+ * Licensed
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r124047919
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/store/TestCassandraStoreWithNativeSerialization.java
---
@@ -0,0 +1,117
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r124048997
--- Diff: gora-cassandra-cql/pom.xml ---
@@ -0,0 +1,232 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r124049334
--- Diff: gora-cassandra-cql/pom.xml ---
@@ -0,0 +1,232 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r124047745
--- Diff: gora-cassandra-cql/src/test/java/.gitignore ---
@@ -0,0 +1,15 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r124048279
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/test/nativeSerialization/User.java
---
@@ -0,0 +1,66 @@
+package
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r124048160
--- Diff:
gora-cassandra-cql/src/test/java/org/apache/gora/cassandra/test/nativeSerialization/DateAsStringCodec.java
---
@@ -0,0 +1,33 @@
+package
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/111
@nishadi very good work, heading in right direction :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/111#discussion_r124043213
--- Diff:
gora-aerospike/src/test/java/org/apache/gora/aerospike/GoraAerospikeTestDriver.java
---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache
Github user djkevincr commented on a diff in the pull request:
https://github.com/apache/gora/pull/111#discussion_r124040382
--- Diff: gora-aerospike/pom.xml ---
@@ -0,0 +1,153 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/109
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/109
+1, Looks good. @alfonsonishikawa Can you please have a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/104
@madhawa-gunasekara I am getting following error when I build the PR
changes locally can you please check?
[INFO
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/107
Merged the PR, thank you very much @nishadi :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/107
@lewismc Will merge it to the master. @nishadi Thanks for the PR. This is
great :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/103
+1 for merge to master, will let others to review. Thanks for contribution
@nishadi Good work :)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user djkevincr commented on the issue:
https://github.com/apache/gora/pull/102
+1 from my end as well, great work @nishadi :) Thank you for the
contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
1 - 100 of 128 matches
Mail list logo
