Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/131#discussion_r176906710
--- Diff: gora-core/src/main/java/org/apache/gora/util/IOUtils.java ---
@@ -434,7 +432,7 @@ public static void writeBoolArray(DataOutput out,
boolean
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/131#discussion_r176771580
--- Diff: gora-core/src/main/java/org/apache/gora/util/IOUtils.java ---
@@ -434,7 +432,7 @@ public static void writeBoolArray(DataOutput out,
boolean
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/131
sorry @lewismc I didn't submitted, I just did now.
---
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/131#discussion_r174723758
--- Diff:
gora-lucene/src/main/java/org/apache/gora/lucene/store/LuceneStore.java ---
@@ -0,0 +1,475 @@
+/**
+ * Licensed to the Apache Software
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/131#discussion_r174717006
--- Diff: gora-core/src/main/java/org/apache/gora/util/IOUtils.java ---
@@ -611,8 +609,7 @@ public static void writeStringArray(DataOutput out,
String
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/131#discussion_r174718062
--- Diff:
gora-lucene/src/main/java/org/apache/gora/lucene/query/LuceneResult.java ---
@@ -0,0 +1,122 @@
+/**
+ * Licensed to the Apache Software
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/131#discussion_r174716112
--- Diff: gora-core/src/main/java/org/apache/gora/util/IOUtils.java ---
@@ -434,7 +432,7 @@ public static void writeBoolArray(DataOutput out,
boolean
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/131#discussion_r174719493
--- Diff:
gora-lucene/src/main/java/org/apache/gora/lucene/query/LuceneResult.java ---
@@ -0,0 +1,122 @@
+/**
+ * Licensed to the Apache Software
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/131#discussion_r174715638
--- Diff: gora-core/src/main/java/org/apache/gora/avro/store/AvroStore.java
---
@@ -50,8 +48,7 @@
* An adapter DataStore for binary-compatible Avro
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/131#discussion_r174720104
--- Diff:
gora-lucene/src/main/java/org/apache/gora/lucene/store/LuceneMapping.java ---
@@ -0,0 +1,50 @@
+/**
+ * Licensed to the Apache Software
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/131#discussion_r174718491
--- Diff:
gora-lucene/src/main/java/org/apache/gora/lucene/query/LuceneResult.java ---
@@ -0,0 +1,122 @@
+/**
+ * Licensed to the Apache Software
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/131
if you look at the file committed then you should see them. Although I also
see them directly here in the PR page.
---
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/131
Hey @lewismc
This looks awesome! Thanks a lot for doing this! I went over the code
quickly and I left some questions and nitpicks, feel free to update whenever
you have time and ping me back
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/130
Hi @alfonsonishikawa , thanks for doing this!
I think the first option was also ok because one thing is logging what the
problem was and other throwing the exception for the application using
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/127
@alfonsonishikawa Thanks for doing this!
---
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/125
ð thanks @lewismc
---
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/125
nice one @lewismc ! can I ask how you spotted this?
---
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/110
Hi @madhawa-gunasekara ,
Sorry for the late reply, but to handle that case why don't just do the
mapping manually as we currently do and only serialize differently? So what I
had in mind
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/110#discussion_r130792458
--- Diff:
gora-cassandra-cql/src/main/java/org/apache/gora/cassandra/serializers/CassandraQueryFactory.java
---
@@ -0,0 +1,701
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/111#discussion_r129933133
--- Diff: gora-aerospike/pom.xml ---
@@ -71,6 +71,14 @@
+org.apache.maven.plugins
+maven-surefire
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/109
this looks to me +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/97
thanks @vaibhavthapliyal !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/97
@lewismc regarding the 2space vs 4space, the only issue with this is that
now the whole AccumuloStore looks like if it was modified, didn't we had a
style check on maven at some point? maybe we
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/97
@vaibhavthapliyal @lewismc I applied the PR and gora-accumulo passed all
tests successfully ð
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/94
I have seen this as well but as the error points out it is the
CassandraDeamon not being able to be stopped.
2017-02-16 10:35:12,496 ERROR [StorageServiceShutdownHook
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/94
none @lewismc , would you mind committing this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/86#discussion_r77372183
--- Diff:
gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java ---
@@ -57,13 +57,7 @@
import org.apache.hadoop.hbase.HBaseConfiguration
GitHub user renato2099 opened a pull request:
https://github.com/apache/gora/pull/86
GORA-443 Upgrade HBase to 1.2.0
Work in progress for updating gora to 1.2.2. I also looked at @lewismc 's
work ;)
All of tests pass when run individually, but when run as a whole some of
them
Github user renato2099 commented on the issue:
https://github.com/apache/gora/pull/71
Done @lewismc, please let me know what you think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user renato2099 opened a pull request:
https://github.com/apache/gora/pull/71
Gora 482 - Moving Gora to support only Hadoop2
Tests pass, but there are some extra hadoop dependencies that we don't seem
to use any more, so they are commented out for now.
hadoop-common
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/68#issuecomment-221812629
:+1: Thanks @lewismc !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/61#issuecomment-221799177
Thanks @lewismc @djkevincr ! This looks much more to what we needed :D
Awesome work!
---
If your project is set up for it, you can reply to this email and have your
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/62#issuecomment-217940582
nice one @lewismc
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/61#issuecomment-215258302
it's pretty cool stuff @djkevincr ! But I think we need to go over it. My
main concern is the addition of the clearField method to the Persistent class.
Two main
Github user renato2099 closed the pull request at:
https://github.com/apache/gora/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/59#issuecomment-214783552
Thanks @otrack ! Great work indeed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/59#issuecomment-205292664
Really cool for sure :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/56#issuecomment-197347604
yeah I think we can at least start moving that direction :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/56#issuecomment-197380002
there still some more work to get it done, but I think we are moving in the
right direction with this :)
---
If your project is set up for it, you can reply
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/56#issuecomment-193119652
This is awesome mate! I really thought I had lost this.
Maybe we can commit this as an initial patch and start working from there?
wdyt @lewismc ?
---
If your
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/51#issuecomment-172539082
Can you commit this and the other PRs @lewismc please? I don't know why I
don't have right to actually do the merging myself. Thanks man!
---
If your project is set up
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/51#issuecomment-172681580
got it, then you wanna merge? or should I? :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/51#issuecomment-172680924
I can commit through the cmd line git commands, but I can't merge the PR
from the github website, can you do that? or do you the commits directly from
the cmd line
GitHub user renato2099 opened a pull request:
https://github.com/apache/gora/pull/52
GORA-460
Closing properties file before returning the file name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/renato2099/gora GORA-460
GitHub user renato2099 opened a pull request:
https://github.com/apache/gora/pull/51
GORA-459
Fixing HBaseClusterSingleton.java unclosed resources returned from
HBaseTestingUtility
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/50#issuecomment-171240844
+1 from me too, thanks @lewismc @dobromyslov @gerhardgossen!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/48#issuecomment-170537424
but overall LGTM
maybe adding a new JIRA for testing the filter operation over gora-core
implementation? And thanks for doing this Lewis! great work!
---
If your
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/48#discussion_r49316977
--- Diff: gora-core/src/main/java/org/apache/gora/filter/FilterList.java ---
@@ -101,8 +109,25 @@ public void write(DataOutput out) throws IOException
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/48#issuecomment-170584324
awesome @lewismc ! thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-151674809
Hey @kamaci I think I will try to respond to myself lol I think it is fine
because the query object gets created by the dataStore, thus it will already
contain
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/43#issuecomment-145287775
I am in favour of this, but yeah we might discuss about the API some more
to see whether it makes sense to keep what. I mean right now, if those
parameters
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/41#issuecomment-137985824
Cool! This looks awesome @kamaci ! Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/38#discussion_r38694058
--- Diff: gora-solr/src/main/java/org/apache/gora/solr/store/SolrStore.java
---
@@ -783,9 +783,7 @@ public void flush() {
@Override
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/32#discussion_r38468879
--- Diff:
gora-accumulo/src/main/java/org/apache/gora/accumulo/store/AccumuloStore.java
---
@@ -142,7 +142,7 @@ public Object fromBytes(Schema schema, byte
Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/32#discussion_r38273525
--- Diff:
gora-accumulo/src/main/java/org/apache/gora/accumulo/store/AccumuloStore.java
---
@@ -248,7 +247,6 @@ public K fromBytes(ClassK clazz, byte[] val
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/30#issuecomment-135760629
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/23#issuecomment-135262976
hey guys, let's just push it forward, and deal with it later on. IMO the
changes proposed by @gerhardgossen make sense and I am happy he took the time
to nail it down
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/24#issuecomment-135263045
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/23#issuecomment-98393003
@gerhardgossen so you mean just to overwrite the value without checking if
it exists or not? I think this is also something that makes sense, but this
would still mean
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/23#issuecomment-94309903
Thanks a lot for the explanation @gerhardgossen! And yes this is a problem
we have seen in other data stores as well. I mean managing complex data types
because not all
Github user renato2099 commented on the pull request:
https://github.com/apache/gora/pull/23#issuecomment-93244390
Besides Henry's comment, I think this looks to me, thanks for the patch
Gerhard!
Can you merge this @hsaputra please? or do you want me to do it?
---
If your
Github user renato2099 closed the pull request at:
https://github.com/apache/gora/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user renato2099 opened a pull request:
https://github.com/apache/gora/pull/1
Trunk
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/renato2099/gora trunk
Alternatively you can review and apply these changes as the patch
63 matches
Mail list logo
