[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=227259=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-227259 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 14/Apr/19 00:45 Start Date: 14/Apr/19 00:45 Worklog Time Spent: 10m Work Description: asfgit commented on pull request #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 227259) Time Spent: 3h 50m (was: 3h 40m) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 3h 50m > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=225901=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-225901 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 11/Apr/19 01:09 Start Date: 11/Apr/19 01:09 Worklog Time Spent: 10m Work Description: guoyuepeng commented on issue #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492#issuecomment-481927330 hi could you rebase and resubmit it again? Thanks, William This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 225901) Time Spent: 3h 40m (was: 3.5h) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=224821=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-224821 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 09/Apr/19 08:35 Start Date: 09/Apr/19 08:35 Worklog Time Spent: 10m Work Description: guoyuepeng commented on issue #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492#issuecomment-481157163 Will merge this after 0.5.0 is merged into master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 224821) Time Spent: 3.5h (was: 3h 20m) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=224213=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-224213 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 08/Apr/19 06:59 Start Date: 08/Apr/19 06:59 Worklog Time Spent: 10m Work Description: RodionGork commented on issue #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492#issuecomment-480708435 @chemikadze I've made changes in the measure code according to your hint. I only was not sure if we should change the "external" interface of `MetricWrapper`, but then judged it could be extended whenever we want, so left it as is. Tested the whole stuff locally - and hope to repeat this tomorrow for demo. c506980 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 224213) Time Spent: 3h (was: 2h 50m) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=223057=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-223057 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 04/Apr/19 15:57 Start Date: 04/Apr/19 15:57 Worklog Time Spent: 10m Work Description: chemikadze commented on issue #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492#issuecomment-479957657 @RodionGork let update logic in measure attaching applicationId to metrics in new format This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 223057) Time Spent: 2h 50m (was: 2h 40m) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[
https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=222411=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222411
]
ASF GitHub Bot logged work on GRIFFIN-244:
--
Author: ASF GitHub Bot
Created on: 03/Apr/19 16:55
Start Date: 03/Apr/19 16:55
Worklog Time Spent: 10m
Work Description: RodionGork commented on pull request #492: GRIFFIN-244
get metrics by instance
URL: https://github.com/apache/griffin/pull/492#discussion_r271838431
##
File path:
service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java
##
@@ -211,9 +213,13 @@ private static String buildBasicAuthString(String user,
String password) {
@Override
public MetricValue getMetric(String applicationId) throws IOException {
-Map map = new HashMap<>();
-map.put("q", "applicationId:" + applicationId);
-Response response = client.performRequest("GET", urlGet, map);
+Response response0 = client.performRequest(
Review comment:
@dershovGD thanks a lot, it was debug stuff. Let me get rid of it...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 222411)
Time Spent: 2h 40m (was: 2.5h)
> [Service, Metric]Implement possibility to get metrics for certain Job
> Instance Id
> -
>
> Key: GRIFFIN-244
> URL: https://issues.apache.org/jira/browse/GRIFFIN-244
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> In addition to functionality described in tasks
> https://issues.apache.org/jira/browse/GRIFFIN-240,
> https://issues.apache.org/jira/browse/GRIFFIN-233 and
> https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient
> to have a possibility to obtain the metrics for given Job Instance Id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[
https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=222402=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222402
]
ASF GitHub Bot logged work on GRIFFIN-244:
--
Author: ASF GitHub Bot
Created on: 03/Apr/19 16:47
Start Date: 03/Apr/19 16:47
Worklog Time Spent: 10m
Work Description: dershovGD commented on pull request #492: GRIFFIN-244
get metrics by instance
URL: https://github.com/apache/griffin/pull/492#discussion_r271835189
##
File path:
service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java
##
@@ -211,9 +213,13 @@ private static String buildBasicAuthString(String user,
String password) {
@Override
public MetricValue getMetric(String applicationId) throws IOException {
-Map map = new HashMap<>();
-map.put("q", "applicationId:" + applicationId);
-Response response = client.performRequest("GET", urlGet, map);
+Response response0 = client.performRequest(
Review comment:
Looks like this value never used.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 222402)
Time Spent: 2.5h (was: 2h 20m)
> [Service, Metric]Implement possibility to get metrics for certain Job
> Instance Id
> -
>
> Key: GRIFFIN-244
> URL: https://issues.apache.org/jira/browse/GRIFFIN-244
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> In addition to functionality described in tasks
> https://issues.apache.org/jira/browse/GRIFFIN-240,
> https://issues.apache.org/jira/browse/GRIFFIN-233 and
> https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient
> to have a possibility to obtain the metrics for given Job Instance Id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[
https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=222122=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222122
]
ASF GitHub Bot logged work on GRIFFIN-244:
--
Author: ASF GitHub Bot
Created on: 03/Apr/19 02:11
Start Date: 03/Apr/19 02:11
Worklog Time Spent: 10m
Work Description: chemikadze commented on pull request #492: GRIFFIN-244
get metrics by instance
URL: https://github.com/apache/griffin/pull/492#discussion_r271557391
##
File path:
service/src/main/java/org/apache/griffin/core/metric/model/MetricValue.java
##
@@ -61,4 +72,38 @@ public void setTmst(Long tmst) {
public void setValue(Map value) {
this.value = value;
}
+
+public String getApplicationId() {
Review comment:
Suddenly I've realized that probably more extensible way would be to have
"metadata" map on metric, instead of fixed "applicationId" value. Who knows
what can be useful later.
I know that applicationId is already part of the code base, but as it's not
read from anywhere and we did not release that code, it can be right moment to
change it. But later we'll be at point of no return.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 222122)
Time Spent: 2h (was: 1h 50m)
> [Service, Metric]Implement possibility to get metrics for certain Job
> Instance Id
> -
>
> Key: GRIFFIN-244
> URL: https://issues.apache.org/jira/browse/GRIFFIN-244
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> In addition to functionality described in tasks
> https://issues.apache.org/jira/browse/GRIFFIN-240,
> https://issues.apache.org/jira/browse/GRIFFIN-233 and
> https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient
> to have a possibility to obtain the metrics for given Job Instance Id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=222121=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222121 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 03/Apr/19 02:05 Start Date: 03/Apr/19 02:05 Worklog Time Spent: 10m Work Description: chemikadze commented on pull request #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 222121) Time Spent: 1h 50m (was: 1h 40m) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin (Incubating) > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=221675=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221675 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 02/Apr/19 10:02 Start Date: 02/Apr/19 10:02 Worklog Time Spent: 10m Work Description: RodionGork commented on issue #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#issuecomment-478929334 Now #492 is a new, squashed version of this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 221675) Time Spent: 1h 40m (was: 1.5h) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin (Incubating) > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=221661=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221661 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 02/Apr/19 09:33 Start Date: 02/Apr/19 09:33 Worklog Time Spent: 10m Work Description: RodionGork commented on pull request #492: GRIFFIN-244 get metrics by instance URL: https://github.com/apache/griffin/pull/492 This is just a squashed version of #491 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 221661) Time Spent: 1.5h (was: 1h 20m) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin (Incubating) > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=221612=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221612 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 02/Apr/19 05:41 Start Date: 02/Apr/19 05:41 Worklog Time Spent: 10m Work Description: RodionGork commented on issue #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#issuecomment-478852679 @chemikadze rebase leads to conflicts resolving... Thus I'd better have all this stuff squashed and pushed as @dershovGD (we probably have no practical sense in intermediate commits too), if no one's minds. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 221612) Time Spent: 1h 20m (was: 1h 10m) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin (Incubating) > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=221605=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221605 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 02/Apr/19 04:16 Start Date: 02/Apr/19 04:16 Worklog Time Spent: 10m Work Description: chemikadze commented on issue #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#issuecomment-478838049 @RodionGork these merge commits have no practical sense, please rebase ontop of fresh master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 221605) Time Spent: 1h (was: 50m) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin (Incubating) > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[
https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=221123=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-221123
]
ASF GitHub Bot logged work on GRIFFIN-244:
--
Author: ASF GitHub Bot
Created on: 01/Apr/19 06:52
Start Date: 01/Apr/19 06:52
Worklog Time Spent: 10m
Work Description: RodionGork commented on pull request #491: GRIFFIN-244
Get metrics by instance
URL: https://github.com/apache/griffin/pull/491#discussion_r270732965
##
File path:
service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java
##
@@ -206,4 +208,14 @@ private static String buildBasicAuthString(String user,
String password) {
return String.format("Basic %s", Base64.getEncoder().encodeToString(
auth.getBytes()));
}
+
+@Override
+public MetricValue getMetric(String applicationId) throws IOException {
+Map map =new HashMap<>();
+map.put("q", "applicationId:"+applicationId);
Review comment:
`Collections.singletonMap()` probably can be used
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 221123)
Time Spent: 50m (was: 40m)
> [Service, Metric]Implement possibility to get metrics for certain Job
> Instance Id
> -
>
> Key: GRIFFIN-244
> URL: https://issues.apache.org/jira/browse/GRIFFIN-244
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In addition to functionality described in tasks
> https://issues.apache.org/jira/browse/GRIFFIN-240,
> https://issues.apache.org/jira/browse/GRIFFIN-233 and
> https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient
> to have a possibility to obtain the metrics for given Job Instance Id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=220861=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220861 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 30/Mar/19 09:07 Start Date: 30/Mar/19 09:07 Worklog Time Spent: 10m Work Description: RodionGork commented on issue #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#issuecomment-478223535 @chemikadze please come to see this... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 220861) Time Spent: 40m (was: 0.5h) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin (Incubating) > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[
https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=220551=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220551
]
ASF GitHub Bot logged work on GRIFFIN-244:
--
Author: ASF GitHub Bot
Created on: 29/Mar/19 14:27
Start Date: 29/Mar/19 14:27
Worklog Time Spent: 10m
Work Description: dershovGD commented on pull request #491: GRIFFIN-244
Get metrics by instance
URL: https://github.com/apache/griffin/pull/491#discussion_r270432048
##
File path: service/pom.xml
##
@@ -110,11 +110,11 @@ under the License.
postgresql
${postgresql.version}
-
Review comment:
I've commented it back.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 220551)
Time Spent: 0.5h (was: 20m)
> [Service, Metric]Implement possibility to get metrics for certain Job
> Instance Id
> -
>
> Key: GRIFFIN-244
> URL: https://issues.apache.org/jira/browse/GRIFFIN-244
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In addition to functionality described in tasks
> https://issues.apache.org/jira/browse/GRIFFIN-240,
> https://issues.apache.org/jira/browse/GRIFFIN-233 and
> https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient
> to have a possibility to obtain the metrics for given Job Instance Id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=220550=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220550 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 29/Mar/19 14:26 Start Date: 29/Mar/19 14:26 Worklog Time Spent: 10m Work Description: dershovGD commented on pull request #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#discussion_r270431694 ## File path: service/src/main/java/org/apache/griffin/core/exception/GriffinExceptionMessage.java ## @@ -72,7 +72,9 @@ Licensed to the Apache Software Foundation (ASF) under one HDFS_FILE_NOT_EXIST(40407, "Hadoop data file not exist"), -PREDICATE_TYPE_NOT_FOUND(40408, "Unknown predicate type"), +JOB_INSTANCE_NOT_FOUND(40408, "No job instances with given job instance id found"), + +PREDICATE_TYPE_NOT_FOUND(40409, "Unknown predicate type"), Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 220550) Time Spent: 20m (was: 10m) > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin (Incubating) > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[ https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=220527=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220527 ] ASF GitHub Bot logged work on GRIFFIN-244: -- Author: ASF GitHub Bot Created on: 29/Mar/19 13:35 Start Date: 29/Mar/19 13:35 Worklog Time Spent: 10m Work Description: RodionGork commented on pull request #491: GRIFFIN-244 Get metrics by instance URL: https://github.com/apache/griffin/pull/491#discussion_r270405608 ## File path: service/src/main/java/org/apache/griffin/core/exception/GriffinExceptionMessage.java ## @@ -72,7 +72,9 @@ Licensed to the Apache Software Foundation (ASF) under one HDFS_FILE_NOT_EXIST(40407, "Hadoop data file not exist"), -PREDICATE_TYPE_NOT_FOUND(40408, "Unknown predicate type"), +JOB_INSTANCE_NOT_FOUND(40408, "No job instances with given job instance id found"), + +PREDICATE_TYPE_NOT_FOUND(40409, "Unknown predicate type"), Review comment: This probably makes duplication with the next one. At least when requesting non-existing instance, I got `Unknown predicate type` in response :o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 220527) Time Spent: 10m Remaining Estimate: 0h > [Service, Metric]Implement possibility to get metrics for certain Job > Instance Id > - > > Key: GRIFFIN-244 > URL: https://issues.apache.org/jira/browse/GRIFFIN-244 > Project: Griffin (Incubating) > Issue Type: New Feature >Reporter: Dmitry Ershov >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In addition to functionality described in tasks > https://issues.apache.org/jira/browse/GRIFFIN-240, > https://issues.apache.org/jira/browse/GRIFFIN-233 and > https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient > to have a possibility to obtain the metrics for given Job Instance Id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (GRIFFIN-244) [Service, Metric]Implement possibility to get metrics for certain Job Instance Id
[
https://issues.apache.org/jira/browse/GRIFFIN-244?focusedWorklogId=220528=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-220528
]
ASF GitHub Bot logged work on GRIFFIN-244:
--
Author: ASF GitHub Bot
Created on: 29/Mar/19 13:35
Start Date: 29/Mar/19 13:35
Worklog Time Spent: 10m
Work Description: RodionGork commented on pull request #491: GRIFFIN-244
Get metrics by instance
URL: https://github.com/apache/griffin/pull/491#discussion_r270409323
##
File path: service/pom.xml
##
@@ -110,11 +110,11 @@ under the License.
postgresql
${postgresql.version}
-
Review comment:
let's revert it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 220528)
Time Spent: 10m
Remaining Estimate: 0h
> [Service, Metric]Implement possibility to get metrics for certain Job
> Instance Id
> -
>
> Key: GRIFFIN-244
> URL: https://issues.apache.org/jira/browse/GRIFFIN-244
> Project: Griffin (Incubating)
> Issue Type: New Feature
>Reporter: Dmitry Ershov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In addition to functionality described in tasks
> https://issues.apache.org/jira/browse/GRIFFIN-240,
> https://issues.apache.org/jira/browse/GRIFFIN-233 and
> https://issues.apache.org/jira/browse/GRIFFIN-234 it will be very convenient
> to have a possibility to obtain the metrics for given Job Instance Id.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
