[GitHub] incubator-griffin issue #381: GRIFFIN-164 GRIFFIN-186 GRIFFIN-187: Profiling...
Github user spencer-hivert-ck commented on the issue: https://github.com/apache/incubator-griffin/pull/381 Thanks for taking a look at my PR @icesmartjuan! I'm unable to re-produce any of the errors you've mentioned above. Regarding #2, I've added default values to the fields in step 3, so that error should not occur. Regarding #3, I didn't change the accuracy or job code, so that error may be unrelated. I brought up a fresh version of the service/ui and was unable to re-produce the failures described above. Are you able to provide more detailed steps and/or photos so I can attempt to re-produce these errors myself! Thank you. ---
[GitHub] incubator-griffin pull request #381: GRIFFIN-164 GRIFFIN-186 GRIFFIN-187: Pr...
GitHub user spencer-hivert-ck opened a pull request: https://github.com/apache/incubator-griffin/pull/381 GRIFFIN-164 GRIFFIN-186 GRIFFIN-187: Profiling Re-factor + Regex/Empty String Support We've been working away on Griffin here at Credit Karma, and we'd love to contribute back! This PR tackles three separate tasks: - [GRIFFIN-164](https://issues.apache.org/jira/browse/GRIFFIN-164): Regex Support - [GRIFFIN-186](https://issues.apache.org/jira/browse/GRIFFIN-186): Create Profiling Measure Re-Factor - [GRIFFIN-187](https://issues.apache.org/jira/browse/GRIFFIN-187): Empty String Support The details for each of these tasks can be found in the JIRA tickets linked above! You can merge this pull request into a Git repository by running: $ git pull https://github.com/spencer-hivert-ck/incubator-griffin shivert/profiling-refactor-and-regex-support Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-griffin/pull/381.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #381 commit c4a344d7b771946ad41d9c89aa381b3925105464 Author: Spencer Hivert Date: 2018-08-01T19:32:18Z GRIFFIN-164 GRIFFIN-186 GRIFFIN-187: Profiling Re-factor + Regex/Empty String Support ---
