[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

Github user bhlx3lyx7 commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224957455 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,20 @@

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224956565 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,20 @@

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224956533 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,20 @@

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

Github user guoyuepeng commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224486025 --- Diff: measure/src/main/scala/org/apache/griffin/measure/configuration/dqdefinition/DQConfig.scala --- @@ -74,9 +74,9 @@ case class

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224438517 --- Diff: measure/src/test/scala/org/apache/griffin/measure/transformations/AccuracyTransformationsIntegrationTest.scala --- @@ -0,0 +1,169 @@

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224432819 --- Diff: measure/src/main/scala/org/apache/griffin/measure/configuration/dqdefinition/DQConfig.scala --- @@ -148,12 +148,12 @@ case class

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224431040 --- Diff: measure/src/main/scala/org/apache/griffin/measure/configuration/dqdefinition/DQConfig.scala --- @@ -74,9 +74,9 @@ case class

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224425167 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,26 @@

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

Github user ashutakGG commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224424475 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,26 @@

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224151599 --- Diff: measure/src/test/scala/org/apache/griffin/measure/transformations/AccuracyTransformationsIntegrationTest.scala --- @@ -0,0 +1,169

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224152545 --- Diff: measure/src/main/scala/org/apache/griffin/measure/configuration/dqdefinition/DQConfig.scala --- @@ -148,12 +148,12 @@ case class

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224152055 --- Diff: measure/src/main/scala/org/apache/griffin/measure/configuration/dqdefinition/DQConfig.scala --- @@ -74,9 +74,9 @@ case class

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/434#discussion_r224150071 --- Diff: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/AccuracyExpr2DQSteps.scala --- @@ -125,14 +126,26 @@

[GitHub] incubator-griffin pull request #434: Griffin-205: accuracy matched fraction

GitHub user ashutakGG opened a pull request: https://github.com/apache/incubator-griffin/pull/434 Griffin-205: accuracy matched fraction https://issues.apache.org/jira/browse/GRIFFIN-205 This pull request covers only batch dq type. We need to decide is it worth to add