Re: Compiling groovy with java9 using maven with spring boot

2017-11-20 Thread Leonard Brünings
Hi, its correct not to include a module-info.java, however groovy should define its Automatic-Module-Name. http://blog.joda.org/2017/05/java-se-9-jpms-automatic-modules.html Many other projects are already doing it, e.g., https://github.com/mockito/mockito/issues/1189 Until the fine graine

Re: Compiling groovy with java9 using maven with spring boot

2017-11-20 Thread Cédric Champeau
Thank you Paul! 2017-11-20 14:59 GMT+01:00 Paul King : > I created an issue to track this: > https://issues.apache.org/jira/browse/GROOVY-8387 > > On Mon, Nov 20, 2017 at 5:47 PM, Uwe Schindler wrote: > >> Hi, >> >> Yes, this is risky when you update ASM to 6.0. I had the same issue >> during re

Re: Compiling groovy with java9 using maven with spring boot

2017-11-20 Thread Paul King
I created an issue to track this: https://issues.apache.org/jira/browse/GROOVY-8387 On Mon, Nov 20, 2017 at 5:47 PM, Uwe Schindler wrote: > Hi, > > Yes, this is risky when you update ASM to 6.0. I had the same issue during > repackage, but I fixed it: > > https://github.com/policeman-tools/forbi

Re: Compiling groovy with java9 using maven with spring boot

2017-11-19 Thread Uwe Schindler
Hi, Yes, this is risky when you update ASM to 6.0. I had the same issue during repackage, but I fixed it: https://github.com/policeman-tools/forbidden-apis/commit/1654d5d38e40ee500ca7ae82b146ed6fcfba0827 Am 20. November 2017 08:34:02 MEZ schrieb "Cédric Champeau" : >I don't find any evidence o

Re: Compiling groovy with java9 using maven with spring boot

2017-11-19 Thread Cédric Champeau
I don't find any evidence of `module-info` file on `master` or 2.6.X. On the other hand, we have the ASM module-info file bundled, because we repackage. This is a mistake that needs to be fixed. So, false alarm, Daniel: WE didn't add a module-info file: a dependency of ours, ASM, has one, and when

Re: Compiling groovy with java9 using maven with spring boot

2017-11-19 Thread Cédric Champeau
We should remove it: it doesn't make sense to have a module info at this point, when we don't even know what we require, export, and when all of our dependencies are not modules. And I'm not talking about our different artifacts. If this was an experiment, it shouldn't have landed on master. It wil

Re: Compiling groovy with java9 using maven with spring boot

2017-11-19 Thread Daniel Sun
Hi Cédric, I do not know who contributed the module-info, which seems to exist for a long time. Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Re: Compiling groovy with java9 using maven with spring boot

2017-11-19 Thread Cédric Champeau
Since when did we integrate a module info file? We should not. Please, stop integrating such changes without discussions. Le 20 nov. 2017 8:10 AM, "Daniel Sun" a écrit : > Please try to use Groovy 2.6.0, which is designed as a fat module and > contains a module-info class file. > > Cheers, > Dan

Re: Compiling groovy with java9 using maven with spring boot

2017-11-19 Thread Daniel Sun
Please try to use Groovy 2.6.0, which is designed as a fat module and contains a module-info class file. Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html

Compiling groovy with java9 using maven with spring boot

2017-11-19 Thread yugantshah
Hello, Tried to compile a spring boot application with groovy+java9, however it does not detect the main class which is in groovy. Can anyone please point to a sample which consists of groovy , java9 , maven with spring boot -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.