Re: [VOTE] Release Groovy 2.6.0-alpha-3
+1 (binding) with comments/caveats below. Cheers, Paul. Checked signatures and checksums Checked building from source with the following tasks: install installGroovy dist testAll with one test failure[*] Rat[**] found one 3-line test file without a header: subprojects/parser-antlr4/src/test/resources/core/LocalVariableDeclaration_02x.groovy I did some preliminary testing of native lambdas using this test example: ``` @ groovy.transform.CompileStatic def method() { //[1, 2, 3].collect(e -> e.plus 1)// Ex1: JDK 7 & 8 [1, 2, 3].stream().map(e -> e + 1).toList() // Ex2: JDK 8 } println method() ``` The examples above worked fine and appeared to produce the correct bytecode. However, when using "e.plus 1" in my Ex2, I got: java.lang.NoSuchMethodError: java.lang.Number.plus(Ljava/lang/Number;)Ljava/lang/Number; I wasn't sure if this was expected or not. I am unsure whether this is expected behavior but even if not, I don't see this as necessarily important enough to hold up an alpha release. Numerous examples do work as I expected and we'll get much more feedback with the release out. * MemoizeAtMostTest#testMemoizeAtMostConcurrently failed which, although possibly deserves further investigation, has been fixed since the release was cut with a change in the test which would have passed. It doesn't impact prod code so I believe shouldn't hold up the release. ** Our quality build skips the parser-antlr4 directory when checking since it isn't a real project. We should fix this but it can wait until after this release. On Tue, Mar 6, 2018 at 5:24 AM, John Wagenleitner < john.wagenleit...@gmail.com> wrote: > +1 (binding) > > On Fri, Mar 2, 2018 at 8:21 AM, Daniel.Sunwrote: > >> Dear development community, >> >> I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-3 release! >> >> This release includes 18 bug fixes/improvements as outlined in the >> changelog: >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje >> ctId=12318123=12342190 >> >> Tag: >> https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag >> ;h=refs/tags/GROOVY_2_6_0_ALPHA_3 >> Tag commit id: a13a16fd09c7892d4db1b8c107035a0527c81f4b >> >> The artifacts to be voted on are located as follows (r25377). >> Source release: >> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-3/sources >> Convenience binaries: >> https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-3/distribution >> >> Release artifacts are signed with a key from the following file: >> https://dist.apache.org/repos/dist/dev/groovy/KEYS >> >> Please vote on releasing this package as Apache Groovy 2.6.0-alpha-3. >> >> Reminder on ASF release approval requirements for PMC members: >> http://www.apache.org/legal/release-policy.html#release-approval >> Hints on validating checksums/signatures (but replace md5sum with >> sha256sum): >> https://www.apache.org/info/verification.html >> >> The vote is open for the next 72 hours and passes if a majority of at >> least >> three +1 PMC votes are cast. >> >> [ ] +1 Release Apache Groovy 2.6.0-alpha-3 >> [ ] 0 I don't have a strong opinion about this, but I assume it's ok >> [ ] -1 Do not release Apache Groovy 2.6.0-alpha-3 because... >> >> Here is my vote: >> >> +1 (binding) >> >> >> >> >> -- >> Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html >> > >
Re: [VOTE] Release Groovy 2.6.0-alpha-3
+1 (binding) On Fri, Mar 2, 2018 at 8:21 AM, Daniel.Sunwrote: > Dear development community, > > I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-3 release! > > This release includes 18 bug fixes/improvements as outlined in the > changelog: > https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12318123=12342190 > > Tag: > https://git1-us-west.apache.org/repos/asf?p=groovy.git;a= > tag;h=refs/tags/GROOVY_2_6_0_ALPHA_3 > Tag commit id: a13a16fd09c7892d4db1b8c107035a0527c81f4b > > The artifacts to be voted on are located as follows (r25377). > Source release: > https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-3/sources > Convenience binaries: > https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-3/distribution > > Release artifacts are signed with a key from the following file: > https://dist.apache.org/repos/dist/dev/groovy/KEYS > > Please vote on releasing this package as Apache Groovy 2.6.0-alpha-3. > > Reminder on ASF release approval requirements for PMC members: > http://www.apache.org/legal/release-policy.html#release-approval > Hints on validating checksums/signatures (but replace md5sum with > sha256sum): > https://www.apache.org/info/verification.html > > The vote is open for the next 72 hours and passes if a majority of at least > three +1 PMC votes are cast. > > [ ] +1 Release Apache Groovy 2.6.0-alpha-3 > [ ] 0 I don't have a strong opinion about this, but I assume it's ok > [ ] -1 Do not release Apache Groovy 2.6.0-alpha-3 because... > > Here is my vote: > > +1 (binding) > > > > > -- > Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html >
Re: [VOTE] Release Groovy 2.6.0-alpha-3
+1 On 02.03.2018 17:21, Daniel.Sun wrote: Dear development community, I am happy to start the VOTE thread for a Groovy 2.6.0-alpha-3 release! This release includes 18 bug fixes/improvements as outlined in the changelog: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12342190 Tag: https://git1-us-west.apache.org/repos/asf?p=groovy.git;a=tag;h=refs/tags/GROOVY_2_6_0_ALPHA_3 Tag commit id: a13a16fd09c7892d4db1b8c107035a0527c81f4b The artifacts to be voted on are located as follows (r25377). Source release: https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-3/sources Convenience binaries: https://dist.apache.org/repos/dist/dev/groovy/2.6.0-alpha-3/distribution Release artifacts are signed with a key from the following file: https://dist.apache.org/repos/dist/dev/groovy/KEYS Please vote on releasing this package as Apache Groovy 2.6.0-alpha-3. Reminder on ASF release approval requirements for PMC members: http://www.apache.org/legal/release-policy.html#release-approval Hints on validating checksums/signatures (but replace md5sum with sha256sum): https://www.apache.org/info/verification.html The vote is open for the next 72 hours and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release Apache Groovy 2.6.0-alpha-3 [ ] 0 I don't have a strong opinion about this, but I assume it's ok [ ] -1 Do not release Apache Groovy 2.6.0-alpha-3 because... Here is my vote: +1 (binding) -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html
Re: [VOTE] Release Groovy 2.6.0-alpha-3
If you are using Java8 and want to try the native lambda, please add addition JVM options( `-Dgroovy.target.bytecode=1.7 -Dgroovy.antlr4=true` OR -Dgroovy.target.bytecode=1.8 -Dgroovy.antlr4=true) For example: 1) Run script via command line ``` groovy -Dgroovy.target.bytecode=1.8 -Dgroovy.antlr4=true TryNativeLambda.groovy ``` 2) Run script in groovy console a) set the environment variable `JAVA_OPTS` as `-Dgroovy.target.bytecode=1.8 -Dgroovy.antlr4=true` b) run `groovyConsole` Here is a sample script for you to try: ``` import groovy.transform.CompileStatic import java.util.stream.Collectors import java.util.stream.Stream @CompileStatic public class Test1 { public static void main(String[] args) { p(); } public static void p() { println([1, 2, 3].stream().map(e -> e.plus 1).toList()) } } ``` In next releases of 2.6.0, `-Dgroovy.target.bytecode=1.7` will be set by default. Cheers, Daniel.Sun -- Sent from: http://groovy.329449.n5.nabble.com/Groovy-Dev-f372993.html