Re: Pull request to make private methods static when they are plain functions

If a method is so big, that you can no longer see if a local variable/parameter is changed or not, then the method needs refactoring, not the variables a modifier. So I see no need for adding this, unless you want to express something by this. bye Jochen On 28.04.2016 02:11, John

Re: Pull request to make private methods static when they are plain functions

Thanks for the clarification :) On 28 Apr 2016 02:12, "John Wagenleitner" wrote: > > > On Sun, Apr 24, 2016 at 11:13 PM, Mario Garcia > wrote: > >> +1 >> >> Besides, I was wondering If most, if not all these static methods, should >> have all

Re: Pull request to make private methods static when they are plain functions

+1 Besides, I was wondering If most, if not all these static methods, should have all parameters marked as final. Is there any policy about this ? Would it help ? 2016-04-24 21:46 GMT+02:00 Jochen Theodorou : > On 24.04.2016 18:12, John Wagenleitner wrote: > >> About to merge