[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/guacamole-server/pull/156 ---

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178622107 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178622074 --- Diff: src/protocols/ssh/ssh.c --- @@ -296,9 +299,17 @@ void* ssh_client_thread(void* data) { } +/* Set up the

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178621626 --- Diff: src/protocols/ssh/ssh.c --- @@ -296,9 +299,17 @@ void* ssh_client_thread(void* data) { } +/* Set up the

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178615175 --- Diff: src/protocols/ssh/ttymode.h --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178614942 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178614574 --- Diff: src/protocols/ssh/ssh.c --- @@ -296,9 +299,17 @@ void* ssh_client_thread(void* data) { } +/* Set up the

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178542720 --- Diff: src/protocols/ssh/ssh.c --- @@ -191,6 +192,10 @@ void* ssh_client_thread(void* data) { return NULL; }

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178542688 --- Diff: src/protocols/ssh/ssh.c --- @@ -191,6 +192,10 @@ void* ssh_client_thread(void* data) { return NULL; }

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178541081 --- Diff: src/protocols/ssh/ssh.c --- @@ -296,9 +301,15 @@ void* ssh_client_thread(void* data) { } +/* Set up the

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178540964 --- Diff: src/protocols/ssh/ssh.c --- @@ -296,9 +301,15 @@ void* ssh_client_thread(void* data) { } +/* Set up the

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178533605 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178531096 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178530634 --- Diff: src/terminal/terminal.c --- @@ -1594,7 +1598,13 @@ static int __guac_terminal_send_key(guac_terminal* term, int keysym, int pressed

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178482718 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178482474 --- Diff: src/protocols/ssh/ssh.c --- @@ -296,9 +301,15 @@ void* ssh_client_thread(void* data) { } +/* Set up the

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r176918408 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r176918401 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-24 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r176917434 --- Diff: src/protocols/ssh/ttymode.h --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-18 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r175313519 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r175279241 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r175279035 --- Diff: src/terminal/terminal.c --- @@ -1594,7 +1598,13 @@ static int __guac_terminal_send_key(guac_terminal* term, int keysym, int pressed

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r175279031 --- Diff: src/terminal/terminal.c --- @@ -1594,7 +1598,13 @@ static int __guac_terminal_send_key(guac_terminal* term, int keysym, int pressed

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r175278959 --- Diff: src/protocols/ssh/ttymode.h --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r175278922 --- Diff: src/protocols/ssh/ttymode.h --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r175279222 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r175279053 --- Diff: src/protocols/telnet/settings.c --- @@ -328,6 +335,11 @@ guac_telnet_settings* guac_telnet_parse_args(guac_user* user,

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r175279204 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-03-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r175279087 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-02-27 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r170947545 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-02-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r170825324 --- Diff: src/terminal/terminal.c --- @@ -1594,7 +1599,7 @@ static int __guac_terminal_send_key(guac_terminal* term, int keysym, int pressed

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-02-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r170825936 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-02-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r170825539 --- Diff: src/protocols/ssh/settings.h --- @@ -223,6 +223,11 @@ typedef struct guac_ssh_settings { */ int

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-02-26 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r170826387 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-02-26 Thread necouchman
GitHub user necouchman opened a pull request: https://github.com/apache/guacamole-server/pull/156 GUACAMOLE-269: Allow backspace key behavior to be configured Server-side changes that allow the backspace key to be configured, and, for the SSH protocol, also pass through that