Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-29 Thread Mike Jumper
On Tue, May 29, 2018 at 12:07 PM, Nick Couchman wrote: > On Tue, May 29, 2018 at 2:59 PM, Nick Couchman wrote: > > > > > >> > > >> Perhaps the mapper needs to be bound, just like the webapp's REST > >> services? > >> > >> https://stackoverflow.com/questions/11987097/how-do-i- > >>

Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-29 Thread Nick Couchman
On Tue, May 29, 2018 at 3:19 PM, Mike Jumper wrote: > On Tue, May 29, 2018 at 11:59 AM, Nick Couchman wrote: > > > > > > > > > > > > > > > Perhaps the mapper needs to be bound, just like the webapp's REST > > services? > > > > > > https://stackoverflow.com/questions/11987097/how-do-i- > > >

Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-29 Thread Mike Jumper
On Tue, May 29, 2018 at 11:59 AM, Nick Couchman wrote: > > > > > > > > > > Perhaps the mapper needs to be bound, just like the webapp's REST > services? > > > > https://stackoverflow.com/questions/11987097/how-do-i- > > use-a-jersey-exceptionmapper-with-google-guice > > > > > Yep, that seems to

Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-29 Thread Nick Couchman
On Tue, May 29, 2018 at 2:59 PM, Nick Couchman wrote: > > >> > >> Perhaps the mapper needs to be bound, just like the webapp's REST >> services? >> >> https://stackoverflow.com/questions/11987097/how-do-i- >> use-a-jersey-exceptionmapper-with-google-guice >> > > > Yep, that seems to be the

Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-29 Thread Nick Couchman
> > > > > > Perhaps the mapper needs to be bound, just like the webapp's REST services? > > https://stackoverflow.com/questions/11987097/how-do-i- > use-a-jersey-exceptionmapper-with-google-guice > Yep, that seems to be the ticket to getting it to work. So, next question, should this be

Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-29 Thread Mike Jumper
On Tue, May 29, 2018 at 11:02 AM, Nick Couchman wrote: > > > > IIRC, there are minimum JVM version requirements for Jersey 2.x that > >> > > historically prevented us from going that route, but if we're going to > >> require Java 7 across the board, this is doable. > >> > > > > Okay, I'll see

Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-29 Thread Nick Couchman
> > IIRC, there are minimum JVM version requirements for Jersey 2.x that >> > historically prevented us from going that route, but if we're going to >> require Java 7 across the board, this is doable. >> > > Okay, I'll see what I can figure out with that. Hopefully it won't be > necessary to make

Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-29 Thread Nick Couchman
On Mon, May 28, 2018 at 11:19 PM, Mark Nolan wrote: > Don't you see those warnings anyway? I can't check right now, but I'm > fairly certain I've seen them in the log regardless. > > Yeah, Mark, you're right, those show up in a clean build without this, so that's obviously not the issue. I

Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-28 Thread Nick Couchman
> > There may be another way, however. Jersey provides for mapping exceptions > to responses: > > https://stackoverflow.com/questions/15185299/jax-rs- > jersey-exceptionmappers-user-defined-exception > > Perhaps we could define such a mapping for GuacamoleException? > > Okay, I'm game. Took a

Re: Help with GUACAMOLE-566: Add RESTExceptionWrapper to Extensions

2018-05-28 Thread Mike Jumper
On Mon, May 28, 2018 at 12:00 PM, Nick Couchman wrote: > Hey, everyone, > I could use some help figuring out how to work this one out. GUACAMOLE-566 > deals with adding the RESTExceptionWrapper to loaded extensions such that > the extension-specific REST endpoints will deliver similar Guacamole