[GitHub] guacamole-manual pull request #83: GUACAMOLE-446: Documentation for new driv...

[necouchman]

GitHub user necouchman opened a pull request:

https://github.com/apache/guacamole-manual/pull/83

GUACAMOLE-446: Documentation for new drive-name parameter.

Documentation for the parameter allowing redirected drive name to be 
configured.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/necouchman/guacamole-manual GUACAMOLE-446

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/guacamole-manual/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit d8f6e676a1c0f1f9fb78c1e34da7baccc8d62adc
Author: Nick Couchman 
Date:   2018-02-23T16:45:39Z

GUACAMOLE-446: Documentation for new drive-name parameter.




---

[GitHub] guacamole-server pull request #155: GUACAMOLE-446: Allow redirected drive na...

[necouchman]

GitHub user necouchman opened a pull request:

https://github.com/apache/guacamole-server/pull/155

GUACAMOLE-446: Allow redirected drive name to be configured

Allows for the name of the redirected drive to be configured when pushing a 
filesystem through via RDP.

Note that this change not only allows for the name to be configured, but 
also *removes UTF-16 encoding* of the drive name as it appears that Windows 
does not expect the filesystem name to be UTF-16 encoded.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/necouchman/guacamole-server GUACAMOLE-446

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/guacamole-server/pull/155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #155


commit 5cc4defe848caa294fa8a3761f155acf41758876
Author: Nick Couchman 
Date:   2018-02-23T13:30:27Z

GUACAMOLE-446: Implement support for setting the drive name in RDP.

commit e1c727668ee35e345078339996a5ca51c8af7cc0
Author: Nick Couchman 
Date:   2018-02-23T16:07:13Z

GUACAMOLE-446: Don't convert filesystem share name to UTF-16.




---

[GitHub] guacamole-client pull request #258: GUACAMOLE-446: Allow redirected drive na...

[necouchman]

GitHub user necouchman opened a pull request:

https://github.com/apache/guacamole-client/pull/258

GUACAMOLE-446: Allow redirected drive name to be configured

Client-side changes to allow the drive name to be configured when 
redirecting a filesystem using RDP device redirection.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/necouchman/guacamole-client GUACAMOLE-446

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/guacamole-client/pull/258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #258


commit 25aafbe50e0d6a87ccddb698a488ef9008760585
Author: Nick Couchman 
Date:   2018-01-16T22:46:40Z

GUACAMOLE-445: Add client-side parameters and translations for changing 
printer name.

commit b3fbb416bea285c0fd3de2441cc2af45299d2133
Author: Nick Couchman 
Date:   2018-02-23T13:09:54Z

GUACAMOLE-446: Add parameters and translations for drive name.




---

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

[necouchman]

Github user necouchman commented on a diff in the pull request:

https://github.com/apache/guacamole-server/pull/154#discussion_r170243969
  
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c ---
@@ -141,18 +141,20 @@ static void 
guac_rdpdr_device_printer_announce_handler(guac_rdpdr_device* device
 Stream_Write(output_stream, "PRN1\0\0\0\0", 8); /* DOS name */
 
 /* Printer data */
-Stream_Write_UINT32(output_stream, 24 + GUAC_PRINTER_DRIVER_LENGTH + 
GUAC_PRINTER_NAME_LENGTH);
+char* utf16_printer_name = malloc(1);
--- End diff --

As with comment above on `realloc()`, this feels a little kludgy, but 
allows for dynamic allocation to work.


---

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

[necouchman]

Github user necouchman commented on a diff in the pull request:

https://github.com/apache/guacamole-server/pull/154#discussion_r170243837
  
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c ---
@@ -273,3 +273,15 @@ void 
guac_rdpdr_process_prn_using_xps(guac_rdpdrPlugin* rdpdr, wStream* input_st
 guac_client_log(rdpdr->client, GUAC_LOG_INFO, "Printer unexpectedly 
switched to XPS mode");
 }
 
+int guac_rdpdr_encode_utf16(const char* input_string, char* output_string) 
{
+int output_length = (strlen(input_string)+ 1) * 2;
+output_string = realloc(output_string, output_length);
--- End diff --

I'm not sure this is the best way to go about this - feels a little kludgy, 
but was trying to keep dynamic allocation.


---

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

[necouchman]

Github user necouchman commented on a diff in the pull request:

https://github.com/apache/guacamole-server/pull/154#discussion_r170243694
  
--- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_messages.c ---
@@ -273,3 +273,15 @@ void 
guac_rdpdr_process_prn_using_xps(guac_rdpdrPlugin* rdpdr, wStream* input_st
 guac_client_log(rdpdr->client, GUAC_LOG_INFO, "Printer unexpectedly 
switched to XPS mode");
 }
 
+int guac_rdpdr_encode_utf16(const char* input_string, char* output_string) 
{
--- End diff --

Not 100% certain this is the right place for this function.  Also, there 
may be something else that already does this (swprintf?), but I had a hard time 
finding good examples/documentation for plain C - most everything dealt with 
the char16_t type which seems specific to C++.


---

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

[necouchman]

GitHub user necouchman opened a pull request:

https://github.com/apache/guacamole-server/pull/154

GUACAMOLE-445: Make Printer Name Configurable

This adds the parameters and changes to rdpdr to make the printer name 
configurable in the RDP session.

I'm not sure if we had totally settled in the JIRA issue on whether or not 
this change was actually going to happen, but I went ahead and did it.  I can 
close the PR if we decide against it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/necouchman/guacamole-server GUACAMOLE-445

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/guacamole-server/pull/154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #154


commit 2d8a6f97a49a84c988dc2d28b56b1954129171a4
Author: Nick Couchman 
Date:   2018-02-23T10:03:34Z

GUACAMLE-445: Add settings for printer name.

commit 1dd56ed01b9146605adeed4ca7ac7fdeffa8b7c2
Author: Nick Couchman 
Date:   2018-02-23T10:34:44Z

GUACAMOLE-445: Pass printer name from settings to RDP session.




---

[GitHub] guacamole-manual pull request #82: GUACAMOLE-448: Document new caching param...

[necouchman]

GitHub user necouchman opened a pull request:

https://github.com/apache/guacamole-manual/pull/82

GUACAMOLE-448: Document new caching parameters for RDP connections.

Adds documentation for the caching parameters to the RDP Performance 
section in the Configuration Guacamole chapter.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/necouchman/guacamole-manual GUACAMOLE-448

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/guacamole-manual/pull/82.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #82


commit eca3d6a3064d6c63d8451f0bfd6af3ac7e643674
Author: Nick Couchman 
Date:   2018-02-23T09:48:09Z

GUACAMOLE-448: Document new caching parameters for RDP connections.




---