On Tue, May 29, 2018 at 11:02 AM, Nick Couchman wrote:
> >
> > IIRC, there are minimum JVM version requirements for Jersey 2.x that
> >>
> > historically prevented us from going that route, but if we're going to
> >> require Java 7 across the board, this is doable.
> >>
> >
> > Okay, I'll see
On Tue, May 29, 2018 at 11:59 AM, Nick Couchman wrote:
> >
> > >
> > >
> > Perhaps the mapper needs to be bound, just like the webapp's REST
> services?
> >
> > https://stackoverflow.com/questions/11987097/how-do-i-
> > use-a-jersey-exceptionmapper-with-google-guice
> >
>
>
> Yep, that seems to
On Tue, May 29, 2018 at 12:07 PM, Nick Couchman wrote:
> On Tue, May 29, 2018 at 2:59 PM, Nick Couchman wrote:
>
> > >
> >> >
> >> Perhaps the mapper needs to be bound, just like the webapp's REST
> >> services?
> >>
> >> https://stackoverflow.com/questions/11987097/how-do-i-
> >>
On Tue, May 29, 2018 at 3:19 PM, Mike Jumper
wrote:
> On Tue, May 29, 2018 at 11:59 AM, Nick Couchman wrote:
>
> > >
> > > >
> > > >
> > > Perhaps the mapper needs to be bound, just like the webapp's REST
> > services?
> > >
> > > https://stackoverflow.com/questions/11987097/how-do-i-
> > >
>
> IIRC, there are minimum JVM version requirements for Jersey 2.x that
>>
> historically prevented us from going that route, but if we're going to
>> require Java 7 across the board, this is doable.
>>
>
> Okay, I'll see what I can figure out with that. Hopefully it won't be
> necessary to make
>
> >
> >
> Perhaps the mapper needs to be bound, just like the webapp's REST services?
>
> https://stackoverflow.com/questions/11987097/how-do-i-
> use-a-jersey-exceptionmapper-with-google-guice
>
Yep, that seems to be the ticket to getting it to work. So, next question,
should this be
On Tue, May 29, 2018 at 2:59 PM, Nick Couchman wrote:
> >
>> >
>> Perhaps the mapper needs to be bound, just like the webapp's REST
>> services?
>>
>> https://stackoverflow.com/questions/11987097/how-do-i-
>> use-a-jersey-exceptionmapper-with-google-guice
>>
>
>
> Yep, that seems to be the
GitHub user necouchman opened a pull request:
https://github.com/apache/guacamole-client/pull/291
GUACAMOLE-566: Replace RESTExceptionWrapper with GuacamoleExceptionMapper
Per the discussion on the mailing list ([1]) this change implements the
`GuacamoleExceptionMapper` class that
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/291#discussion_r191607392
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/RESTServiceModule.java ---
@@ -83,11 +83,9 @@ protected void configureServlets() {
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/291#discussion_r191607105
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/GuacamoleExceptionMapper.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/291#discussion_r191607055
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/GuacamoleExceptionMapper.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/291#discussion_r191607919
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/RESTExceptionWrapper.java ---
@@ -1,203 +0,0 @@
-/*
- * Licensed to the
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/291#discussion_r191626164
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/RESTExceptionWrapper.java ---
@@ -1,203 +0,0 @@
-/*
- * Licensed to the
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/291#discussion_r191626099
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/RESTServiceModule.java ---
@@ -83,11 +83,9 @@ protected void configureServlets() {
Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/291#discussion_r191631978
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/RESTExceptionMapper.java ---
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the
Github user necouchman commented on a diff in the pull request:
https://github.com/apache/guacamole-client/pull/291#discussion_r191626020
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/GuacamoleExceptionMapper.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed to
On Mon, May 28, 2018 at 11:19 PM, Mark Nolan wrote:
> Don't you see those warnings anyway? I can't check right now, but I'm
> fairly certain I've seen them in the log regardless.
>
>
Yeah, Mark, you're right, those show up in a clean build without this, so
that's obviously not the issue.
I
17 matches
Mail list logo
