[GitHub] [guacamole-client] mike-jumper merged pull request #420: GUACAMOLE-302: Refocus relevant in-progress login fields after auth failure

2019-06-25 Thread GitBox
mike-jumper merged pull request #420: GUACAMOLE-302: Refocus relevant in-progress login fields after auth failure URL: https://github.com/apache/guacamole-client/pull/420 This is an automated message from the Apache Git

[GitHub] [guacamole-client] m-khan-glyptodon opened a new pull request #420: GUACAMOLE-302: Refocus relevant in-progress login fields after auth failure

2019-06-25 Thread GitBox
m-khan-glyptodon opened a new pull request #420: GUACAMOLE-302: Refocus relevant in-progress login fields after auth failure URL: https://github.com/apache/guacamole-client/pull/420 Note: There were two parts of this issue this time around. The first(error message) has been fixed and

[GitHub] [guacamole-client] mike-jumper commented on issue #420: GUACAMOLE-302: Refocus relevant in-progress login fields after auth failure

2019-06-25 Thread GitBox
mike-jumper commented on issue #420: GUACAMOLE-302: Refocus relevant in-progress login fields after auth failure URL: https://github.com/apache/guacamole-client/pull/420#issuecomment-505607016 > As far as the inconsistency in focusing the username field on the initial page load is

[GitHub] [guacamole-client] mike-jumper opened a new pull request #421: GUACAMOLE-302: Do not rely on $evalAsync() for assigning focus.

2019-06-25 Thread GitBox
mike-jumper opened a new pull request #421: GUACAMOLE-302: Do not rely on $evalAsync() for assigning focus. URL: https://github.com/apache/guacamole-client/pull/421 It appears that we cannot rely on `focus()` working as expected unless its execution is deferred via `window.setTimeout()`

Re: guacamole-common-js BlobWriter.js Bug

2019-06-25 Thread Mike Jumper
Hi James, Thanks! However: 1) Your modified BlobWriter.js didn't actually make it through. The attachment was likely stripped. 2) That doesn't matter anyway, as contributions need to be submitted via pull request, not via email / mailing list. If you would like to contribute a change, please

[GitHub] [guacamole-client] chisatohasimoto commented on issue #413: GUACAMOLE-821: Add Japanese translation

2019-06-25 Thread GitBox
chisatohasimoto commented on issue #413: GUACAMOLE-821: Add Japanese translation URL: https://github.com/apache/guacamole-client/pull/413#issuecomment-505682881 Many thanks for your advice. I changed the commit message.

[GitHub] [guacamole-client] jmuehlner merged pull request #421: GUACAMOLE-302: Do not rely on $evalAsync() for assigning focus.

2019-06-25 Thread GitBox
jmuehlner merged pull request #421: GUACAMOLE-302: Do not rely on $evalAsync() for assigning focus. URL: https://github.com/apache/guacamole-client/pull/421 This is an automated message from the Apache Git Service. To

[GitHub] [guacamole-client] jmuehlner commented on issue #421: GUACAMOLE-302: Do not rely on $evalAsync() for assigning focus.

2019-06-25 Thread GitBox
jmuehlner commented on issue #421: GUACAMOLE-302: Do not rely on $evalAsync() for assigning focus. URL: https://github.com/apache/guacamole-client/pull/421#issuecomment-505700924 Well, I don't fully understand this, but testing confirms that this fixes the issue on several different

[GitHub] [guacamole-client] jmuehlner merged pull request #418: GUACAMOLE-822: Correct retrieval of client identifier for connection groups.

2019-06-25 Thread GitBox
jmuehlner merged pull request #418: GUACAMOLE-822: Correct retrieval of client identifier for connection groups. URL: https://github.com/apache/guacamole-client/pull/418 This is an automated message from the Apache Git