[GitHub] guacamole-client pull request #274: GUACAMOLE-220: Add base extension API su...

2018-04-19 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/274 GUACAMOLE-220: Add base extension API support for user groups. This change adds the base classes necessary for exposing user groups via extensions, and for declaring the permissions

[GitHub] guacamole-client pull request #273: GUACAMOLE-549: Migrate to localStorage f...

2018-04-19 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/273 GUACAMOLE-549: Migrate to localStorage for storage of auth token. This change: * Adds a new service, `localStorageService` / `localStorageServiceProvider`, which abstracts

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-19 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182735738 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,204

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-19 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182714041 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -131,7

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-19 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182713552 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -164,23

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-19 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182713621 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,204

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-19 Thread ceharris
Github user ceharris commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182706319 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -131,7

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-19 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182706233 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,204

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-19 Thread ceharris
Github user ceharris commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182705944 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -164,23

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-19 Thread ceharris
Github user ceharris commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182705248 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,204

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-19 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182695572 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,187

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-19 Thread necouchman
Github user necouchman commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182687363 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0 +1,187