[GitHub] mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250464239 ## File path: src/protocols/rdp/rdp_fs.c ## @@ -607,11

[GitHub] jmuehlner commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

jmuehlner commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250463281 ## File path: src/protocols/rdp/rdp_fs.c ## @@ -607,11

[GitHub] mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250451962 ## File path: src/libguac/tests/string/strlcat.c ## @@

[GitHub] mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250450650 ## File path: src/libguac/tests/string/strlcat.c ## @@

[GitHub] mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations.

mike-jumper commented on a change in pull request #209: GUACAMOLE-637: Migrate strncpy(), strcat(), etc. to safer libguac implementations. URL: https://github.com/apache/guacamole-server/pull/209#discussion_r250449707 ## File path: src/libguac/tests/string/strlcat.c ## @@

[GitHub] skotfred closed pull request #70: Added HTML lang="en"

skotfred closed pull request #70: Added HTML lang="en" URL: https://github.com/apache/guacamole-website/pull/70 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and

[GitHub] skotfred commented on issue #70: Added HTML lang="en"

skotfred commented on issue #70: Added HTML lang="en" URL: https://github.com/apache/guacamole-website/pull/70#issuecomment-457036533 I’ll clean it up and resubmit later. Thanks This is an automated message from the Apache

[GitHub] mike-jumper commented on issue #70: Added HTML lang="en"

mike-jumper commented on issue #70: Added HTML lang="en" URL: https://github.com/apache/guacamole-website/pull/70#issuecomment-457013508 Yeah, the idea behind the change is valid, but these changes need to be made through guacamole-manual, not to the auto-generated build output.

[GitHub] skotfred opened a new pull request #105: Added HTML lang="en"

skotfred opened a new pull request #105: Added HTML lang="en" URL: https://github.com/apache/guacamole-manual/pull/105 Primarily an accessibility concern for screen reader software. This is an automated message from the

[GitHub] necouchman commented on issue #70: Added HTML lang="en"

necouchman commented on issue #70: Added HTML lang="en" URL: https://github.com/apache/guacamole-website/pull/70#issuecomment-457010567 Okay, major issue I see so far is that you're proposing changes to a lot of files that are dynamically generated (pretty much anything under the `doc/`

[GitHub] skotfred opened a new pull request #70: Added HTML lang="en"

skotfred opened a new pull request #70: Added HTML lang="en" URL: https://github.com/apache/guacamole-website/pull/70 Primarily an accessibility concern for screen reader software. This is an automated message from the Apache

[GitHub] necouchman merged pull request #69: Document vulnerability CVE-2018-1340, fixed in 1.0.0.

necouchman merged pull request #69: Document vulnerability CVE-2018-1340, fixed in 1.0.0. URL: https://github.com/apache/guacamole-website/pull/69 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mike-jumper opened a new pull request #69: Document vulnerability CVE-2018-1340, fixed in 1.0.0.

mike-jumper opened a new pull request #69: Document vulnerability CVE-2018-1340, fixed in 1.0.0. URL: https://github.com/apache/guacamole-website/pull/69 This is an automated message from the Apache Git Service. To respond

[SECURITY] CVE-2018-1340: Secure flag missing from Apache Guacamole session cookie

CVE-2018-1340: Secure flag missing from Apache Guacamole session cookie Versions affected: Apache Guacamole 0.9.4 through 0.9.14 Description: Prior to 1.0.0, Apache Guacamole used a cookie for client-side storage of the user's session token. This cookie lacked the "secure" flag, which could

[GitHub] necouchman opened a new pull request #211: GUACAMOLE-693: Update copyright year to 2019.

necouchman opened a new pull request #211: GUACAMOLE-693: Update copyright year to 2019. URL: https://github.com/apache/guacamole-server/pull/211 This is an automated message from the Apache Git Service. To respond to the

[GitHub] necouchman opened a new pull request #367: GUACAMOLE-693: Update copyright year to 2019.

necouchman opened a new pull request #367: GUACAMOLE-693: Update copyright year to 2019. URL: https://github.com/apache/guacamole-client/pull/367 This is an automated message from the Apache Git Service. To respond to the

[GitHub] JoelB opened a new pull request #366: GUACAMOLE-713: Add support for changing Logback verbosity to Docker start script

JoelB opened a new pull request #366: GUACAMOLE-713: Add support for changing Logback verbosity to Docker start script URL: https://github.com/apache/guacamole-client/pull/366 JIRA issue: https://issues.apache.org/jira/browse/GUACAMOLE-713 This change would enable changing the

[GitHub] daniquir commented on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module

daniquir commented on issue #359: GUACAMOLE-617: Extract Permission Management from JDBC Authentication Module URL: https://github.com/apache/guacamole-client/pull/359#issuecomment-456836843 > Empty classes/interfaces are definitely an antipattern. If something about the design of the