Github user liming01 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/330#issuecomment-179140402
Looks good to me. +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user linwen closed the pull request at:
https://github.com/apache/incubator-hawq/pull/330
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/330#discussion_r51702311
--- Diff: depends/libyarn/src/libyarnclient/LibYarnClient.cpp ---
@@ -106,7 +106,7 @@ list LibYarnClient::getAskRequests() {
void*
Github user 0x0FFF commented on the pull request:
https://github.com/apache/incubator-hawq/pull/323#issuecomment-179084818
Speaking about this specific case: do we plan an upgrade path from HAWQ 1.x
to 2.0? If no, then this PR can be easily merged into 2.0. If yes, we should
really
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/324
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user jiny2 opened a pull request:
https://github.com/apache/incubator-hawq/pull/331
HAWQ-395. User can only alter MEMORY_LIMIT_CLUSTER/CORE_LIMIT_CLUSTER if
the target queue is a branch queue
postgres=# alter resource queue queue2 with (
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51818643
--- Diff:
pxf/pxf-json/src/main/java/org/apache/hawq/pxf/plugins/json/ColumnDescriptorCache.java
---
@@ -0,0 +1,165 @@
+package
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/331#issuecomment-179577899
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user changleicn commented on the pull request:
https://github.com/apache/incubator-hawq/pull/323#issuecomment-179593353
First of all, good fix. In 2.0GA, upgrade path from hawq 1.x to 2.0 is via
data reloading. Have we tested parquet format, and mapreduce inputformat? The
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51818210
--- Diff:
pxf/pxf-json/src/main/java/org/apache/hawq/pxf/plugins/json/ColumnDescriptorCache.java
---
@@ -0,0 +1,165 @@
+package
Github user linwen commented on the pull request:
https://github.com/apache/incubator-hawq/pull/331#issuecomment-179578971
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user rvs opened a pull request:
https://github.com/apache/incubator-hawq/pull/332
HAWQ-388. Remove unnecessary entries in NOTICE file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rvs/incubator-hawq master
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51833835
--- Diff:
pxf/pxf-json/src/main/java/org/apache/hawq/pxf/plugins/json/parser/PartitionedJsonParser.java
---
@@ -0,0 +1,198 @@
+package
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51834024
--- Diff:
pxf/pxf-json/src/main/java/org/apache/hawq/pxf/plugins/json/parser/PartitionedJsonParser.java
---
@@ -0,0 +1,198 @@
+package
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51835615
--- Diff:
pxf/pxf-json/src/test/java/org/apache/hawq/pxf/plugins/json/JsonExtensionTest.java
---
@@ -0,0 +1,288 @@
+package
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51836013
--- Diff:
pxf/pxf-json/src/test/java/org/apache/hawq/pxf/plugins/json/PxfUnit.java ---
@@ -0,0 +1,672 @@
+package org.apache.hawq.pxf.plugins.json;
Github user hornn commented on the pull request:
https://github.com/apache/incubator-hawq/pull/302#issuecomment-179682943
@tzolov regarding test coverage, what you did is very impressive.
Normally we have an automation suite where we test end to end query using a
specific plugin,
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51834454
--- Diff:
pxf/pxf-json/src/main/java/org/apache/hawq/pxf/plugins/json/parser/PartitionedJsonParser.java
---
@@ -0,0 +1,198 @@
+package
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51835076
--- Diff:
pxf/pxf-json/src/test/java/org/apache/hawq/pxf/plugins/json/JsonExtensionTest.java
---
@@ -0,0 +1,288 @@
+package
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51835264
--- Diff:
pxf/pxf-json/src/test/java/org/apache/hawq/pxf/plugins/json/JsonExtensionTest.java
---
@@ -0,0 +1,288 @@
+package
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51835237
--- Diff:
pxf/pxf-json/src/test/java/org/apache/hawq/pxf/plugins/json/JsonExtensionTest.java
---
@@ -0,0 +1,288 @@
+package
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51835736
--- Diff:
pxf/pxf-json/src/test/java/org/apache/hawq/pxf/plugins/json/PxfUnit.java ---
@@ -0,0 +1,672 @@
+package org.apache.hawq.pxf.plugins.json;
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51836238
--- Diff:
pxf/pxf-json/src/test/java/org/apache/hawq/pxf/plugins/json/parser/PartitionedJsonParserOffsetTest.java
---
@@ -0,0 +1,54 @@
+package
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/327#issuecomment-179691649
It is better to set the pointers to NULLs after pfree.
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user liming01 opened a pull request:
https://github.com/apache/incubator-hawq/pull/333
HAWQ-396. Fixed crashed at nested error report calling when close temâ¦
â¦p file at AbortTransaction()
You can merge this pull request into a Git repository by running:
$ git pull
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51827170
--- Diff:
pxf/pxf-json/src/main/java/org/apache/hawq/pxf/plugins/json/JsonRecordReader.java
---
@@ -0,0 +1,176 @@
+package
Github user wangzw commented on the pull request:
https://github.com/apache/incubator-hawq/pull/333#issuecomment-179614897
looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51828041
--- Diff:
pxf/pxf-json/src/main/java/org/apache/hawq/pxf/plugins/json/JsonResolver.java
---
@@ -0,0 +1,255 @@
+package
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/302#discussion_r51828253
--- Diff:
pxf/pxf-json/src/main/java/org/apache/hawq/pxf/plugins/json/JsonResolver.java
---
@@ -0,0 +1,255 @@
+package
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/333#issuecomment-179652141
LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ztao1987 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/327#issuecomment-179693064
Sure, set it to NULL in the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/328#discussion_r51771858
--- Diff: src/backend/cdb/cdbfilesystemcredential.c ---
@@ -382,6 +382,17 @@ cleanup_filesystem_credentials(Portal portal)
}
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/324#discussion_r51762431
--- Diff: src/backend/utils/init/postinit.c ---
@@ -368,6 +368,22 @@ InitPostgres(const char *in_dbname, Oid dboid, const
char *username,
char
33 matches
Mail list logo
