Re: license headers for hawq
Hi Wen, is this the last commit we need for all license issues. https://github.com/apache/incubator-hawq/commit/59264a537b6e000a416e60c3392720b92a6ebcfd What about https://issues.apache.org/jira/browse/HAWQ-186 ? Thanks -Goden On Sun, Dec 13, 2015 at 11:00 PM Wen Linwrote: > Hi, Roman, > > Thank you for the suggestion! > I've put a pom.xml for hawq, it contains the exclude list. > run "mvn apache-rat:rat" can get a report. No unknown Licenses now. > > Regards, > > On Tue, Dec 8, 2015 at 6:52 AM, Roman Shaposhnik > wrote: > > > On Mon, Dec 7, 2015 at 3:13 AM, Wen Lin wrote: > > > Hi, Caleb, > > > The files you mentioned that need to be removed is recorded in Jira: > > > https://issues.apache.org/jira/browse/HAWQ-186 > > > Lirong is working on this. > > > > > > Hi, Roman, > > > Today I add license headers for some source files. The latest status > is : > > > Summary > > > --- > > > Generated at: 2015-12-07T18:59:07+08:00 > > > Notes: 78 > > > Binaries: 786 > > > Archives: 20 > > > Standards: 5834 > > > > > > Apache Licensed: 1435 > > > Generated Documents: 0 > > > > > > JavaDocs are generated and so license header is optional > > > Generated files do not required license headers > > > > > > 4383 Unknown Licenses > > > > > > Some files are from 3rd party, like postgres, gtest, gmock, etc. I am > > > wondering, is it correct to add license header for these files? > > > Some other files are .out, .ans, .sgml etc, when use apache-rat to add > > > license header for a folder, these files will be ignored by apache-rat > > > > You don't need to change license headers on files coming from > > other projects (in fact you can NOT do that legally). > > > > You do, however, need to compile a very detailed list of exceptions > > that you will pass to rat via -E/-e option: > > http://creadur.apache.org/rat/apache-rat/index.html > > > > I would like these exception to be grouped and documented somehow > > so that anybody reviewing the release can make sure why things > > are on the list of exceptions. > > > > Thanks, > > Roman. > > >
Re: license headers for hawq
Hi, Roman, Thank you for the suggestion! I've put a pom.xml for hawq, it contains the exclude list. run "mvn apache-rat:rat" can get a report. No unknown Licenses now. Regards, On Tue, Dec 8, 2015 at 6:52 AM, Roman Shaposhnikwrote: > On Mon, Dec 7, 2015 at 3:13 AM, Wen Lin wrote: > > Hi, Caleb, > > The files you mentioned that need to be removed is recorded in Jira: > > https://issues.apache.org/jira/browse/HAWQ-186 > > Lirong is working on this. > > > > Hi, Roman, > > Today I add license headers for some source files. The latest status is : > > Summary > > --- > > Generated at: 2015-12-07T18:59:07+08:00 > > Notes: 78 > > Binaries: 786 > > Archives: 20 > > Standards: 5834 > > > > Apache Licensed: 1435 > > Generated Documents: 0 > > > > JavaDocs are generated and so license header is optional > > Generated files do not required license headers > > > > 4383 Unknown Licenses > > > > Some files are from 3rd party, like postgres, gtest, gmock, etc. I am > > wondering, is it correct to add license header for these files? > > Some other files are .out, .ans, .sgml etc, when use apache-rat to add > > license header for a folder, these files will be ignored by apache-rat > > You don't need to change license headers on files coming from > other projects (in fact you can NOT do that legally). > > You do, however, need to compile a very detailed list of exceptions > that you will pass to rat via -E/-e option: > http://creadur.apache.org/rat/apache-rat/index.html > > I would like these exception to be grouped and documented somehow > so that anybody reviewing the release can make sure why things > are on the list of exceptions. > > Thanks, > Roman. >
Re: license headers for hawq
Hi, Caleb, The files you mentioned that need to be removed is recorded in Jira: https://issues.apache.org/jira/browse/HAWQ-186 Lirong is working on this. Hi, Roman, Today I add license headers for some source files. The latest status is : Summary --- Generated at: 2015-12-07T18:59:07+08:00 Notes: 78 Binaries: 786 Archives: 20 Standards: 5834 Apache Licensed: 1435 Generated Documents: 0 JavaDocs are generated and so license header is optional Generated files do not required license headers 4383 Unknown Licenses Some files are from 3rd party, like postgres, gtest, gmock, etc. I am wondering, is it correct to add license header for these files? Some other files are .out, .ans, .sgml etc, when use apache-rat to add license header for a folder, these files will be ignored by apache-rat Thanks! On Thu, Dec 3, 2015 at 3:29 AM, Caleb Weltonwrote: > From my quick investigation there are: > > 1. The stupid stuff that can simply be deleted > > depends/libyarn/releng/bin/templates/.core-site-secure-ha.xml.swp > tools/bin/ext/yaml/__init__.pyc > tools/bin/ext/yaml/composer.pyc > tools/bin/ext/yaml/constructor.pyc > tools/bin/ext/yaml/cyaml.pyc > tools/bin/ext/yaml/dumper.pyc > tools/bin/ext/yaml/emitter.pyc > tools/bin/ext/yaml/error.pyc > tools/bin/ext/yaml/events.pyc > tools/bin/ext/yaml/loader.pyc > tools/bin/ext/yaml/nodes.pyc > tools/bin/ext/yaml/parser.pyc > tools/bin/ext/yaml/reader.pyc > tools/bin/ext/yaml/representer.pyc > tools/bin/ext/yaml/resolver.pyc > tools/bin/ext/yaml/scanner.pyc > tools/bin/ext/yaml/serializer.pyc > tools/bin/ext/yaml/tokens.pyc > > > 2. Data files used in testing > > The most substantial list being the ones under > contrib/hawq-hadoop/hawq-mapreduce-tool/test-data/hawq-data/gpseg1 > > > 3. Jar files and tar files of various dependencies, including: > > contrib/hawq-hadoop/hawq-mapreduce-tool/lib/parquet-column-1.1.0.jar > contrib/hawq-hadoop/hawq-mapreduce-tool/lib/parquet-common-1.1.0.jar > contrib/hawq-hadoop/hawq-mapreduce-tool/lib/parquet-encoding-1.1.0.jar > contrib/hawq-hadoop/hawq-mapreduce-tool/lib/parquet-format-1.0.0.jar > contrib/hawq-hadoop/hawq-mapreduce-tool/lib/parquet-hadoop-1.1.0.jar > contrib/hawq-hadoop/hawq-mapreduce-tool/lib/postgresql-9.2-1003-jdbc4.jar > contrib/hawq-hadoop/hawq-mapreduce-tool/lib/snakeyaml-1.12.jar > contrib/hawq-hadoop/hawq-mapreduce-tool/lib/snappy-java-1.1.0.jar > pxf/gradle/wrapper/gradle-wrapper.jar > tools/bin/pythonSrc/epydoc-3.0.1.tar.gz > tools/bin/pythonSrc/lockfile-0.9.1.tar.gz > tools/bin/pythonSrc/logilab-astng-0.20.1.tar.gz > tools/bin/pythonSrc/logilab-common-0.50.1.tar.gz > tools/bin/pythonSrc/paramiko-1.7.6-9.tar.gz > tools/bin/pythonSrc/PSI-0.3b2_gp.tar.gz > tools/bin/pythonSrc/pychecker-0.8.18.tar.gz > tools/bin/pythonSrc/pycrypto-2.0.1.tar.gz > tools/bin/pythonSrc/pylint-0.21.0.tar.gz > tools/bin/pythonSrc/unittest2-0.5.1.tar.gz > tools/bin/src/netperf-2.4.3.tar.gz > > 4. a cacerts file > > depends/libyarn/releng/make/dependencies/cacerts > > 5. a couple image files > > src/port/win32.ico > src/tools/backend/flow.gif > > > The above was identified from the following > > find * -type f -exec file '{}' + | grep -v text | grep -v empty > > /tmp/binfiles > > There were additionally some false positives such as >src/test/regress/data/mpp12839_1.data > > Which are basically text but include some unusual characters. > > Regards, > Caleb > > > > On Tue, Dec 1, 2015 at 6:45 PM, Roman Shaposhnik > wrote: > > > On Mon, Nov 30, 2015 at 10:24 PM, Owen O'Malley > > wrote: > > > Can I ask what the binary files are? It is hard to include binary files > > in > > > Apache releases, because they are hard to inspect or validate. > > > > I actually have that very same question. I was hoping that comments in > > the RAT exclusion file will provide us with some insight ;-) > > > > Thanks, > > Roman. > > >
Re: license headers for hawq
On Mon, Dec 7, 2015 at 3:13 AM, Wen Linwrote: > Hi, Caleb, > The files you mentioned that need to be removed is recorded in Jira: > https://issues.apache.org/jira/browse/HAWQ-186 > Lirong is working on this. > > Hi, Roman, > Today I add license headers for some source files. The latest status is : > Summary > --- > Generated at: 2015-12-07T18:59:07+08:00 > Notes: 78 > Binaries: 786 > Archives: 20 > Standards: 5834 > > Apache Licensed: 1435 > Generated Documents: 0 > > JavaDocs are generated and so license header is optional > Generated files do not required license headers > > 4383 Unknown Licenses > > Some files are from 3rd party, like postgres, gtest, gmock, etc. I am > wondering, is it correct to add license header for these files? > Some other files are .out, .ans, .sgml etc, when use apache-rat to add > license header for a folder, these files will be ignored by apache-rat You don't need to change license headers on files coming from other projects (in fact you can NOT do that legally). You do, however, need to compile a very detailed list of exceptions that you will pass to rat via -E/-e option: http://creadur.apache.org/rat/apache-rat/index.html I would like these exception to be grouped and documented somehow so that anybody reviewing the release can make sure why things are on the list of exceptions. Thanks, Roman.
license headers for hawq
Hi, HAWQ Mentors, I have added license headers to apache-hawq, here is the rules I follow. 1. will not add license headers to source files from or modified from Postgres. 2. will not add license headers 3rd-party tools/libraries, like contrib/orafce, pgcrypto, pljava, etc. 3. add license headers to files from greenplum, or created by hawq(use apache-rat to add license header for source files). * Summary --- Generated at: 2015-11-30T10:40:35+08:00 Notes: 79 Binaries: 796 Archives: 20 Standards: 5870 Apache Licensed: 1366 Generated Documents: 0 JavaDocs are generated and so license header is optional Generated files do not required license headers 4488 Unknown Licenses *** Please help me verify it. Thanks,