Re: Review Request: hbase-2998 rolling-restart.sh shouldn't rely on zoo.cfg

2010-10-22 Thread stack
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1057/ --- (Updated 2010-10-22 11:59:16.222128) Review request for hbase, Jean-Daniel

Re: Review Request: Stale reads from ZK can break the atomic CAS operations we have in ZKAssign

2010-10-22 Thread stack
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1056/#review1620 --- Ship it! +1 on getting it in as is. I think its going to kill my

Re: Review Request: hbase-2998 rolling-restart.sh shouldn't rely on zoo.cfg

2010-10-22 Thread Jonathan Gray
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1057/#review1624 --- Ship it! +1 after doing changes we discussed on IRC. Namely to make

Re: Review Request: HBASE-2514 RegionServer should refuse to be assigned a region that use LZO when LZO isn't available

2010-10-22 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1046/ --- (Updated 2010-10-22 15:43:55.487649) Review request for hbase. Changes

Re: Review Request: scan can early exit for incrementColumnValue()

2010-10-22 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1053/#review1626 --- Ship it! - Ryan On 2010-10-20 21:31:17, khemani wrote:

Re: Review Request: HBASE-2514 RegionServer should refuse to be assigned a region that use LZO when LZO isn't available

2010-10-22 Thread stack
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1046/#review1628 --- Chatting offline w/ R and J-D, this patch is good if hfiles but no

Re: Review Request: HBASE-2514 RegionServer should refuse to be assigned a region that use LZO when LZO isn't available

2010-10-22 Thread Ryan Rawson
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1046/ --- (Updated 2010-10-22 16:38:10.455573) Review request for hbase. Summary

Re: Review Request: Unit test and fix for multi-threaded executor service

2010-10-22 Thread Benoit Sigoure
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1064/#review1629 ---

Re: Review Request: Unit test and fix for multi-threaded executor service

2010-10-22 Thread Jonathan Gray
On 2010-10-22 19:12:22, Benoit Sigoure wrote: Hey Benoit. Sorry should have thrown a comment up here. This isn't going to get committed, Stack has a different implementation over in HBASE-3319. We'll eventually need a PQ but for now it'll get switched to a LinkedBlockingQueue and

Review Request: TOF doesn't take zk client port for remote clusters

2010-10-22 Thread Jean-Daniel Cryans
--- This is an automatically generated e-mail. To reply, visit: http://review.cloudera.org/r/1077/ --- Review request for hbase. Summary --- Does exactly what this jira is

Re: Review Request: Unit test and fix for multi-threaded executor service

2010-10-22 Thread stack
On 2010-10-22 19:12:22, Benoit Sigoure wrote: trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java, line 288 http://review.cloudera.org/r/1064/diff/2/?file=15331#file15331line288 Why is this class public? HBasePriorityBlockingQueue is a very bad