Re: Tags class using wrong length?

I think the layout of tags is missing now in the javadoc. May be it got missed or moved to some other place? I remember we had a layout explaining the tag structure then this code is much easier to read this code. As Chia-Ping said is the layout. So from the KeyValue lay out we extract the tag

[jira] [Created] (HBASE-18528) Support to modify TableDescriptor/ColumnFamilyDescriptor through MasterObserver; Or disable that.

Chia-Ping Tsai created HBASE-18528: -- Summary: Support to modify TableDescriptor/ColumnFamilyDescriptor through MasterObserver; Or disable that. Key: HBASE-18528 URL:

Re: [DISCUSS] Planning changes on RegionServer totalRequestCount metrics

Thanks for chiming in @stack and @Jerry, will try to add a good release note when the work done. Since already more than 72 hours passed and no objections, I'd like to call this discussion closed and apply the change in HBASE-18469. Thanks. Best Regards, Yu On 4 August 2017 at 13:59, stack

[jira] [Created] (HBASE-18527) update nightly builds to compensate for jenkins plugin upgrades

Sean Busbey created HBASE-18527: --- Summary: update nightly builds to compensate for jenkins plugin upgrades Key: HBASE-18527 URL: https://issues.apache.org/jira/browse/HBASE-18527 Project: HBase

Re: Tags class using wrong length?

The byte following the tag length (a short) is the tag type. The current code is correct. On Sun, Aug 6, 2017 at 5:40 AM, Chia-Ping Tsai wrote: > According to the following code: > public ArrayBackedTag(byte tagType, byte[] tag) { > int tagLength = tag.length +

Failure: HBase Generate Website

Build status: Failure The HBase website has not been updated to incorporate HBase commit ${HBASE_GIT_SHA}. See https://builds.apache.org/job/hbase_generate_website/1072/console

Re: Tags class using wrong length?

You mean I am right and it should be the other constant being used? Sorry, just wanting to confirm. On Sun, Aug 6, 2017 at 2:40 PM, Chia-Ping Tsai wrote: > According to the following code: > public ArrayBackedTag(byte tagType, byte[] tag) { > int tagLength =

Re: Tags class using wrong length?

According to the following code: public ArrayBackedTag(byte tagType, byte[] tag) { int tagLength = tag.length + TYPE_LENGTH_SIZE; if (tagLength > MAX_TAG_LENGTH) { throw new IllegalArgumentException( "Invalid tag data being passed. Its length can not exceed " +

Re: Bug in FIFOCompactionPolicy pre-checks?

Cool, thanks Vlad. Filed https://issues.apache.org/jira/browse/HBASE-18526 On Fri, Aug 4, 2017 at 7:53 PM, Vladimir Rodionov wrote: > Yes, file a JIRA, Lars > > I will take a look > > -Vlad > > > On Thu, Aug 3, 2017 at 11:41 PM, Lars George wrote:

[jira] [Created] (HBASE-18526) FIFOCompactionPolicy pre-check uses wrong scope

Lars George created HBASE-18526: --- Summary: FIFOCompactionPolicy pre-check uses wrong scope Key: HBASE-18526 URL: https://issues.apache.org/jira/browse/HBASE-18526 Project: HBase Issue Type:

Tags class using wrong length?

Hi, I found this reading through tags in 1.3, but checked in trunk as well. There is this code: public ArrayBackedTag(byte[] bytes, int offset, int length) { if (length > MAX_TAG_LENGTH) { throw new IllegalArgumentException( "Invalid tag data being passed. Its length can