Re: A tweak to our checkstyle configuration

2022-01-15 Thread Andrew Purtell
There are a handful of anti patterns to avoid, like dangling if-elses. (Always use braces around code blocks!) Otherwise we have been following the Java basic guidelines with modifications for indent width and maximum line length and I see no pressing reason why this needs to change. Happy with

Re: A tweak to our checkstyle configuration

2022-01-15 Thread Sean Busbey
I don't feel strongly about the specific proposal that started this thread. I could see why someone might find it easier to skim the code; I don't feel it impacts my reading personally. If there are folks with differing opinions over it; my preference would be that we stick with whatever style is

[jira] [Created] (HBASE-26674) TestWriteHeavyIncrementObserver is flaky

2022-01-15 Thread Duo Zhang (Jira)
Duo Zhang created HBASE-26674: - Summary: TestWriteHeavyIncrementObserver is flaky Key: HBASE-26674 URL: https://issues.apache.org/jira/browse/HBASE-26674 Project: HBase Issue Type: Bug

Re: A tweak to our checkstyle configuration

2022-01-15 Thread Duo Zhang
What about just switching to use google java style? Nick Dimiduk 于2022年1月13日周四 03:22写道: > Hey all. > > Discussion on the PR has resulted in an impasse of opinion, but also > renewed interest in improvements to static analysis in general > (HBASE-26617). > > I think that this kind of code