Re: [DISCUSS] removing hbase-examples from the assembly

2024-03-05 Thread Istvan Toth
This sounds great to me. The current PR does this, so I think we are all in agreement. On Tue, Mar 5, 2024 at 10:49 AM 张铎(Duo Zhang) wrote: > I prefer we still have the hbase-examples in the main repo and publish > it to maven central, but we do not need to ship it in the binary > releases. The

Re: [DISCUSS] removing hbase-examples from the assembly

2024-03-05 Thread Duo Zhang
I prefer we still have the hbase-examples in the main repo and publish it to maven central, but we do not need to ship it in the binary releases. The most important thing for hbase-examples is its source code, so including it in binary releases does not help. Istvan Toth 于2024年3月5日周二 03:28写道: > >

Re: [DISCUSS] removing hbase-examples from the assembly

2024-03-04 Thread Istvan Toth
I don't have a problem with having an examples module in the main repo, it can be useful, and this way it is guaranteed to always work with the latest version, and we don't have to maintain another repo. Publishing the binary artifact to maven (as we do now) doesn't sound very useful, but if nothi

Re: [DISCUSS] removing hbase-examples from the assembly

2024-03-04 Thread Nick Dimiduk
Should we remove hbase-examples from the main repository entirely? Should it be its own download? Should we even ship it in binary form at all? Anyway I’m fine with removing it from the assembly. Thanks, Nick On Mon, 4 Mar 2024 at 13:27, Istvan Toth wrote: > hbase assembly (and consequently th

[DISCUSS] removing hbase-examples from the assembly

2024-03-04 Thread Istvan Toth
hbase assembly (and consequently the binary distributions) now depend on hbase-examples. I think this is problematic, as * many of those examples are explicitly not production quality. * It adds extra curator dependencies to the assembly and to the various HBase classpaths. (whic the rest of HBase