Re: [DISCUSS] Deprecate Review Board in favor of Github reviews

2019-12-10 Thread Nick Dimiduk
月14日周四 > > > 下午6:11写道: > > > > > > > > > > > +1 > > > > > > > > > > > > I also like the GitHub way much more compared to ReviewBoard. > > > > > > > > > > > > From: Peter Somogyi

Re: [DISCUSS] Deprecate Review Board in favor of Github reviews

2019-11-20 Thread Mingliang Liu
+1 > > > > > > > > > > I also like the GitHub way much more compared to ReviewBoard. > > > > > > > > > > From: Peter Somogyi > > > > > Reply-To: "dev@hbase.apache.org" > > > > > Date: Wednes

Re: [DISCUSS] Deprecate Review Board in favor of Github reviews

2019-11-14 Thread Zach York
> 下午6:11写道: > > > > > > > +1 > > > > > > > > I also like the GitHub way much more compared to ReviewBoard. > > > > > > > > From: Peter Somogyi > > > > Reply-To: "dev@hbase.apache.org" > > > > Date:

Re: [DISCUSS] Deprecate Review Board in favor of Github reviews

2019-11-14 Thread Geoffrey Jacoby
gyi > > > Reply-To: "dev@hbase.apache.org" > > > Date: Wednesday, November 13, 2019 at 6:23 PM > > > To: HBase Dev List > > > Subject: Re: [DISCUSS] Deprecate Review Board in favor of Github > reviews > > > > > > +1 > > &g

Re: [DISCUSS] Deprecate Review Board in favor of Github reviews

2019-11-14 Thread Guangxu Cheng
much more compared to ReviewBoard. > > > > From: Peter Somogyi > > Reply-To: "dev@hbase.apache.org" > > Date: Wednesday, November 13, 2019 at 6:23 PM > > To: HBase Dev List > > Subject: Re: [DISCUSS] Deprecate Review Board in favor of Github reviews >

Re: [DISCUSS] Deprecate Review Board in favor of Github reviews

2019-11-14 Thread Duo Zhang
y, November 13, 2019 at 6:23 PM > To: HBase Dev List > Subject: Re: [DISCUSS] Deprecate Review Board in favor of Github reviews > > +1 > > Another issue with ReviewBoard is that it requires Apache ID so only > committers are able to create new reviews or even comment. >

Re: [DISCUSS] Deprecate Review Board in favor of Github reviews

2019-11-14 Thread Jan Hentschel
+1 I also like the GitHub way much more compared to ReviewBoard. From: Peter Somogyi Reply-To: "dev@hbase.apache.org" Date: Wednesday, November 13, 2019 at 6:23 PM To: HBase Dev List Subject: Re: [DISCUSS] Deprecate Review Board in favor of Github reviews +1 Another issue with R

Re: [DISCUSS] Deprecate Review Board in favor of Github reviews

2019-11-13 Thread Peter Somogyi
+1 Another issue with ReviewBoard is that it requires Apache ID so only committers are able to create new reviews or even comment. On Wed, Nov 13, 2019 at 5:21 PM Nick Dimiduk wrote: > Heya, > > Seems in the old days we were explicitly non-strict about where code review > were happening. I