[jira] [Commented] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread silver9886 (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156281#comment-16156281 ] silver9886 commented on HTTPCORE-489: - why don't give me a chance to raise a pr :( > sometimes unit

[GitHub] httpcomponents-client pull request #83: Fix typo in HttpClients.java javadoc

2017-09-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/httpcomponents-client/pull/83 --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org

[GitHub] httpcomponents-client pull request #83: Fix typo in HttpClients.java javadoc

2017-09-06 Thread andyklimczak
GitHub user andyklimczak opened a pull request: https://github.com/apache/httpcomponents-client/pull/83 Fix typo in HttpClients.java javadoc You can merge this pull request into a Git repository by running: $ git pull https://github.com/andyklimczak/httpcomponents-client

[jira] [Resolved] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCORE-489. Resolution: Fixed Fixed in master. Oleg > sometimes unit test will failed >

[jira] [Commented] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155459#comment-16155459 ] ASF subversion and git services commented on HTTPCORE-489: -- Commit

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155450#comment-16155450 ] ASF GitHub Bot commented on HTTPCORE-488: - Github user xiaohu-zhang closed the pull request at:

[GitHub] httpcomponents-core issue #51: Check connecttimeout when SelectionKey.OP_CON...

2017-09-06 Thread xiaohu-zhang
Github user xiaohu-zhang commented on the issue: https://github.com/apache/httpcomponents-core/pull/51 thank you --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail:

[GitHub] httpcomponents-core pull request #51: Check connecttimeout when SelectionKey...

2017-09-06 Thread xiaohu-zhang
Github user xiaohu-zhang closed the pull request at: https://github.com/apache/httpcomponents-core/pull/51 --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155447#comment-16155447 ] Oleg Kalnichevski commented on HTTPCORE-488: Cool. Please close the PR at Github if you are

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread silver9886 (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155424#comment-16155424 ] silver9886 commented on HTTPCORE-488: - you are right ! your change is execlent,I ignore the super

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread silver9886 (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155385#comment-16155385 ] silver9886 commented on HTTPCORE-488: - I think we have to discuss about it. In the pr,

[jira] [Resolved] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCORE-488. Resolution: Fixed Fix Version/s: 5.0-beta1 Committed to master with

[GitHub] httpcomponents-core issue #51: Check connecttimeout when SelectionKey.OP_CON...

2017-09-06 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcomponents-core/pull/51 Committed to master with changes. Please review and close. --- - To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155294#comment-16155294 ] ASF subversion and git services commented on HTTPCORE-488: -- Commit

[jira] [Commented] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155134#comment-16155134 ] Oleg Kalnichevski commented on HTTPCORE-489: No, it is not. It is Windows being crap. Oleg

[jira] [Commented] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread silver9886 (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16155125#comment-16155125 ] silver9886 commented on HTTPCORE-489: - Is it a bug? > sometimes unit test will failed >

[jira] [Updated] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread Oleg Kalnichevski (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski updated HTTPCORE-489: --- Affects Version/s: (was: 5.0-beta1) 5.0-alpha4

[GitHub] httpcomponents-core issue #51: Check connecttimeout when SelectionKey.OP_CON...

2017-09-06 Thread ok2c
Github user ok2c commented on the issue: https://github.com/apache/httpcomponents-core/pull/51 Could you please rebase your branch off the latest master and squash all your individual commits? There is also garbage in the change-set (commit-6349d92 file presumably checked in by

[jira] [Created] (HTTPCORE-489) sometimes unit test will failed

2017-09-06 Thread silver9886 (JIRA)
silver9886 created HTTPCORE-489: --- Summary: sometimes unit test will failed Key: HTTPCORE-489 URL: https://issues.apache.org/jira/browse/HTTPCORE-489 Project: HttpComponents HttpCore Issue

[jira] [Commented] (HTTPCORE-488) SingleCoreIOReactor.connect methods timeout parameter do not have effect.

2017-09-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/HTTPCORE-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154927#comment-16154927 ] ASF GitHub Bot commented on HTTPCORE-488: - GitHub user xiaohu-zhang opened a pull request:

[GitHub] httpcomponents-core pull request #51: Check connecttimeout when SelectionKey...

2017-09-06 Thread xiaohu-zhang
GitHub user xiaohu-zhang opened a pull request: https://github.com/apache/httpcomponents-core/pull/51 Check connecttimeout when SelectionKey.OP_CONNECT event happend related to HTTPCORE-488 InternalConnectChannel onTimeout should also invoke close method You can merge this pull