[GitHub] [httpcomponents-core] ok2c commented on pull request #282: Improved parsing and formatting of URI components

ok2c commented on pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#issuecomment-817492314 > Code reduction and reuse. Plus a clear logical hierarchy (not talking about inheritance). @michael-o I am not entirely sure if it is really worth it but so be

[GitHub] [httpcomponents-core] michael-o commented on pull request #282: Improved parsing and formatting of URI components

michael-o commented on pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#issuecomment-817357731 > > > > Looking at `HttpHost` again, it can wipe internal fields as well for a `Host` instance just like you have done with `URIAuthority`. > >

[GitHub] [httpcomponents-core] ok2c commented on pull request #282: Improved parsing and formatting of URI components

ok2c commented on pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#issuecomment-817356428 > Looking at `HttpHost` again, it can wipe internal fields as well for a `Host` instance just like you have done with `URIAuthority`. @michael-o What would be the

[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #282: Improved parsing and formatting of URI components

michael-o commented on a change in pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#discussion_r611231969 ## File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java ## @@ -87,23 +64,8 @@ static URIAuthority parse(final

[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #282: Improved parsing and formatting of URI components

ok2c commented on a change in pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#discussion_r611231261 ## File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java ## @@ -87,23 +64,8 @@ static URIAuthority parse(final

[GitHub] [httpcomponents-core] michael-o commented on pull request #282: Improved parsing and formatting of URI components

michael-o commented on pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#issuecomment-817354739 Looking at `HttpHost` again, it can wipe internal fields as well for a `Host` instance just like you have done with `URIAuthority`. -- This is an automated

[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #282: Improved parsing and formatting of URI components

michael-o commented on a change in pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#discussion_r611229882 ## File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java ## @@ -87,23 +64,8 @@ static URIAuthority parse(final

[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #282: Improved parsing and formatting of URI components

ok2c commented on a change in pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#discussion_r611228991 ## File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java ## @@ -87,23 +64,8 @@ static URIAuthority parse(final

[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #282: Improved parsing and formatting of URI components

michael-o commented on a change in pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#discussion_r611228377 ## File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java ## @@ -87,23 +64,8 @@ static URIAuthority parse(final

[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #282: Improved parsing and formatting of URI components

ok2c commented on a change in pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#discussion_r611227791 ## File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java ## @@ -87,23 +64,8 @@ static URIAuthority parse(final

[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #282: Improved parsing and formatting of URI components

michael-o commented on a change in pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#discussion_r61170 ## File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java ## @@ -87,23 +64,8 @@ static URIAuthority parse(final

[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #282: Improved parsing and formatting of URI components

ok2c commented on a change in pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#discussion_r611221696 ## File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java ## @@ -87,23 +64,8 @@ static URIAuthority parse(final

[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #282: Improved parsing and formatting of URI components

ok2c commented on a change in pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#discussion_r611219179 ## File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java ## @@ -87,23 +64,8 @@ static URIAuthority parse(final

[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #282: Improved parsing and formatting of URI components

michael-o commented on a change in pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#discussion_r611218688 ## File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java ## @@ -87,23 +64,8 @@ static URIAuthority parse(final

[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #282: Improved parsing and formatting of URI components

ok2c commented on a change in pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#discussion_r611218097 ## File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java ## @@ -87,23 +64,8 @@ static URIAuthority parse(final

[GitHub] [httpcomponents-core] michael-o commented on a change in pull request #282: Improved parsing and formatting of URI components

michael-o commented on a change in pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#discussion_r611210813 ## File path: httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java ## @@ -87,23 +64,8 @@ static URIAuthority parse(final

[jira] [Closed] (HTTPCLIENT-2148) fluent Executor volatile access allows NPEs

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak closed HTTPCLIENT-2148. > fluent Executor volatile access allows NPEs >

[jira] [Resolved] (HTTPCLIENT-2148) fluent Executor volatile access allows NPEs

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carter Kozak resolved HTTPCLIENT-2148. -- Fix Version/s: 5.1-beta2 5.0.4 Resolution: Fixed Merged

[jira] [Commented] (HTTPCLIENT-2148) fluent Executor volatile access allows NPEs

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318803#comment-17318803 ] ASF subversion and git services commented on HTTPCLIENT-2148: - Commit

[jira] [Commented] (HTTPCLIENT-2148) fluent Executor volatile access allows NPEs

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318798#comment-17318798 ] ASF subversion and git services commented on HTTPCLIENT-2148: - Commit

[GitHub] [httpcomponents-client] carterkozak merged pull request #301: HTTPCLIENT-2148: fluent Executor volatile access thread safety

carterkozak merged pull request #301: URL: https://github.com/apache/httpcomponents-client/pull/301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about

[GitHub] [httpcomponents-core] carterkozak commented on pull request #282: Improved parsing and formatting of URI components

carterkozak commented on pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#issuecomment-817308543 I believe the plan was to merge this before my change -- after a rebase it should make my modifications much simpler. -- This is an automated message from the

[GitHub] [httpcomponents-core] arturobernalg commented on pull request #282: Improved parsing and formatting of URI components

arturobernalg commented on pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#issuecomment-817302435 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [httpcomponents-core] michael-o commented on pull request #282: Improved parsing and formatting of URI components

michael-o commented on pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#issuecomment-817290185 @ok2c Should this be merged before Carter's work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [httpcomponents-core] michael-o commented on pull request #282: Improved parsing and formatting of URI components

michael-o commented on pull request #282: URL: https://github.com/apache/httpcomponents-core/pull/282#issuecomment-817288335 I will review this next week. I already see issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (HTTPCLIENT-2150) Update to Apache Commons Codec 1.15

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318705#comment-17318705 ] Jochen Schalanda commented on HTTPCLIENT-2150: -- Thanks for the update. {quote}You will

[jira] [Closed] (HTTPCLIENT-2150) Update to Apache Commons Codec 1.15

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed HTTPCLIENT-2150. -- Resolution: Duplicate > Update to Apache Commons Codec 1.15 >

[jira] [Comment Edited] (HTTPCLIENT-2150) Update to Apache Commons Codec 1.15

[ https://issues.apache.org/jira/browse/HTTPCLIENT-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318594#comment-17318594 ] Michael Osipov edited comment on HTTPCLIENT-2150 at 4/11/21, 9:07 AM: