[GitHub] [httpcomponents-client] michael-o commented on pull request #399: Bearer auth support

michael-o commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347326058 > @michael-o what is it exactly that you want me to change now? Only the `toString()` is questionable, the rest is fine. Let me give it a shot tomorrow. -- This is

[GitHub] [httpcomponents-client] ok2c commented on pull request #399: Bearer auth support

ok2c commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347258295 @michael-o what is it exactly that you want me to change now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #399: Bearer auth support

ok2c commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046343685 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * ==

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046341201 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,95 @@ +/* + * ==

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046339102 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * =

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046302493 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * =

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #399: Bearer auth support

ok2c commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046296139 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * ==

[GitHub] [httpcomponents-client] michael-o commented on pull request #399: Bearer auth support

michael-o commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347170203 > > @ok2c Can you explain why you use the `realm` parameter actively with Bearer altough rfc6749 does not mention it once? I only see these: https://datatracker.ietf.org/do

[GitHub] [httpcomponents-client] ok2c commented on pull request #399: Bearer auth support

ok2c commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347162852 > @ok2c Can you explain why you use the `realm` parameter actively with Bearer altough rfc6749 does not mention it once? I only see these: https://datatracker.ietf.org/doc/html/

[GitHub] [httpcomponents-client] michael-o commented on pull request #399: Bearer auth support

michael-o commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347141146 @ok2c Can you explain why you use the `realm` parameter actively with Bearer altough rfc6749 does not mention it once? I only see these: https://datatracker.ietf.org/doc/ht

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046272608 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/UsernamePasswordCredentials.java: ## @@ -45,22 +45,36 @@ public class UsernamePasswordCreden

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046270523 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * =

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046269591 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * =

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #399: Bearer auth support

ok2c commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046267743 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * ==

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #399: Bearer auth support

ok2c commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046267743 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * ==

[GitHub] [httpcomponents-client] michael-o commented on pull request #399: Bearer auth support

michael-o commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347116449 > @michael-o I have a feeling we are talking blondes vs brunettes here, but have it the way you like it. Please review I like both, I am not picky :-D -- This is a

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046260885 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * =

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1046257968 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * =

[GitHub] [httpcomponents-client] ok2c commented on pull request #399: Bearer auth support

ok2c commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1347056473 @michael-o I have a feeling we are talking blondes vs brunettes here, but have it the way you like it. Please review -- This is an automated message from the Apache Git Servic

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045837033 ## httpclient5-testing/src/main/java/org/apache/hc/client5/testing/auth/BasicAuthenticationHandler.java: ## @@ -27,13 +27,27 @@ package org.apache.hc.

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045824851 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * =

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #399: Bearer auth support

ok2c commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045817334 ## httpclient5-testing/src/main/java/org/apache/hc/client5/testing/auth/BasicAuthenticationHandler.java: ## @@ -27,13 +27,27 @@ package org.apache.hc.clien

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #399: Bearer auth support

ok2c commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045816086 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * ==

[GitHub] [httpcomponents-client] michael-o commented on pull request #399: Bearer auth support

michael-o commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1346436026 Two more questions left, I will try this in production. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045786273 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * =

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #399: Bearer auth support

ok2c commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045775614 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * ==

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045763985 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * =

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #399: Bearer auth support

ok2c commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045756872 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * ==

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045738039 ## httpclient5-testing/src/main/java/org/apache/hc/client5/testing/auth/BasicAuthenticationHandler.java: ## @@ -27,13 +27,27 @@ package org.apache.hc.

[GitHub] [httpcomponents-client] michael-o commented on pull request #399: Bearer auth support

michael-o commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1346334453 > > Don't add runtime exceptions to method signatures. They belong into Javadoc. See Effective Java from Joshua Bloch. > > @michael-o I must say I disagree with Joshu

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045722003 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * =

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #399: Bearer auth support

ok2c commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045689705 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * ==

[GitHub] [httpcomponents-client] ok2c commented on a diff in pull request #399: Bearer auth support

ok2c commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045684393 ## httpclient5-testing/src/main/java/org/apache/hc/client5/testing/auth/Authenticator.java: ## @@ -31,6 +31,13 @@ public interface Authenticator { +/

[GitHub] [httpcomponents-client] ok2c commented on pull request #399: Bearer auth support

ok2c commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1346274196 > Don't add runtime exceptions to method signatures. They belong into Javadoc. See Effective Java from Joshua Bloch. @ok2c I must say I disagree with Joshua Bloch in this

JDK 20 Rampdown Phase 1 & Valhalla LW4 Early-Access builds

Welcome to the final OpenJDK Quality Outreach update for 2022! JDK 20, scheduled for General Availability on March 21 2023, is now in Rampdown Phase One (RDP1) [1]. At this point, the overall JDK 20 [2] feature set is frozen (see below the final list of JEPs integrated into JDK 20) and only lo

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045590335 ## httpclient5/src/main/java/org/apache/hc/client5/http/auth/BearerToken.java: ## @@ -0,0 +1,120 @@ +/* + * =

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #399: Bearer auth support

michael-o commented on code in PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#discussion_r1045580875 ## httpclient5-testing/src/main/java/org/apache/hc/client5/testing/auth/TokenBearerAuthenticationHandler.java: ## @@ -0,0 +1,44 @@ +/* + * ==