[GitHub] [httpcomponents-client] michael-o commented on pull request #399: Bearer auth support

2023-01-07 Thread GitBox
michael-o commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1374477027 > > > Why is this an issue, let alone a blocker? > > > > > > I bet there will be clowns complaining about this. I never wrote that this is a blocker. > > O

[GitHub] [httpcomponents-client] ok2c commented on pull request #399: Bearer auth support

2023-01-07 Thread GitBox
ok2c commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-137876 > > Why is this an issue, let alone a blocker? > > I bet there will be clowns complaining about this. I never wrote that this is a blocker. > OK. This I can unde

[GitHub] [httpcomponents-client] michael-o commented on pull request #399: Bearer auth support

2023-01-07 Thread GitBox
michael-o commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1374437550 > > > @michael-o Out of curiosity, how long do you intend to block this PR? > > > > > > ??? There are still unresolved issues: > > Issues? > > > ```

[GitHub] [httpcomponents-client] ok2c commented on pull request #399: Bearer auth support

2023-01-07 Thread GitBox
ok2c commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1374436754 > > @michael-o Out of curiosity, how long do you intend to block this PR? > > ??? There are still unresolved issues: > Issues? > * `toString()` unnece

[GitHub] [httpcomponents-client] michael-o commented on pull request #399: Bearer auth support

2023-01-07 Thread GitBox
michael-o commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1374432854 > @michael-o Out of curiosity, how long do you intend to block this PR? ??? There are still unresolved issues: * `toString()` unnecessarily exposes the token * `

Re: [VOTE] Release HttpCore 5.2.1 based on RC1

2023-01-07 Thread Michael Osipov
Am 2023-01-07 um 11:14 schrieb Oleg Kalnichevski: On Sat, 2023-01-07 at 09:41 +0100, Michael Osipov wrote: Am 2023-01-07 um 09:16 schrieb Oleg Kalnichevski: Please vote on releasing these packages as HttpCore 5.2.1. The vote is open for the at least 72 hours, and only votes from HttpComponents

[GitHub] [httpcomponents-client] ok2c commented on pull request #399: Bearer auth support

2023-01-07 Thread GitBox
ok2c commented on PR #399: URL: https://github.com/apache/httpcomponents-client/pull/399#issuecomment-1374431955 @michael-o Out of curiosity, how long do you intend to block this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [VOTE] Release HttpCore 5.2.1 based on RC1

2023-01-07 Thread Oleg Kalnichevski
On Sat, 2023-01-07 at 09:41 +0100, Michael Osipov wrote: > Am 2023-01-07 um 09:16 schrieb Oleg Kalnichevski: > > Please vote on releasing these packages as HttpCore 5.2.1. > > The vote is open for the at least 72 hours, and only votes from > > HttpComponents PMC members are binding. The vote passes

Re: [VOTE] Release HttpCore 5.2.1 based on RC1

2023-01-07 Thread Michael Osipov
Am 2023-01-07 um 09:16 schrieb Oleg Kalnichevski: Please vote on releasing these packages as HttpCore 5.2.1. The vote is open for the at least 72 hours, and only votes from HttpComponents PMC members are binding. The vote passes if at least three binding +1 votes are cast and there are more +1 th

[VOTE] Release HttpCore 5.2.1 based on RC1

2023-01-07 Thread Oleg Kalnichevski
Please vote on releasing these packages as HttpCore 5.2.1. The vote is open for the at least 72 hours, and only votes from HttpComponents PMC members are binding. The vote passes if at least three binding +1 votes are cast and there are more +1 than -1 votes. Release notes: https://dist.apache.o