[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #423: HTTPCORE-756 - Enforced the requirement that "https" URIs must not have an empty host identifier

2023-09-01 Thread via GitHub
ok2c commented on code in PR #423: URL: https://github.com/apache/httpcomponents-core/pull/423#discussion_r1312747037 ## httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java: ## @@ -260,41 +260,41 @@ public void cancelled() { @Test void

[GitHub] [httpcomponents-core] ok2c commented on a diff in pull request #423: HTTPCORE-756 - Enforced the requirement that "https" URIs must not have an empty host identifier

2023-08-31 Thread via GitHub
ok2c commented on code in PR #423: URL: https://github.com/apache/httpcomponents-core/pull/423#discussion_r1311292928 ## httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java: ## @@ -313,11 +314,14 @@ public URI build() throws URISyntaxException { return new