Re: Use of final keyword

2013-01-15 Thread Oleg Kalnichevski
On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: Over in Log4J-land, we've discussed [1] the use of the final keyword for locals and parameters. In brief [1]: The final keyword in trunk: sometimes it is used, sometimes not. I propose we use it all over consistently. [1] http

Re: Use of final keyword

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski ol...@apache.org wrote: On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: Over in Log4J-land, we've discussed [1] the use of the final keyword for locals and parameters. In brief [1]: The final keyword in trunk: sometimes it is used

Re: Use of final keyword

2013-01-15 Thread Gary Gregory
, we've discussed [1] the use of the final keyword for locals and parameters. In brief [1]: The final keyword in trunk: sometimes it is used, sometimes not. I propose we use it all over consistently. [1] http://apache-logging.6191.n7.nabble.com/v2-final-keyword-td17452.html

Re: Use of final keyword

2013-01-15 Thread Gary Gregory
, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: Over in Log4J-land, we've discussed [1] the use of the final keyword for locals and parameters. In brief [1]: The final keyword in trunk: sometimes it is used, sometimes not. I propose we use it all over consistently. [1

Re: Use of final keyword

2013-01-15 Thread Oleg Kalnichevski
:46 AM, Oleg Kalnichevski ol...@apache.org wrote: On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: Over in Log4J-land, we've discussed [1] the use of the final keyword for locals and parameters. In brief [1]: The final keyword in trunk: sometimes it is used

Re: Use of final keyword

2013-01-15 Thread Gary Gregory
On Tue, Jan 15, 2013 at 9:46 AM, Oleg Kalnichevski ol...@apache.org wrote: On Tue, 2013-01-15 at 08:26 -0500, Gary Gregory wrote: Over in Log4J-land, we've discussed [1] the use of the final keyword for locals and parameters. In brief [1]: The final keyword in trunk: sometimes it is used